| Message ID | 20200521220648.3255-1-vsementsov@virtuozzo.com |
|---|---|
| Headers | show |
| Series | fix migration with bitmaps and mirror | expand |
On 5/21/20 5:06 PM, Vladimir Sementsov-Ogievskiy wrote: > v4: (Max's patch marking filters as filters already in master) > 03: careful select child of filter, avoid crash > 04: add Eric's r-b > 05-06: tweak error message, keep Andrey's r-b, add Eric's r-b > > Vladimir Sementsov-Ogievskiy (6): > migration/block-dirty-bitmap: refactor init_dirty_bitmap_migration > block/dirty-bitmap: add bdrv_has_named_bitmaps helper > migration/block-dirty-bitmap: fix bitmaps pre-blockdev migration > during mirror job > iotests: 194: test also migration of dirty bitmap > migration/block-dirty-bitmap: add_bitmaps_to_list: check disk name > once > migration/block-dirty-bitmap: forbid migration by generated node-name 3 and 5 have rather long subject lines, as shown by the wrapping inserted by git (3 even exceeds 80 columns on its own, even before git adds prefixing). Should I try to touch this up in my staging queue? For example: migration: fix non-blockdev bitmap migration with mirror doesn't lose too much information, but is definitely shorter for 3.
22.05.2020 18:24, Eric Blake wrote: > On 5/21/20 5:06 PM, Vladimir Sementsov-Ogievskiy wrote: >> v4: (Max's patch marking filters as filters already in master) >> 03: careful select child of filter, avoid crash >> 04: add Eric's r-b >> 05-06: tweak error message, keep Andrey's r-b, add Eric's r-b >> >> Vladimir Sementsov-Ogievskiy (6): >> migration/block-dirty-bitmap: refactor init_dirty_bitmap_migration >> block/dirty-bitmap: add bdrv_has_named_bitmaps helper >> migration/block-dirty-bitmap: fix bitmaps pre-blockdev migration >> during mirror job >> iotests: 194: test also migration of dirty bitmap >> migration/block-dirty-bitmap: add_bitmaps_to_list: check disk name >> once >> migration/block-dirty-bitmap: forbid migration by generated node-name > > 3 and 5 have rather long subject lines, as shown by the wrapping inserted by git (3 even exceeds 80 columns on its own, even before git adds prefixing). Should I try to touch this up in my staging queue? For example: > > migration: fix non-blockdev bitmap migration with mirror > > doesn't lose too much information, but is definitely shorter for 3. > No objections, of course
v4: (Max's patch marking filters as filters already in master) 03: careful select child of filter, avoid crash 04: add Eric's r-b 05-06: tweak error message, keep Andrey's r-b, add Eric's r-b Vladimir Sementsov-Ogievskiy (6): migration/block-dirty-bitmap: refactor init_dirty_bitmap_migration block/dirty-bitmap: add bdrv_has_named_bitmaps helper migration/block-dirty-bitmap: fix bitmaps pre-blockdev migration during mirror job iotests: 194: test also migration of dirty bitmap migration/block-dirty-bitmap: add_bitmaps_to_list: check disk name once migration/block-dirty-bitmap: forbid migration by generated node-name include/block/dirty-bitmap.h | 1 + block/dirty-bitmap.c | 13 ++++ migration/block-dirty-bitmap.c | 130 ++++++++++++++++++++++++--------- tests/qemu-iotests/194 | 14 +++- tests/qemu-iotests/194.out | 6 ++ 5 files changed, 127 insertions(+), 37 deletions(-)