From patchwork Wed Apr 15 13:01:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Klaus Jensen X-Patchwork-Id: 1271166 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 492N2T0XDqz9sTw for ; Wed, 15 Apr 2020 23:08:17 +1000 (AEST) Received: from localhost ([::1]:49720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOhm3-0006gs-0k for incoming@patchwork.ozlabs.org; Wed, 15 Apr 2020 09:08:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33704) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOhgU-0007DW-JQ for qemu-devel@nongnu.org; Wed, 15 Apr 2020 09:02:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOhgO-0004Bv-IA for qemu-devel@nongnu.org; Wed, 15 Apr 2020 09:02:30 -0400 Received: from charlie.dont.surf ([128.199.63.193]:48514) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jOhgL-00044a-1P; Wed, 15 Apr 2020 09:02:21 -0400 Received: from apples.local (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by charlie.dont.surf (Postfix) with ESMTPSA id 5FB3FBF7AF; Wed, 15 Apr 2020 13:02:19 +0000 (UTC) From: Klaus Jensen To: qemu-block@nongnu.org Subject: [PATCH v2 00/16] nvme: refactoring and cleanups Date: Wed, 15 Apr 2020 15:01:43 +0200 Message-Id: <20200415130159.611361-1-its@irrelevant.dk> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 128.199.63.193 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Beata Michalska , Klaus Jensen , qemu-devel@nongnu.org, Max Reitz , Klaus Jensen , Keith Busch , Javier Gonzalez , Maxim Levitsky , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Klaus Jensen Changes since v1 ~~~~~~~~~~~~~~~~ * nvme: fix pci doorbell size calculation - added some defines and a better comment (Philippe) * nvme: rename trace events to pci_nvme - changed the prefix from nvme_dev to pci_nvme (Philippe) * nvme: add max_ioqpairs device parameter - added a deprecation comment. I doubt this will go in until 5.1, so changed it to "deprecated from 5.1" (Philippe) * nvme: factor out property/constraint checks * nvme: factor out block backend setup - changed to return void and propagate errors in proper QEMU style (Philippe) * nvme: add namespace helpers - use the helper immediately (Philippe) * nvme: factor out pci setup - removed setting of vendor and device id which is already inherited from nvme_class_init() (Philippe) * nvme: factor out cmb setup - add lost comment (Philippe) Klaus Jensen (16): nvme: fix pci doorbell size calculation nvme: rename trace events to pci_nvme nvme: remove superfluous breaks nvme: move device parameters to separate struct nvme: use constants in identify nvme: refactor nvme_addr_read nvme: add max_ioqpairs device parameter nvme: remove redundant cmbloc/cmbsz members nvme: factor out property/constraint checks nvme: factor out device state setup nvme: factor out block backend setup nvme: add namespace helpers nvme: factor out namespace setup nvme: factor out pci setup nvme: factor out cmb setup nvme: factor out controller identify setup hw/block/nvme.c | 433 ++++++++++++++++++++++++------------------ hw/block/nvme.h | 36 +++- hw/block/trace-events | 172 ++++++++--------- include/block/nvme.h | 8 + 4 files changed, 372 insertions(+), 277 deletions(-) Reviewed-by: Keith Busch