| Message ID | 20200331000014.11581-1-jsnow@redhat.com |
|---|---|
| Headers | show |
| Series | iotests: use python logging | expand |
Am 31.03.2020 um 02:00 hat John Snow geschrieben: > This series uses python logging to enable output conditionally on > iotests.log(). We unify an initialization call (which also enables > debugging output for those tests with -d) and then make the switch > inside of iotests. > > It will help alleviate the need to create logged/unlogged versions > of all the various helpers we have made. > > Also, I got lost and accidentally delinted iotests while I was here. > Sorry about that. By version 9, it's now the overwhelming focus of > this series. No good deed, etc. Reviewed-by: Kevin Wolf <kwolf@redhat.com>
On 31.03.20 02:00, John Snow wrote: > This series uses python logging to enable output conditionally on > iotests.log(). We unify an initialization call (which also enables > debugging output for those tests with -d) and then make the switch > inside of iotests. > > It will help alleviate the need to create logged/unlogged versions > of all the various helpers we have made. > > Also, I got lost and accidentally delinted iotests while I was here. > Sorry about that. By version 9, it's now the overwhelming focus of > this series. No good deed, etc. Seems like nobody else wants it, so I thank you and let you know that I’ve applied this series to my block-next branch: https://git.xanclic.moe/XanClic/qemu/commits/branch/block-next Max
Am 28.04.2020 um 13:46 hat Max Reitz geschrieben: > On 31.03.20 02:00, John Snow wrote: > > This series uses python logging to enable output conditionally on > > iotests.log(). We unify an initialization call (which also enables > > debugging output for those tests with -d) and then make the switch > > inside of iotests. > > > > It will help alleviate the need to create logged/unlogged versions > > of all the various helpers we have made. > > > > Also, I got lost and accidentally delinted iotests while I was here. > > Sorry about that. By version 9, it's now the overwhelming focus of > > this series. No good deed, etc. > > Seems like nobody else wants it, so I thank you and let you know that > I’ve applied this series to my block-next branch: > > https://git.xanclic.moe/XanClic/qemu/commits/branch/block-next John said he wanted to address my comment on patch 14, so I expected him to send another version. This need not stop this series (we can still fix that on top), but just as an explanation why I didn't take it yet. Kevin
On 4/28/20 8:21 AM, Kevin Wolf wrote: > Am 28.04.2020 um 13:46 hat Max Reitz geschrieben: >> On 31.03.20 02:00, John Snow wrote: >>> This series uses python logging to enable output conditionally on >>> iotests.log(). We unify an initialization call (which also enables >>> debugging output for those tests with -d) and then make the switch >>> inside of iotests. >>> >>> It will help alleviate the need to create logged/unlogged versions >>> of all the various helpers we have made. >>> >>> Also, I got lost and accidentally delinted iotests while I was here. >>> Sorry about that. By version 9, it's now the overwhelming focus of >>> this series. No good deed, etc. >> >> Seems like nobody else wants it, so I thank you and let you know that >> I’ve applied this series to my block-next branch: >> >> https://git.xanclic.moe/XanClic/qemu/commits/branch/block-next > > John said he wanted to address my comment on patch 14, so I expected him > to send another version. This need not stop this series (we can still > fix that on top), but just as an explanation why I didn't take it yet. > > Kevin > Sorry, foggy memory. I will send a follow-up and we can try to squash it in.
On 28.04.20 19:36, John Snow wrote: > > > On 4/28/20 8:21 AM, Kevin Wolf wrote: >> Am 28.04.2020 um 13:46 hat Max Reitz geschrieben: >>> On 31.03.20 02:00, John Snow wrote: >>>> This series uses python logging to enable output conditionally on >>>> iotests.log(). We unify an initialization call (which also enables >>>> debugging output for those tests with -d) and then make the switch >>>> inside of iotests. >>>> >>>> It will help alleviate the need to create logged/unlogged versions >>>> of all the various helpers we have made. >>>> >>>> Also, I got lost and accidentally delinted iotests while I was here. >>>> Sorry about that. By version 9, it's now the overwhelming focus of >>>> this series. No good deed, etc. >>> >>> Seems like nobody else wants it, so I thank you and let you know that >>> I’ve applied this series to my block-next branch: >>> >>> https://git.xanclic.moe/XanClic/qemu/commits/branch/block-next >> >> John said he wanted to address my comment on patch 14, so I expected him >> to send another version. This need not stop this series (we can still >> fix that on top), but just as an explanation why I didn't take it yet. >> >> Kevin >> > > Sorry, foggy memory. I will send a follow-up and we can try to squash it in. All right. Max
This series uses python logging to enable output conditionally on iotests.log(). We unify an initialization call (which also enables debugging output for those tests with -d) and then make the switch inside of iotests. It will help alleviate the need to create logged/unlogged versions of all the various helpers we have made. Also, I got lost and accidentally delinted iotests while I was here. Sorry about that. By version 9, it's now the overwhelming focus of this series. No good deed, etc. V10: 001/14:[0004] [FC] 'iotests: do a light delinting' 002/14:[----] [--] 'iotests: don't use 'format' for drive_add' 003/14:[----] [--] 'iotests: ignore import warnings from pylint' 004/14:[----] [--] 'iotests: replace mutable list default args' 005/14:[0006] [FC] 'iotests: add pylintrc file' 006/14:[----] [--] 'iotests: alphabetize standard imports' 007/14:[----] [--] 'iotests: drop pre-Python 3.4 compatibility code' 008/14:[----] [--] 'iotests: touch up log function signature' 009/14:[----] [-C] 'iotests: limit line length to 79 chars' 010/14:[0009] [FC] 'iotests: add hmp helper with logging' 011/14:[0019] [FC] 'iotests: add script_initialize' 012/14:[----] [--] 'iotest 258: use script_main' 013/14:[0013] [FC] 'iotests: Mark verify functions as private' 014/14:[0001] [FC] 'iotests: use python logging for iotests.log()' 001: replace "atom" name with "item". Kept RBs. 005: Alphabetized excluded warnings list. Kept RBs. Kevin's comments addressed by using pylint >= 2.2.0 009: Added Max's RB. Updated commit message based on Max's response Kevin's comments addressed by mypy >= 0.620 010: Fixed type hints (Kevin) 011: Replace 'Collection' with 'Sequence' to work around pylint/python 3.6 013: Update type signatures of _verify functions (Kevin) 014: Minor whitespace changes as the fault handler gets shuffled around. V9: 006: New. 007: Split from old patch. 008: Split from old patch; enhanced a little to justify its own patch. 010: New, pulled in from bitmap-populate series. Helps line length. 011: Reflow columns for long `typing` import list. (Kept RB.) 014: New blank line. (Kept RB.) V8: - Split out the little drop of Python 3.4 code. (Phil) - Change line continuation styles (QEMU Memorial Choir) - Rebase changes; remove use_log from more places, adjust test output. V7: - All delinting patches are now entirely front-loaded. - Redid delinting to avoid "correcting" no-else-return statements. - Moved more mutable list corrections into patch 4, to make it standalone. - Moved pylintrc up to patch 5. Disabled no-else-return. - Added patch 6 to require line length checks. (Some python 3.4 compatibility code is removed as a consequence.) - Patch 7 changes slightly as a result of patch 4 changes. - Added some logging explainer into patch 10. (Patch changes slightly because of patch 6.) V6: - It's been so long since V5, let's just look at it anew. John Snow (14): iotests: do a light delinting iotests: don't use 'format' for drive_add iotests: ignore import warnings from pylint iotests: replace mutable list default args iotests: add pylintrc file iotests: alphabetize standard imports iotests: drop pre-Python 3.4 compatibility code iotests: touch up log function signature iotests: limit line length to 79 chars iotests: add hmp helper with logging iotests: add script_initialize iotest 258: use script_main iotests: Mark verify functions as private iotests: use python logging for iotests.log() tests/qemu-iotests/030 | 4 +- tests/qemu-iotests/055 | 3 +- tests/qemu-iotests/149 | 3 +- tests/qemu-iotests/155 | 2 +- tests/qemu-iotests/194 | 4 +- tests/qemu-iotests/202 | 4 +- tests/qemu-iotests/203 | 4 +- tests/qemu-iotests/206 | 2 +- tests/qemu-iotests/207 | 6 +- tests/qemu-iotests/208 | 2 +- tests/qemu-iotests/209 | 2 +- tests/qemu-iotests/210 | 6 +- tests/qemu-iotests/211 | 6 +- tests/qemu-iotests/212 | 6 +- tests/qemu-iotests/213 | 6 +- tests/qemu-iotests/216 | 4 +- tests/qemu-iotests/218 | 2 +- tests/qemu-iotests/219 | 2 +- tests/qemu-iotests/222 | 7 +- tests/qemu-iotests/224 | 4 +- tests/qemu-iotests/228 | 6 +- tests/qemu-iotests/234 | 4 +- tests/qemu-iotests/235 | 4 +- tests/qemu-iotests/236 | 2 +- tests/qemu-iotests/237 | 2 +- tests/qemu-iotests/238 | 2 + tests/qemu-iotests/242 | 2 +- tests/qemu-iotests/245 | 1 + tests/qemu-iotests/245.out | 24 +-- tests/qemu-iotests/246 | 2 +- tests/qemu-iotests/248 | 2 +- tests/qemu-iotests/254 | 2 +- tests/qemu-iotests/255 | 2 +- tests/qemu-iotests/256 | 2 +- tests/qemu-iotests/258 | 10 +- tests/qemu-iotests/260 | 4 +- tests/qemu-iotests/262 | 4 +- tests/qemu-iotests/264 | 4 +- tests/qemu-iotests/277 | 2 + tests/qemu-iotests/280 | 8 +- tests/qemu-iotests/283 | 4 +- tests/qemu-iotests/iotests.py | 366 ++++++++++++++++++++-------------- tests/qemu-iotests/pylintrc | 26 +++ 43 files changed, 343 insertions(+), 221 deletions(-) create mode 100644 tests/qemu-iotests/pylintrc