From patchwork Wed Feb 26 00:44:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: John Snow X-Patchwork-Id: 1244587 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WlNpwhHc; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48RxsY0cClz9sRJ for ; Wed, 26 Feb 2020 11:45:05 +1100 (AEDT) Received: from localhost ([::1]:36492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6kow-0004zg-VN for incoming@patchwork.ozlabs.org; Tue, 25 Feb 2020 19:45:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46573) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6koS-0004zB-IM for qemu-devel@nongnu.org; Tue, 25 Feb 2020 19:44:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6koQ-0003b4-RM for qemu-devel@nongnu.org; Tue, 25 Feb 2020 19:44:31 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:34818 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6koQ-0003Xn-Ah for qemu-devel@nongnu.org; Tue, 25 Feb 2020 19:44:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582677869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tKjIsZuF/s9kTNpGt2Om7FG4wUmiUeqH03UP+F7TdSY=; b=WlNpwhHcAsg66p2lE/R5XrD536UOkFG5JzS0tgy29p7ZCu0cl0LTM6nG24udvjZBLTRoMk 2/lVx5K3PwHj2oPY0CXUkrIOuoDTmgcwdYwPTMj6BPKNOgsLaRgKUFGckJ8Dr+euNVDDBr vu+4JVk6plUNc97TUEljhcD5GXwUaME= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-472-X43h1Z0ePxGNaFOIJ4XcrA-1; Tue, 25 Feb 2020 19:44:27 -0500 X-MC-Unique: X43h1Z0ePxGNaFOIJ4XcrA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 83248477; Wed, 26 Feb 2020 00:44:26 +0000 (UTC) Received: from probe.bos.redhat.com (dhcp-17-182.bos.redhat.com [10.18.17.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id C4FA48C076; Wed, 26 Feb 2020 00:44:25 +0000 (UTC) From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH 0/2] iotests: complicate run_job with this one weird trick? Date: Tue, 25 Feb 2020 19:44:23 -0500 Message-Id: <20200226004425.1303-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , John Snow , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Requires: 20200225005641.5478-1-jsnow@redhat.com I'm kidding, but do treat this as an RFC. I doodled a little code change and wasn't sure if it was appropriate because it's not really a simplification. The basic idea is to make a generic job runtime manager and allow callers to subclass the manager. Then, instead of adding callback arguments to the function all the time, we have à la carte customization of the loop. To showcase this a little bit, I removed the pre_finalization argument and made existing callers use a custom JobRunner; and then converted test 040 to use this style of job runner. Letmeknowwhatchathink. John Snow (2): iotests: add JobRunner class iotests: modify test 040 to use JobRunner tests/qemu-iotests/040 | 51 +++++----- tests/qemu-iotests/255 | 9 +- tests/qemu-iotests/257 | 12 ++- tests/qemu-iotests/287 | 19 +++- tests/qemu-iotests/iotests.py | 176 ++++++++++++++++++++++++---------- 5 files changed, 183 insertions(+), 84 deletions(-)