From patchwork Thu Dec 12 22:20:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juan Quintela X-Patchwork-Id: 1208857 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="TMHwXyBN"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47YpDf21bBz9sPK for ; Fri, 13 Dec 2019 09:21:35 +1100 (AEDT) Received: from localhost ([::1]:37804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifWps-0005Tt-OI for incoming@patchwork.ozlabs.org; Thu, 12 Dec 2019 17:21:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53686) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifWpA-0005TQ-P6 for qemu-devel@nongnu.org; Thu, 12 Dec 2019 17:20:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifWp9-00075a-P7 for qemu-devel@nongnu.org; Thu, 12 Dec 2019 17:20:44 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:47280 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ifWp9-0006y8-Kt for qemu-devel@nongnu.org; Thu, 12 Dec 2019 17:20:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576189240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5cneVVudEh2WomY6R4hYvMD2yNRDM2PEnQc/eAwWfYM=; b=TMHwXyBNRI/C/p+q7bLtBTM6nVPnzyoV9yY+0hTHrFLrZgUz2AiwVAK3aKKWNYaZJp8PbF duCxVpY+AN08ugRONQV7nVuWbncgIrQ6rEUA+H4pJDoZ3aglZzOJtRcQQras58rziigOxD vX3m3J4cyFB+xoVbnC/6sBm+EsfldVI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-406-Zo7ECFu_PEOLziuLzVf0bA-1; Thu, 12 Dec 2019 17:20:37 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A3993801E74 for ; Thu, 12 Dec 2019 22:20:36 +0000 (UTC) Received: from secure.mitica (ovpn-116-25.ams2.redhat.com [10.36.116.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id 28B1610013A1; Thu, 12 Dec 2019 22:20:34 +0000 (UTC) From: Juan Quintela To: qemu-devel@nongnu.org Subject: [PATCH 00/10] Migration Arguments cleanup Date: Thu, 12 Dec 2019 23:20:23 +0100 Message-Id: <20191212222033.1026-1-quintela@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: Zo7ECFu_PEOLziuLzVf0bA-1 X-Mimecast-Spam-Score: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Paolo Bonzini , Thomas Huth , "Dr. David Alan Gilbert" , Juan Quintela Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Hi This series simplify test_migrate_start() in two ways: - simplify the command line creation, so everything that is common between architectures don't have to be repeated (DRY). Note that this bit remove lines of code. - test_migrate_start() has two bools and two strings as arguments, it is very difficult to remmeber which is which and meaning. And it is even worse to add new parameters. Just pass them through one struct. Please, review. Juan Quintela (10): migration-test: Create cmd_soure and cmd_target migration-test: Move hide_stderr to common commandline migration-test: Move -machine to common commandline migration-test: Move memory size to common commandline migration-test: Move shmem handling to common commandline migration-test: Move -name handling to common commandline migration-test: Move -serial handling to common commandline migration-test: Move -incomming handling to common commandline migration-test: Rename cmd_src/dst to arch_source/arch_target migration-test: Use a struct for test_migrate_start parameters tests/migration-test.c | 265 +++++++++++++++++++++++------------------ 1 file changed, 147 insertions(+), 118 deletions(-) Tested-by: Cornelia Huck #s390x Tested-by: Laurent Vivier