From patchwork Thu Jul 18 10:48:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1133672 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45q9rG4dPsz9sBt for ; Thu, 18 Jul 2019 20:49:50 +1000 (AEST) Received: from localhost ([::1]:36272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ho3yu-000713-Mb for incoming@patchwork.ozlabs.org; Thu, 18 Jul 2019 06:49:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37895) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ho3yM-0005B5-9G for qemu-devel@nongnu.org; Thu, 18 Jul 2019 06:49:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ho3yG-0008LG-NY for qemu-devel@nongnu.org; Thu, 18 Jul 2019 06:49:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40192) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ho3y3-00085i-Pw; Thu, 18 Jul 2019 06:48:58 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B014E308FBA9; Thu, 18 Jul 2019 10:48:53 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.40.205.153]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6A0C95C21A; Thu, 18 Jul 2019 10:48:40 +0000 (UTC) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Date: Thu, 18 Jul 2019 12:48:36 +0200 Message-Id: <20190718104837.13905-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Thu, 18 Jul 2019 10:48:53 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH-for-4.1 v7 0/1] hw/block/pflash_cfi01: Add DeviceReset() handler X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , qemu-block@nongnu.org, Laszlo Ersek , =?utf-8?q?Ph?= =?utf-8?q?ilippe_Mathieu-Daud=C3=A9?= , "Dr . David Alan Gilbert" , Max Reitz , Alistair Francis , John Snow , Markus Armbruster Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The pflash device lacks a reset() function. When a machine is resetted, the flash might be in an inconsistent state, leading to unexpected behavior. Resolve this issue by adding a DeviceReset() handler. v7: Surgical bugfix, do not attempt to improve the model in any way, thus ignoring all comments from previous versions. No migration impact. Usual regression testing is welcomed, but probably pointless, except done in the way describes in the following bug reports: https://bugzilla.redhat.com/show_bug.cgi?id=1678713 https://bugzilla.redhat.com/show_bug.cgi?id=1704584 That is, resetting the machine when it is accessing the flash device. IMO testing after the guest is done accessing the flash device is totally pointless. If no objection on this series after a day, I plan to send a pull request to get this bugfix into 4.1.0-rc2. Regards, Phil. Philippe Mathieu-Daudé (1): hw/block/pflash_cfi01: Add missing DeviceReset() handler hw/block/pflash_cfi01.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)