mbox series

[PATCH-for-4.1,v4,0/3] hw/ssi/xilinx_spips: Avoid NULL pointer deference

Message ID 20190705202500.18853-1-philmd@redhat.com
Headers show
Series hw/ssi/xilinx_spips: Avoid NULL pointer deference | expand

Message

Philippe Mathieu-Daudé July 5, 2019, 8:24 p.m. UTC 
v1: https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg01238.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg01586.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg01657.html
v4
- address Francisco comments from v3
- RFC avoid out-of-bound

Philippe Mathieu-Daudé (3):
  hw/ssi/xilinx_spips: Convert lqspi_read() to read_with_attrs
  hw/ssi/xilinx_spips: Avoid AXI writes to the LQSPI linear memory
  hw/ssi/xilinx_spips: Avoid out-of-bound access to lqspi_buf[]

 hw/ssi/xilinx_spips.c | 43 +++++++++++++++++++++++++++++++------------
 1 file changed, 31 insertions(+), 12 deletions(-)

Comments

no-reply@patchew.org July 6, 2019, 11:45 a.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20190705202500.18853-1-philmd@redhat.com/



Hi,

This series failed build test on s390x host. Please find the details below.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
set -e

echo
echo "=== ENV ==="
env

echo
echo "=== PACKAGES ==="
rpm -qa

echo
echo "=== UNAME ==="
uname -a

CC=$HOME/bin/cc
INSTALL=$PWD/install
BUILD=$PWD/build
mkdir -p $BUILD $INSTALL
SRC=$PWD
cd $BUILD
$SRC/configure --cc=$CC --prefix=$INSTALL
make -j4
# XXX: we need reliable clean up
# make check -j4 V=1
make install
=== TEST SCRIPT END ===

  CC      hw/ssi/aspeed_smc.o
  CC      hw/ssi/stm32f2xx_spi.o
  CC      hw/ssi/mss-spi.o
/var/tmp/patchew-tester-tmp-ghjjv86b/src/hw/ssi/xilinx_spips.c:1246:5: error: expected ‘}’ before ‘.’ token
 1246 |     .impl = {
      |     ^
/var/tmp/patchew-tester-tmp-ghjjv86b/src/hw/ssi/xilinx_spips.c:1238:42: note: to match this ‘{’


The full log is available at
http://patchew.org/logs/20190705202500.18853-1-philmd@redhat.com/testing.s390x/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com