mbox series

[v2,0/3] qemu-img: rebase: Improve/optimize rebase operation

Message ID 20190502135828.42797-1-shmuel.eiderman@oracle.com
Headers show
Series qemu-img: rebase: Improve/optimize rebase operation | expand

Message

Sam Eiderman May 2, 2019, 1:58 p.m. UTC 
This patch series aims to improve the speed of qemu-img rebase.

1. Mainly by removing unnecessary reads when rebasing on the same
   chain.
2. But also by minimizing the number of bdrv_open calls rebase
   requires.

v2:

 - Added missing g_free in
   "qemu-img: rebase: Reuse in-chain BlockDriverState"*

Sam Eiderman (3):
  qemu-img: rebase: Reuse parent BlockDriverState
  qemu-img: rebase: Reduce reads on in-chain rebase
  qemu-img: rebase: Reuse in-chain BlockDriverState

 qemu-img.c | 85 ++++++++++++++++++++++++++++++++++++++++++--------------------
 1 file changed, 58 insertions(+), 27 deletions(-)

Comments

Eric Blake May 2, 2019, 2:21 p.m. UTC | #1 
On 5/2/19 8:58 AM, Sam Eiderman wrote:
> This patch series aims to improve the speed of qemu-img rebase.
> 
> 1. Mainly by removing unnecessary reads when rebasing on the same
>    chain.
> 2. But also by minimizing the number of bdrv_open calls rebase
>    requires.
> 

When sending a v2 series, it's best to do so as a new top-level thread
rather than in-reply-to the v1 series, as our CI tools are more likely
to spot it that way.
Sam Eiderman May 2, 2019, 2:38 p.m. UTC | #2 
I see,

Thanks

> On 2 May 2019, at 17:21, Eric Blake <eblake@redhat.com> wrote:
> 
> On 5/2/19 8:58 AM, Sam Eiderman wrote:
>> This patch series aims to improve the speed of qemu-img rebase.
>> 
>> 1. Mainly by removing unnecessary reads when rebasing on the same
>>   chain.
>> 2. But also by minimizing the number of bdrv_open calls rebase
>>   requires.
>> 
> 
> When sending a v2 series, it's best to do so as a new top-level thread
> rather than in-reply-to the v1 series, as our CI tools are more likely
> to spot it that way.
> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org
>
Sam Eiderman May 19, 2019, 8:34 a.m. UTC | #3 
Gentle ping.
Do you want me to resend this patch as a new top-level thread?

Thanks,
Sam

> On 2 May 2019, at 17:21, Eric Blake <eblake@redhat.com> wrote:
> 
> On 5/2/19 8:58 AM, Sam Eiderman wrote:
>> This patch series aims to improve the speed of qemu-img rebase.
>> 
>> 1. Mainly by removing unnecessary reads when rebasing on the same
>>   chain.
>> 2. But also by minimizing the number of bdrv_open calls rebase
>>   requires.
>> 
> 
> When sending a v2 series, it's best to do so as a new top-level thread
> rather than in-reply-to the v1 series, as our CI tools are more likely
> to spot it that way.
> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org
>