[v6,00/21] gdbstub: Refactor command packets handler

This patch series refactors the old gdbstub command packets handler
with a new infrastructure which should ease extending and adding new
and missing gdb command packets.

version 4-6 changes:
- mostly feedback from Richard Henderson

version 3 changes
- Split the single patch to many individual patches for easier reviewing

version 2 changes
- Code convention fixes

Jon Doron (21):
  gdbstub: Add infrastructure to parse cmd packets
  gdbstub: Implement deatch (D pkt) with new infra
  gdbstub: Implement thread_alive (T pkt) with new infra
  gdbstub: Implement continue (c pkt) with new infra
  gdbstub: Implement continue with signal (C pkt) with new infra
  gdbstub: Implement set_thread (H pkt) with new infra
  gdbstub: Implement insert breakpoint (Z pkt) with new infra
  gdbstub: Implement remove breakpoint (z pkt) with new infra
  gdbstub: Implement set register (P pkt) with new infra
  gdbstub: Implement get register (p pkt) with new infra
  gdbstub: Implement write memory (M pkt) with new infra
  gdbstub: Implement read memory (m pkt) with new infra
  gdbstub: Implement write all registers (G pkt) with new infra
  gdbstub: Implement read all registers (g pkt) with new infra
  gdbstub: Implement file io (F pkt) with new infra
  gdbstub: Implement step (s pkt) with new infra
  gdbstub: Implement v commands with new infra
  gdbstub: Implement generic query (q pkt) with new infra
  gdbstub: Implement generic set (Q pkt) with new infra
  gdbstub: Implement target halted (? pkt) with new infra
  gdbstub: Clear unused variables in gdb_handle_packet

 gdbstub.c | 1680 +++++++++++++++++++++++++++++++++++++----------------
 1 file changed, 1194 insertions(+), 486 deletions(-)

Patchew URL: https://patchew.org/QEMU/20190425132636.31636-1-arilou@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190425132636.31636-1-arilou@gmail.com
Subject: [Qemu-devel] [PATCH v6 00/21] gdbstub: Refactor command packets handler

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190418180057.3593-1-thuth@redhat.com -> patchew/20190418180057.3593-1-thuth@redhat.com
 * [new tag]               patchew/20190425132636.31636-1-arilou@gmail.com -> patchew/20190425132636.31636-1-arilou@gmail.com
Switched to a new branch 'test'
30dcdeb19b gdbstub: Clear unused variables in gdb_handle_packet
34bad5162d gdbstub: Implement target halted (? pkt) with new infra
ec4e176099 gdbstub: Implement generic set (Q pkt) with new infra
4be08a4f1c gdbstub: Implement generic query (q pkt) with new infra
365f1b5505 gdbstub: Implement v commands with new infra
237fdaa831 gdbstub: Implement step (s pkt) with new infra
90f52311e1 gdbstub: Implement file io (F pkt) with new infra
c4d3c8a1b8 gdbstub: Implement read all registers (g pkt) with new infra
a9ce7bbf04 gdbstub: Implement write all registers (G pkt) with new infra
6e12a9bcb1 gdbstub: Implement read memory (m pkt) with new infra
49f28342ce gdbstub: Implement write memory (M pkt) with new infra
81dbe5b1ec gdbstub: Implement get register (p pkt) with new infra
608a6efcb6 gdbstub: Implement set register (P pkt) with new infra
12413cd2df gdbstub: Implement remove breakpoint (z pkt) with new infra
c9602a6d58 gdbstub: Implement insert breakpoint (Z pkt) with new infra
288ba0c9db gdbstub: Implement set_thread (H pkt) with new infra
099528564f gdbstub: Implement continue with signal (C pkt) with new infra
0dc3aab964 gdbstub: Implement continue (c pkt) with new infra
413d890c29 gdbstub: Implement thread_alive (T pkt) with new infra
501a819267 gdbstub: Implement deatch (D pkt) with new infra
25184fb623 gdbstub: Add infrastructure to parse cmd packets

=== OUTPUT BEGIN ===
1/21 Checking commit 25184fb62305 (gdbstub: Add infrastructure to parse cmd packets)
ERROR: storage class should be at the beginning of the declaration
#170: FILE: gdbstub.c:1423:
+__attribute__((unused)) static int process_string_cmd(

total: 1 errors, 0 warnings, 206 lines checked

Patch 1/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/21 Checking commit 501a8192674a (gdbstub: Implement deatch (D pkt) with new infra)
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 120 lines checked

Patch 2/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/21 Checking commit 413d890c29b6 (gdbstub: Implement thread_alive (T pkt) with new infra)
4/21 Checking commit 0dc3aab964e0 (gdbstub: Implement continue (c pkt) with new infra)
5/21 Checking commit 099528564f7e (gdbstub: Implement continue with signal (C pkt) with new infra)
6/21 Checking commit 288ba0c9db52 (gdbstub: Implement set_thread (H pkt) with new infra)
7/21 Checking commit c9602a6d584a (gdbstub: Implement insert breakpoint (Z pkt) with new infra)
8/21 Checking commit 12413cd2df40 (gdbstub: Implement remove breakpoint (z pkt) with new infra)
9/21 Checking commit 608a6efcb64f (gdbstub: Implement set register (P pkt) with new infra)
10/21 Checking commit 81dbe5b1ece5 (gdbstub: Implement get register (p pkt) with new infra)
11/21 Checking commit 49f28342ce8d (gdbstub: Implement write memory (M pkt) with new infra)
12/21 Checking commit 6e12a9bcb1ed (gdbstub: Implement read memory (m pkt) with new infra)
13/21 Checking commit a9ce7bbf04ed (gdbstub: Implement write all registers (G pkt) with new infra)
14/21 Checking commit c4d3c8a1b8fd (gdbstub: Implement read all registers (g pkt) with new infra)
15/21 Checking commit 90f52311e145 (gdbstub: Implement file io (F pkt) with new infra)
16/21 Checking commit 237fdaa83137 (gdbstub: Implement step (s pkt) with new infra)
17/21 Checking commit 365f1b55059d (gdbstub: Implement v commands with new infra)
18/21 Checking commit 4be08a4f1c36 (gdbstub: Implement generic query (q pkt) with new infra)
19/21 Checking commit ec4e176099d6 (gdbstub: Implement generic set (Q pkt) with new infra)
20/21 Checking commit 34bad5162da9 (gdbstub: Implement target halted (? pkt) with new infra)
21/21 Checking commit 30dcdeb19b8f (gdbstub: Clear unused variables in gdb_handle_packet)
ERROR: space required before the open parenthesis '('
#29: FILE: gdbstub.c:2275:
+    switch(line_buf[0]) {

total: 1 errors, 0 warnings, 27 lines checked

Patch 21/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190425132636.31636-1-arilou@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Jon Doron <arilou@gmail.com> writes:

> This patch series refactors the old gdbstub command packets handler
> with a new infrastructure which should ease extending and adding new
> and missing gdb command packets.
>
> version 4-6 changes:
> - mostly feedback from Richard Henderson

I admire your keen but I think my comments on v3 still apply so I'll
wait until the next iteration.

--
Alex Bennée