mbox series

[0/3] hw: edu: some fixes

Message ID 20190420145120.122847-1-liq3ea@163.com
Headers show
Series hw: edu: some fixes | expand

Message

Li Qiang April 20, 2019, 2:51 p.m. UTC 
Recently I am considering write a driver for edu device.
After reading the spec, I found these three small issue.
Two first two related the MMIO access and the third is
related the DMA operation.

Li Qiang (3):
  edu: mmio: set 'max_access_size' to 8
  edu: mmio: allow mmio read dispatch accept 8 bytes
  edu: uses uint64_t in dma operation

 hw/misc/edu.c | 27 ++++++++++++++++++++-------
 1 file changed, 20 insertions(+), 7 deletions(-)

Comments

no-reply@patchew.org April 20, 2019, 3:04 p.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20190420145120.122847-1-liq3ea@163.com/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  SIGN    optionrom/multiboot.bin
  LINK    qemu-edid.exe
/tmp/qemu-test/src/hw/misc/edu.c: In function 'edu_check_range':
/tmp/qemu-test/src/hw/misc/edu.c:117:36: error: format '%lx' expects argument of type 'long unsigned int', but argument 2 has type 'uint64_t' {aka 'long long unsigned int'} [-Werror=format=]
     hw_error("EDU: DMA range 0x%.8lx-0x%.8lx out of bounds (0x%.8lx-0x%.8lx)!",
                                ~~~~^
                                %.8llx
             addr, end1 - 1, start, end2 - 1);
             ~~~~                    
/tmp/qemu-test/src/hw/misc/edu.c:117:44: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'uint64_t' {aka 'long long unsigned int'} [-Werror=format=]
     hw_error("EDU: DMA range 0x%.8lx-0x%.8lx out of bounds (0x%.8lx-0x%.8lx)!",
                                        ~~~~^
                                        %.8llx
             addr, end1 - 1, start, end2 - 1);
                   ~~~~~~~~                  
/tmp/qemu-test/src/hw/misc/edu.c:117:67: error: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'uint64_t' {aka 'long long unsigned int'} [-Werror=format=]
     hw_error("EDU: DMA range 0x%.8lx-0x%.8lx out of bounds (0x%.8lx-0x%.8lx)!",
                                                               ~~~~^
                                                               %.8llx
             addr, end1 - 1, start, end2 - 1);
                             ~~~~~                                  
/tmp/qemu-test/src/hw/misc/edu.c:117:75: error: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'uint64_t' {aka 'long long unsigned int'} [-Werror=format=]
     hw_error("EDU: DMA range 0x%.8lx-0x%.8lx out of bounds (0x%.8lx-0x%.8lx)!",
                                                                       ~~~~^
                                                                       %.8llx


The full log is available at
http://patchew.org/logs/20190420145120.122847-1-liq3ea@163.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com