From patchwork Sat Apr 13 15:20:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Reitz X-Patchwork-Id: 1085140 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44hJQ91XpPz9sB8 for ; Sun, 14 Apr 2019 01:21:32 +1000 (AEST) Received: from localhost ([127.0.0.1]:52703 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFKTA-0006fL-Ga for incoming@patchwork.ozlabs.org; Sat, 13 Apr 2019 11:21:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFKSS-0006dz-JC for qemu-devel@nongnu.org; Sat, 13 Apr 2019 11:20:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hFKSR-0000YW-NS for qemu-devel@nongnu.org; Sat, 13 Apr 2019 11:20:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46258) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hFKSP-0000UW-7U; Sat, 13 Apr 2019 11:20:41 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 774C630BDCC7; Sat, 13 Apr 2019 15:20:39 +0000 (UTC) Received: from localhost (ovpn-204-66.brq.redhat.com [10.40.204.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EAF415D707; Sat, 13 Apr 2019 15:20:38 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Date: Sat, 13 Apr 2019 17:20:35 +0200 Message-Id: <20190413152037.6817-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Sat, 13 Apr 2019 15:20:39 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH for-next 0/2] qemu-img: Make create hint at protocol options X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" https://bugzilla.redhat.com/show_bug.cgi?id=1698863 reports that while "qemu-img create -f raw" supports the "preallocation" option, it is not listed under "-o help". It turns out it is, but only if you specify a target filename. Users may not realize this, but a note should help. Max Reitz (2): iotests: Perform the correct test in 082 qemu-img: Make create hint at protocol options qemu-img.c | 13 ++++++++++++- tests/qemu-iotests/082 | 5 ++++- tests/qemu-iotests/082.out | 25 ++++++++++++++++++------- 3 files changed, 34 insertions(+), 9 deletions(-) Reviewed-by: John Snow