mbox series

[for-next,0/2] qemu-img: Make create hint at protocol options

Message ID 20190413152037.6817-1-mreitz@redhat.com
Headers show
Series qemu-img: Make create hint at protocol options | expand

Message

Max Reitz April 13, 2019, 3:20 p.m. UTC 
https://bugzilla.redhat.com/show_bug.cgi?id=1698863 reports that while
"qemu-img create -f raw" supports the "preallocation" option, it is not
listed under "-o help".

It turns out it is, but only if you specify a target filename.  Users
may not realize this, but a note should help.


Max Reitz (2):
  iotests: Perform the correct test in 082
  qemu-img: Make create hint at protocol options

 qemu-img.c                 | 13 ++++++++++++-
 tests/qemu-iotests/082     |  5 ++++-
 tests/qemu-iotests/082.out | 25 ++++++++++++++++++-------
 3 files changed, 34 insertions(+), 9 deletions(-)

Comments

John Snow April 26, 2019, 10:57 p.m. UTC | #1 
On 4/13/19 11:20 AM, Max Reitz wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1698863 reports that while
> "qemu-img create -f raw" supports the "preallocation" option, it is not
> listed under "-o help".
> 
> It turns out it is, but only if you specify a target filename.  Users
> may not realize this, but a note should help.
> 
> 
> Max Reitz (2):
>   iotests: Perform the correct test in 082
>   qemu-img: Make create hint at protocol options
> 
>  qemu-img.c                 | 13 ++++++++++++-
>  tests/qemu-iotests/082     |  5 ++++-
>  tests/qemu-iotests/082.out | 25 ++++++++++++++++++-------
>  3 files changed, 34 insertions(+), 9 deletions(-)
> 

Seems like an improvement to me.

Reviewed-by: John Snow <jsnow@redhat.com>
Kevin Wolf April 29, 2019, 9:20 a.m. UTC | #2 
Am 13.04.2019 um 17:20 hat Max Reitz geschrieben:
> https://bugzilla.redhat.com/show_bug.cgi?id=1698863 reports that while
> "qemu-img create -f raw" supports the "preallocation" option, it is not
> listed under "-o help".
> 
> It turns out it is, but only if you specify a target filename.  Users
> may not realize this, but a note should help.

Thanks, applied to the block branch.

Kevin