| Message ID | 20190409134536.15548-1-philmd@redhat.com |
|---|---|
| Headers | show |
| Series | roms: Avoid iPXE/EDK2 EFIROM variable clash, pass CFLAGS to EDK2 build tools | expand |
On Tue, 9 Apr 2019 at 14:47, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > Hi, > > Two trivial fixes to avoid the latest EDK2 testing series to > cause trouble to downstream distributions (in particular if > they have PIE enforced). > > Since v2: > - addressed Laszlo's suggestion > - reworded patch description > > v2: https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg01033.html > v1: https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg01006.html > error report: https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg00992.html > > Regards, > > Phil. > > Philippe Mathieu-Daudé (2): > roms: Rename the EFIROM variable to avoid clashing with iPXE > roms: Allow passing configure options to the EDK2 build tools > > roms/Makefile | 23 ++++++++++++++++++----- > 1 file changed, 18 insertions(+), 5 deletions(-) Thanks. This is one of a handful of remaining bugs we should fix for 4.0, so I would ideally like to get this in rc3 today (or tomorrow if we have to slip rc3 a day). If people wanting to review this series could do so promptly I'd definitely appreciate it. -- PMM
On Tue, Apr 09, 2019 at 03:45:34PM +0200, Philippe Mathieu-Daudé wrote: > Hi, > > Two trivial fixes to avoid the latest EDK2 testing series to > cause trouble to downstream distributions (in particular if > they have PIE enforced). > > Since v2: > - addressed Laszlo's suggestion > - reworded patch description > > v2: https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg01033.html > v1: https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg01006.html > error report: https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg00992.html > > Regards, > > Phil. Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Peter do you want to merge this directly? > Philippe Mathieu-Daudé (2): > roms: Rename the EFIROM variable to avoid clashing with iPXE > roms: Allow passing configure options to the EDK2 build tools > > roms/Makefile | 23 ++++++++++++++++++----- > 1 file changed, 18 insertions(+), 5 deletions(-) > > -- > 2.20.1
On Tue, 9 Apr 2019 at 16:06, Michael S. Tsirkin <mst@redhat.com> wrote: > > On Tue, Apr 09, 2019 at 03:45:34PM +0200, Philippe Mathieu-Daudé wrote: > > Hi, > > > > Two trivial fixes to avoid the latest EDK2 testing series to > > cause trouble to downstream distributions (in particular if > > they have PIE enforced). > > > > Since v2: > > - addressed Laszlo's suggestion > > - reworded patch description > > > > v2: https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg01033.html > > v1: https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg01006.html > > error report: https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg00992.html > > > > Regards, > > > > Phil. > > Reviewed-by: Michael S. Tsirkin <mst@redhat.com> > > > Peter do you want to merge this directly? Yes, I'll do that. thanks -- PMM
On 04/09/19 16:00, Peter Maydell wrote: > On Tue, 9 Apr 2019 at 14:47, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: >> >> Hi, >> >> Two trivial fixes to avoid the latest EDK2 testing series to >> cause trouble to downstream distributions (in particular if >> they have PIE enforced). >> >> Since v2: >> - addressed Laszlo's suggestion >> - reworded patch description >> >> v2: https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg01033.html >> v1: https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg01006.html >> error report: https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg00992.html >> >> Regards, >> >> Phil. >> >> Philippe Mathieu-Daudé (2): >> roms: Rename the EFIROM variable to avoid clashing with iPXE >> roms: Allow passing configure options to the EDK2 build tools >> >> roms/Makefile | 23 ++++++++++++++++++----- >> 1 file changed, 18 insertions(+), 5 deletions(-) > > Thanks. This is one of a handful of remaining bugs we > should fix for 4.0, so I would ideally like to get this > in rc3 today (or tomorrow if we have to slip rc3 a day). > If people wanting to review this series could do so > promptly I'd definitely appreciate it. > > -- PMM > I hope I was quick enough. Thanks, Laszlo
On Tue, 9 Apr 2019 at 16:25, Laszlo Ersek <lersek@redhat.com> wrote: > > On 04/09/19 16:00, Peter Maydell wrote: > > Thanks. This is one of a handful of remaining bugs we > > should fix for 4.0, so I would ideally like to get this > > in rc3 today (or tomorrow if we have to slip rc3 a day). > > If people wanting to review this series could do so > > promptly I'd definitely appreciate it. > > I hope I was quick enough. Yep, thanks. (I knew you'd had comments on v1 so I was assuming you'd want to review v2.) thanks -- PMM