| Message ID | 20190320141610.46305-1-ysato@users.sourceforge.jp |
|---|---|
| Headers | show |
| Series | Add RX archtecture support | expand |
Patchew URL: https://patchew.org/QEMU/20190320141610.46305-1-ysato@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190320141610.46305-1-ysato@users.sourceforge.jp
Subject: [Qemu-devel] [PATCH RFC v4 00/12] Add RX archtecture support
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20190320141610.46305-1-ysato@users.sourceforge.jp -> patchew/20190320141610.46305-1-ysato@users.sourceforge.jp
Switched to a new branch 'test'
7e85f3383c include/hw/regiserfields.h: Add 8bit and 16bit registers
d16288a571 MAINTAINERS: Add RX
345e45e1b9 Add rx-softmmu
4d124ff66a hw/rx: RX Target hardware definition
61c5ae7435 hw/char: RX62N serical communication interface (SCI)
009bd682f3 hw/timer: RX62N internal timer modules
fafd0fcc49 hw/intc: RX62N interrupt controller (ICUa)
c97c8f219e target/rx: Miscellaneous files
e1f1a5afaa target/rx: RX disassembler
6b85dcacac target/rx: CPU definition
32bb263877 target/rx: TCG helper
d3191be6e0 target/rx: TCG translation
=== OUTPUT BEGIN ===
1/12 Checking commit d3191be6e08b (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15:
new file mode 100644
total: 0 errors, 1 warnings, 2933 lines checked
Patch 1/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/12 Checking commit 32bb263877cc (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11:
new file mode 100644
total: 0 errors, 1 warnings, 739 lines checked
Patch 2/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/12 Checking commit 6b85dcacac78 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11:
new file mode 100644
total: 0 errors, 1 warnings, 478 lines checked
Patch 3/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/12 Checking commit e1f1a5afaab8 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34:
new file mode 100644
total: 0 errors, 1 warnings, 1529 lines checked
Patch 4/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/12 Checking commit c97c8f219e26 (target/rx: Miscellaneous files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11:
new file mode 100644
total: 0 errors, 1 warnings, 161 lines checked
Patch 5/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/12 Checking commit fafd0fcc499e (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#24:
new file mode 100644
total: 0 errors, 1 warnings, 426 lines checked
Patch 6/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/12 Checking commit 009bd682f3c3 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45:
new file mode 100644
total: 0 errors, 1 warnings, 799 lines checked
Patch 7/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/12 Checking commit 61c5ae7435c6 (hw/char: RX62N serical communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39:
new file mode 100644
total: 0 errors, 1 warnings, 394 lines checked
Patch 8/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/12 Checking commit 4d124ff66a43 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14:
new file mode 100644
total: 0 errors, 1 warnings, 390 lines checked
Patch 9/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/12 Checking commit 345e45e1b934 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
total: 0 errors, 1 warnings, 49 lines checked
Patch 10/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/12 Checking commit d16288a571fb (MAINTAINERS: Add RX)
12/12 Checking commit 7e85f3383cfa (include/hw/regiserfields.h: Add 8bit and 16bit registers)
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#21: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#25: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 22 lines checked
Patch 12/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190320141610.46305-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Hello. This patch series is added Renesas RX target emulation. Update review comments and fix some issue. My git repository is bellow. git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git Testing binaries bellow. u-boot Download - https://osdn.net/users/ysato/pf/qemu/dl/u-boot.bin.gz starting $ gzip -d u-boot.bin.gz $ qemu-system-rx -bios u-boot.bin linux and pico-root (only sash) Download - https://osdn.net/users/ysato/pf/qemu/dl/zImage (kernel) https://osdn.net/users/ysato/pf/qemu/dl/rx-qemu.dtb (DeviceTree) starting $ qemu-system-rx -kernel zImage -dtb rx-qemu.dtb -append "earlycon" Changes v3 Using Register API. Using bitops function. Fix interrupt handling. Improve insns.decode and translate.c cleanup implementation. cleanup psw status operation. Yoshinori Sato (12): target/rx: TCG translation target/rx: TCG helper target/rx: CPU definition target/rx: RX disassembler target/rx: Miscellaneous files hw/intc: RX62N interrupt controller (ICUa) hw/timer: RX62N internal timer modules hw/char: RX62N serical communication interface (SCI) hw/rx: RX Target hardware definition Add rx-softmmu MAINTAINERS: Add RX include/hw/regiserfields.h: Add 8bit and 16bit registers configure | 8 + default-configs/rx-softmmu.mak | 7 + include/disas/bfd.h | 5 + include/hw/char/renesas_sci.h | 45 + include/hw/intc/rx_icu.h | 49 + include/hw/registerfields.h | 11 +- include/hw/rx/rx.h | 7 + include/hw/rx/rx62n.h | 54 + include/hw/timer/renesas_cmt.h | 33 + include/hw/timer/renesas_tmr.h | 46 + include/sysemu/arch_init.h | 1 + target/rx/cpu-qom.h | 52 + target/rx/cpu.h | 201 ++++ target/rx/helper.h | 35 + arch_init.c | 2 + hw/char/renesas_sci.c | 335 ++++++ hw/intc/rx_icu.c | 373 +++++++ hw/rx/rx62n.c | 226 ++++ hw/rx/rxqemu.c | 100 ++ hw/timer/renesas_cmt.c | 264 +++++ hw/timer/renesas_tmr.c | 438 ++++++++ target/rx/cpu.c | 225 ++++ target/rx/disas.c | 1512 ++++++++++++++++++++++++++ target/rx/gdbstub.c | 112 ++ target/rx/helper.c | 147 +++ target/rx/monitor.c | 38 + target/rx/op_helper.c | 557 ++++++++++ target/rx/translate.c | 2305 ++++++++++++++++++++++++++++++++++++++++ MAINTAINERS | 19 + hw/Kconfig | 1 + hw/char/Kconfig | 3 + hw/char/Makefile.objs | 2 +- hw/intc/Makefile.objs | 1 + hw/rx/Kconfig | 2 + hw/rx/Makefile.objs | 1 + hw/timer/Kconfig | 6 + hw/timer/Makefile.objs | 3 + target/rx/Makefile.objs | 11 + target/rx/insns.decode | 628 +++++++++++ 39 files changed, 7863 insertions(+), 2 deletions(-) create mode 100644 default-configs/rx-softmmu.mak create mode 100644 include/hw/char/renesas_sci.h create mode 100644 include/hw/intc/rx_icu.h create mode 100644 include/hw/rx/rx.h create mode 100644 include/hw/rx/rx62n.h create mode 100644 include/hw/timer/renesas_cmt.h create mode 100644 include/hw/timer/renesas_tmr.h create mode 100644 target/rx/cpu-qom.h create mode 100644 target/rx/cpu.h create mode 100644 target/rx/helper.h create mode 100644 hw/char/renesas_sci.c create mode 100644 hw/intc/rx_icu.c create mode 100644 hw/rx/rx62n.c create mode 100644 hw/rx/rxqemu.c create mode 100644 hw/timer/renesas_cmt.c create mode 100644 hw/timer/renesas_tmr.c create mode 100644 target/rx/cpu.c create mode 100644 target/rx/disas.c create mode 100644 target/rx/gdbstub.c create mode 100644 target/rx/helper.c create mode 100644 target/rx/monitor.c create mode 100644 target/rx/op_helper.c create mode 100644 target/rx/translate.c create mode 100644 hw/rx/Kconfig create mode 100644 hw/rx/Makefile.objs create mode 100644 target/rx/Makefile.objs create mode 100644 target/rx/insns.decode