| Message ID | 20190222081153.14206-1-david@redhat.com |
|---|---|
| Headers | show |
| Series | s390x: SIGP + IRQ preparations for TCG vector register support | expand |
On Fri, 22 Feb 2019 09:11:50 +0100 David Hildenbrand <david@redhat.com> wrote: > These are minor preparations for vector instruction support for TCG, also > touching KVM code. > > During SIGP STORE ADDITIONAL STATUS we have to properly convert the > endianess. On machine checks, we have to also store the vector registers > into the extended save area. > > Both changes are not used by TCG code before we implement + enable > vector instructions. KVM code shares the SIGP STORE ADDITIONAL STATUS > implementation. > > Note: Vector registers (128 bit) are modeled as two 64 bit values. Low and > high 64 bit values correspond on big/little systems, however the values > themself need conversion. Documentation for that will be added along with > the actual vector instruction support. > > David Hildenbrand (3): > s390x: Use cpu_to_be64 in SIGP STORE ADDITIONAL STATUS > s390x: use a QEMU-style typedef + name for SIGP save area struct > s390x/tcg: Save vregs to extended mchk save area > > target/s390x/excp_helper.c | 46 ++++++++++++++++++++++++++++++++++++-- > target/s390x/helper.c | 39 ++++++++++++++++++++------------ > target/s390x/internal.h | 4 +++- > 3 files changed, 72 insertions(+), 17 deletions(-) > Quick question: Unlike your floating-point patch series, this does not depend on anything not going through the s390x tree, right?
On 22.02.19 11:16, Cornelia Huck wrote: > On Fri, 22 Feb 2019 09:11:50 +0100 > David Hildenbrand <david@redhat.com> wrote: > >> These are minor preparations for vector instruction support for TCG, also >> touching KVM code. >> >> During SIGP STORE ADDITIONAL STATUS we have to properly convert the >> endianess. On machine checks, we have to also store the vector registers >> into the extended save area. >> >> Both changes are not used by TCG code before we implement + enable >> vector instructions. KVM code shares the SIGP STORE ADDITIONAL STATUS >> implementation. >> >> Note: Vector registers (128 bit) are modeled as two 64 bit values. Low and >> high 64 bit values correspond on big/little systems, however the values >> themself need conversion. Documentation for that will be added along with >> the actual vector instruction support. >> >> David Hildenbrand (3): >> s390x: Use cpu_to_be64 in SIGP STORE ADDITIONAL STATUS >> s390x: use a QEMU-style typedef + name for SIGP save area struct >> s390x/tcg: Save vregs to extended mchk save area >> >> target/s390x/excp_helper.c | 46 ++++++++++++++++++++++++++++++++++++-- >> target/s390x/helper.c | 39 ++++++++++++++++++++------------ >> target/s390x/internal.h | 4 +++- >> 3 files changed, 72 insertions(+), 17 deletions(-) >> > > Quick question: Unlike your floating-point patch series, this does not > depend on anything not going through the s390x tree, right? > While these patches are based on the others, they should apply and work just nicely without the floating-point patches.
On Fri, 22 Feb 2019 09:11:50 +0100 David Hildenbrand <david@redhat.com> wrote: > These are minor preparations for vector instruction support for TCG, also > touching KVM code. > > During SIGP STORE ADDITIONAL STATUS we have to properly convert the > endianess. On machine checks, we have to also store the vector registers > into the extended save area. > > Both changes are not used by TCG code before we implement + enable > vector instructions. KVM code shares the SIGP STORE ADDITIONAL STATUS > implementation. > > Note: Vector registers (128 bit) are modeled as two 64 bit values. Low and > high 64 bit values correspond on big/little systems, however the values > themself need conversion. Documentation for that will be added along with > the actual vector instruction support. > > David Hildenbrand (3): > s390x: Use cpu_to_be64 in SIGP STORE ADDITIONAL STATUS > s390x: use a QEMU-style typedef + name for SIGP save area struct > s390x/tcg: Save vregs to extended mchk save area > > target/s390x/excp_helper.c | 46 ++++++++++++++++++++++++++++++++++++-- > target/s390x/helper.c | 39 ++++++++++++++++++++------------ > target/s390x/internal.h | 4 +++- > 3 files changed, 72 insertions(+), 17 deletions(-) > Thanks, applied.