mbox series

[v2,0/2] Fix SEV VM device assignment

Message ID 20190204222322.26766-1-brijesh.singh@amd.com
Headers show
Series Fix SEV VM device assignment | expand

Message

Brijesh Singh Feb. 4, 2019, 10:23 p.m. UTC 
Fix: https://bugzilla.redhat.com/show_bug.cgi?id=1667249

Since v1:
 * check the error code from memory_region_from_host() before
   accessing the mr.

Brijesh Singh (2):
  memory: Fix the memory region type assignment order
  target/i386: sev: Do not pin the ram device memory region

 memory.c          |  9 ++++++++-
 target/i386/sev.c | 11 +++++++++++
 2 files changed, 19 insertions(+), 1 deletion(-)

Comments

Brijesh Singh March 1, 2019, 3:09 p.m. UTC | #1 
Hi Paolo,

Any comment on this series. Currently, device pass-through is
broken for the SEV guests. I am wondering if we can queue the
patches.

thanks
Brijesh

On 2/4/19 4:23 PM, Singh, Brijesh wrote:
> Fix: https://bugzilla.redhat.com/show_bug.cgi?id=1667249
> 
> Since v1:
>   * check the error code from memory_region_from_host() before
>     accessing the mr.
> 
> Brijesh Singh (2):
>    memory: Fix the memory region type assignment order
>    target/i386: sev: Do not pin the ram device memory region
> 
>   memory.c          |  9 ++++++++-
>   target/i386/sev.c | 11 +++++++++++
>   2 files changed, 19 insertions(+), 1 deletion(-)
>
Alex Williamson March 12, 2019, 2:56 p.m. UTC | #2 
[cc +Paolo]

On Fri, 1 Mar 2019 15:09:04 +0000
"Singh, Brijesh" <brijesh.singh@amd.com> wrote:

> Hi Paolo,
> 
> Any comment on this series. Currently, device pass-through is
> broken for the SEV guests. I am wondering if we can queue the
> patches.

Paolo, any chance you're considering this for 4.0?  Thanks,

Alex

> On 2/4/19 4:23 PM, Singh, Brijesh wrote:
> > Fix: https://bugzilla.redhat.com/show_bug.cgi?id=1667249
> > 
> > Since v1:
> >   * check the error code from memory_region_from_host() before
> >     accessing the mr.
> > 
> > Brijesh Singh (2):
> >    memory: Fix the memory region type assignment order
> >    target/i386: sev: Do not pin the ram device memory region
> > 
> >   memory.c          |  9 ++++++++-
> >   target/i386/sev.c | 11 +++++++++++
> >   2 files changed, 19 insertions(+), 1 deletion(-)
> >
Paolo Bonzini March 12, 2019, 2:58 p.m. UTC | #3 
On 12/03/19 15:56, Alex Williamson wrote:
> [cc +Paolo]
> 
> On Fri, 1 Mar 2019 15:09:04 +0000
> "Singh, Brijesh" <brijesh.singh@amd.com> wrote:
> 
>> Hi Paolo,
>>
>> Any comment on this series. Currently, device pass-through is
>> broken for the SEV guests. I am wondering if we can queue the
>> patches.
> 
> Paolo, any chance you're considering this for 4.0?  Thanks,

I totally missed it; it is a bugfix so it can be included after soft
freeze.  However, if you are planning to send out another pull request,
feel free to include them yourself.

Paolo
Alex Williamson March 12, 2019, 3:10 p.m. UTC | #4 
On Tue, 12 Mar 2019 15:58:30 +0100
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 12/03/19 15:56, Alex Williamson wrote:
> > [cc +Paolo]
> > 
> > On Fri, 1 Mar 2019 15:09:04 +0000
> > "Singh, Brijesh" <brijesh.singh@amd.com> wrote:
> >   
> >> Hi Paolo,
> >>
> >> Any comment on this series. Currently, device pass-through is
> >> broken for the SEV guests. I am wondering if we can queue the
> >> patches.  
> > 
> > Paolo, any chance you're considering this for 4.0?  Thanks,  
> 
> I totally missed it; it is a bugfix so it can be included after soft
> freeze.

I agree.

>  However, if you are planning to send out another pull request,
> feel free to include them yourself.

Unless something goes wrong with my in-flight pull request, I expect
you'll do another before me.  I'll keep an eye on it and coordinate
with you if that proves otherwise.  Thanks,

Alex