mbox series

[v5,0/6] NBD reconnect: prep. refactoring

Message ID 20190201130138.94525-1-vsementsov@virtuozzo.com
Headers show
Series NBD reconnect: prep. refactoring | expand

Message

Vladimir Sementsov-Ogievskiy Feb. 1, 2019, 1:01 p.m. UTC 
Hi all.

Here is most of preparatory refactoring for NBD reconnect, rebased
on master. Let's push it.

Sorry for a long delay in answering on v4 review and for v4 which
I pinged a lot can't be applied on master directly :(

v5:
02: rebased on master, object_unref() moved to fail: block
05: tiny fixes in commit message [Eric]

Vladimir Sementsov-Ogievskiy (6):
  block/nbd-client: split channel errors from export errors
  block/nbd: move connection code from block/nbd to block/nbd-client
  block/nbd-client: split connection from initialization
  block/nbd-client: fix nbd_reply_chunk_iter_receive
  block/nbd-client: don't check ioc
  block/nbd-client: rename read_reply_co to connection_co

 block/nbd-client.h |   6 +-
 block/nbd-client.c | 196 +++++++++++++++++++++++++++++----------------
 block/nbd.c        |  40 +--------
 3 files changed, 131 insertions(+), 111 deletions(-)

Comments

Eric Blake Feb. 1, 2019, 9:27 p.m. UTC | #1 
On 2/1/19 7:01 AM, Vladimir Sementsov-Ogievskiy wrote:
> Hi all.
> 
> Here is most of preparatory refactoring for NBD reconnect, rebased
> on master. Let's push it.

Thanks; queued for my next NBD pull request.

> 
> Sorry for a long delay in answering on v4 review and for v4 which
> I pinged a lot can't be applied on master directly :(
> 
> v5:
> 02: rebased on master, object_unref() moved to fail: block
> 05: tiny fixes in commit message [Eric]
> 
> Vladimir Sementsov-Ogievskiy (6):
>   block/nbd-client: split channel errors from export errors
>   block/nbd: move connection code from block/nbd to block/nbd-client
>   block/nbd-client: split connection from initialization
>   block/nbd-client: fix nbd_reply_chunk_iter_receive
>   block/nbd-client: don't check ioc
>   block/nbd-client: rename read_reply_co to connection_co
> 
>  block/nbd-client.h |   6 +-
>  block/nbd-client.c | 196 +++++++++++++++++++++++++++++----------------
>  block/nbd.c        |  40 +--------
>  3 files changed, 131 insertions(+), 111 deletions(-)
>