| Message ID | 20190129000820.31190-1-richardw.yang@linux.intel.com |
|---|---|
| Headers | show |
| Series | Trivial cleanup in hw/acpi | expand |
Hi Wei, On 1/29/19 1:08 AM, Wei Yang wrote: > There are several functions/variable which are not used anymore. > > This serials just remove those without functional change. > > Wei Yang (3): > hw/i386/pc.c: remove unused function pc_acpi_init() > hw/acpi: remove unused function acpi_table_add_builtin() > hw/acpi: remove unnecessary variable acpi_table_builtin > > hw/acpi/core.c | 10 +--------- > hw/i386/pc.c | 27 --------------------------- > include/hw/acpi/acpi.h | 1 - > include/hw/i386/pc.h | 1 - > 4 files changed, 1 insertion(+), 38 deletions(-) > Please do not post iterated series in reply to previous version, but as new thread: - patches are parsed by scripts - some email clients can tag a thread as "reviewed, skip" and replies to this thread will be masked. Regards, Phil.
On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote: >Hi Wei, > >On 1/29/19 1:08 AM, Wei Yang wrote: >> There are several functions/variable which are not used anymore. >> >> This serials just remove those without functional change. >> >> Wei Yang (3): >> hw/i386/pc.c: remove unused function pc_acpi_init() >> hw/acpi: remove unused function acpi_table_add_builtin() >> hw/acpi: remove unnecessary variable acpi_table_builtin >> >> hw/acpi/core.c | 10 +--------- >> hw/i386/pc.c | 27 --------------------------- >> include/hw/acpi/acpi.h | 1 - >> include/hw/i386/pc.h | 1 - >> 4 files changed, 1 insertion(+), 38 deletions(-) >> > >Please do not post iterated series in reply to previous version, but as >new thread: >- patches are parsed by scripts >- some email clients can tag a thread as "reviewed, skip" and replies to >this thread will be masked. > Well, do I need to repost it in a new thread? >Regards, > >Phil.
On 1/29/19 9:04 AM, Wei Yang wrote: > On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote: >> Hi Wei, >> >> On 1/29/19 1:08 AM, Wei Yang wrote: >>> There are several functions/variable which are not used anymore. >>> >>> This serials just remove those without functional change. >>> >>> Wei Yang (3): >>> hw/i386/pc.c: remove unused function pc_acpi_init() >>> hw/acpi: remove unused function acpi_table_add_builtin() >>> hw/acpi: remove unnecessary variable acpi_table_builtin >>> >>> hw/acpi/core.c | 10 +--------- >>> hw/i386/pc.c | 27 --------------------------- >>> include/hw/acpi/acpi.h | 1 - >>> include/hw/i386/pc.h | 1 - >>> 4 files changed, 1 insertion(+), 38 deletions(-) >>> >> >> Please do not post iterated series in reply to previous version, but as >> new thread: >> - patches are parsed by scripts >> - some email clients can tag a thread as "reviewed, skip" and replies to >> this thread will be masked. >> > > Well, do I need to repost it in a new thread? It depends who will take this patchset and his mood :) Let's wait and see.
On 29/01/2019 09:23, Philippe Mathieu-Daudé wrote: > On 1/29/19 9:04 AM, Wei Yang wrote: >> On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote: >>> Hi Wei, >>> >>> On 1/29/19 1:08 AM, Wei Yang wrote: >>>> There are several functions/variable which are not used anymore. >>>> >>>> This serials just remove those without functional change. >>>> >>>> Wei Yang (3): >>>> hw/i386/pc.c: remove unused function pc_acpi_init() >>>> hw/acpi: remove unused function acpi_table_add_builtin() >>>> hw/acpi: remove unnecessary variable acpi_table_builtin >>>> >>>> hw/acpi/core.c | 10 +--------- >>>> hw/i386/pc.c | 27 --------------------------- >>>> include/hw/acpi/acpi.h | 1 - >>>> include/hw/i386/pc.h | 1 - >>>> 4 files changed, 1 insertion(+), 38 deletions(-) >>>> >>> >>> Please do not post iterated series in reply to previous version, but as >>> new thread: >>> - patches are parsed by scripts >>> - some email clients can tag a thread as "reviewed, skip" and replies to >>> this thread will be masked. >>> >> >> Well, do I need to repost it in a new thread? > > It depends who will take this patchset and his mood :) > Let's wait and see. > No need to repost if they go through the trivial branch. Thanks, Laurent
On Tue, Jan 29, 2019 at 09:43:20AM +0100, Laurent Vivier wrote: >On 29/01/2019 09:23, Philippe Mathieu-Daudé wrote: >> On 1/29/19 9:04 AM, Wei Yang wrote: >>> On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote: >>>> Hi Wei, >>>> >>>> On 1/29/19 1:08 AM, Wei Yang wrote: >>>>> There are several functions/variable which are not used anymore. >>>>> >>>>> This serials just remove those without functional change. >>>>> >>>>> Wei Yang (3): >>>>> hw/i386/pc.c: remove unused function pc_acpi_init() >>>>> hw/acpi: remove unused function acpi_table_add_builtin() >>>>> hw/acpi: remove unnecessary variable acpi_table_builtin >>>>> >>>>> hw/acpi/core.c | 10 +--------- >>>>> hw/i386/pc.c | 27 --------------------------- >>>>> include/hw/acpi/acpi.h | 1 - >>>>> include/hw/i386/pc.h | 1 - >>>>> 4 files changed, 1 insertion(+), 38 deletions(-) >>>>> >>>> >>>> Please do not post iterated series in reply to previous version, but as >>>> new thread: >>>> - patches are parsed by scripts >>>> - some email clients can tag a thread as "reviewed, skip" and replies to >>>> this thread will be masked. >>>> >>> >>> Well, do I need to repost it in a new thread? >> >> It depends who will take this patchset and his mood :) >> Let's wait and see. >> > >No need to repost if they go through the trivial branch. Thanks :-) > >Thanks, >Laurent
On Tue, Jan 29, 2019 at 03:32:54PM +0000, Wei Yang wrote: > On Tue, Jan 29, 2019 at 09:43:20AM +0100, Laurent Vivier wrote: > >On 29/01/2019 09:23, Philippe Mathieu-Daudé wrote: > >> On 1/29/19 9:04 AM, Wei Yang wrote: > >>> On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote: > >>>> Hi Wei, > >>>> > >>>> On 1/29/19 1:08 AM, Wei Yang wrote: > >>>>> There are several functions/variable which are not used anymore. > >>>>> > >>>>> This serials just remove those without functional change. > >>>>> > >>>>> Wei Yang (3): > >>>>> hw/i386/pc.c: remove unused function pc_acpi_init() > >>>>> hw/acpi: remove unused function acpi_table_add_builtin() > >>>>> hw/acpi: remove unnecessary variable acpi_table_builtin > >>>>> > >>>>> hw/acpi/core.c | 10 +--------- > >>>>> hw/i386/pc.c | 27 --------------------------- > >>>>> include/hw/acpi/acpi.h | 1 - > >>>>> include/hw/i386/pc.h | 1 - > >>>>> 4 files changed, 1 insertion(+), 38 deletions(-) > >>>>> > >>>> > >>>> Please do not post iterated series in reply to previous version, but as > >>>> new thread: > >>>> - patches are parsed by scripts > >>>> - some email clients can tag a thread as "reviewed, skip" and replies to > >>>> this thread will be masked. > >>>> > >>> > >>> Well, do I need to repost it in a new thread? > >> > >> It depends who will take this patchset and his mood :) > >> Let's wait and see. > >> > > > >No need to repost if they go through the trivial branch. > > Thanks :-) > > > > >Thanks, > >Laurent Pls repost with all acks etc and I'll pick it up. > -- > Wei Yang > Help you, Help me
On Tue, Jan 29, 2019 at 10:58:50AM -0500, Michael S. Tsirkin wrote: >On Tue, Jan 29, 2019 at 03:32:54PM +0000, Wei Yang wrote: >> On Tue, Jan 29, 2019 at 09:43:20AM +0100, Laurent Vivier wrote: >> >On 29/01/2019 09:23, Philippe Mathieu-Daudé wrote: >> >> On 1/29/19 9:04 AM, Wei Yang wrote: >> >>> On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote: >> >>>> Hi Wei, >> >>>> >> >>>> On 1/29/19 1:08 AM, Wei Yang wrote: >> >>>>> There are several functions/variable which are not used anymore. >> >>>>> >> >>>>> This serials just remove those without functional change. >> >>>>> >> >>>>> Wei Yang (3): >> >>>>> hw/i386/pc.c: remove unused function pc_acpi_init() >> >>>>> hw/acpi: remove unused function acpi_table_add_builtin() >> >>>>> hw/acpi: remove unnecessary variable acpi_table_builtin >> >>>>> >> >>>>> hw/acpi/core.c | 10 +--------- >> >>>>> hw/i386/pc.c | 27 --------------------------- >> >>>>> include/hw/acpi/acpi.h | 1 - >> >>>>> include/hw/i386/pc.h | 1 - >> >>>>> 4 files changed, 1 insertion(+), 38 deletions(-) >> >>>>> >> >>>> >> >>>> Please do not post iterated series in reply to previous version, but as >> >>>> new thread: >> >>>> - patches are parsed by scripts >> >>>> - some email clients can tag a thread as "reviewed, skip" and replies to >> >>>> this thread will be masked. >> >>>> >> >>> >> >>> Well, do I need to repost it in a new thread? >> >> >> >> It depends who will take this patchset and his mood :) >> >> Let's wait and see. >> >> >> > >> >No need to repost if they go through the trivial branch. >> >> Thanks :-) >> >> > >> >Thanks, >> >Laurent > >Pls repost with all acks etc and I'll pick it up. > Got it. >> -- >> Wei Yang >> Help you, Help me