Message ID | 20181205232251.10446-1-clg@kaod.org |
---|---|
Headers | show |
Series | ppc: support for the XIVE interrupt controller (POWER9) | expand |
Patchew URL: https://patchew.org/QEMU/20181205232251.10446-1-clg@kaod.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181205232251.10446-1-clg@kaod.org Subject: [Qemu-devel] [PATCH v6 00/37] ppc: support for the XIVE interrupt controller (POWER9) Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' b29ce00 spapr: add KVM support to the 'dual' machine 957ca7b spapr: check for KVM IRQ device activation 20c8779 spapr: introduce routines to delete the KVM IRQ device 6577bbe sysbus: add a sysbus_mmio_unmap() helper 9ae96ee spapr/rtas: modify spapr_rtas_register() to remove RTAS handlers 643bf4b ppc/xics: introduce a icp_kvm_connect() routine f727182 spapr: add a 'pseries-3.1-dual' machine type d69c736 spapr/xive: enable XIVE MMIOs at reset 114495a spapr: set the interrupt presenter at reset d28fbd6 spapr/xive: fix migration of the XiveTCTX under TCG af33d19 spapr/xive: add migration support for KVM ca0d71d spapr/xive: introduce a VM state change handler 6b44f52 spapr/xive: add state synchronization with KVM 543c65b spapr/xive: add KVM support 11b9fc0 linux-headers: update to 4.20-rc5 de7e220 spapr: add a 'pseries-3.1-xive' machine type 9a3ad0b spapr: add a 'reset' method to the sPAPR IRQ backend e414def spapr: extend the sPAPR IRQ backend for XICS migration 7ee593a spapr: allocate the interrupt thread context under the CPU core 5830c26 spapr: add device tree support for the XIVE exploitation mode 7c6ed94 spapr: add hcalls support for the XIVE exploitation interrupt mode 8b0265d spapr: introdude a new machine IRQ backend for XIVE 7438740 spapr: export and rename the xics_max_server_number() routine 6c85b1a spapr: modify the irq backend 'init' method cbdc5f2 spapr: introduce a spapr_irq_init() routine 7b96ab4 spapr: initialize VSMT before initializing the IRQ backend 99ed715 spapr/xive: use the VCPU id as a NVT identifier 12a7762 spapr/xive: introduce a XIVE interrupt controller 043a1e5 ppc/xive: notify the CPU when the interrupt priority is more privileged 4e2626f ppc/xive: introduce a simplified XIVE presenter 58d0fa5 ppc/xive: introduce the XIVE interrupt thread context 28efbe5 ppc/xive: add support for the END Event State buffers 3f3bd6c ppc/xive: introduce the XIVE Event Notification Descriptors 871c908 ppc/xive: introduce the XiveRouter model caf164f ppc/xive: introduce the XiveNotifier interface eef5a2f ppc/xive: add support for the LSI interrupt sources 7c9d387 ppc/xive: introduce a XIVE interrupt source model === OUTPUT BEGIN === Checking PATCH 1/37: ppc/xive: introduce a XIVE interrupt source model... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #60: new file mode 100644 total: 0 errors, 1 warnings, 656 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/37: ppc/xive: add support for the LSI interrupt sources... Checking PATCH 3/37: ppc/xive: introduce the XiveNotifier interface... Checking PATCH 4/37: ppc/xive: introduce the XiveRouter model... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #169: new file mode 100644 total: 0 errors, 1 warnings, 179 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 5/37: ppc/xive: introduce the XIVE Event Notification Descriptors... Checking PATCH 6/37: ppc/xive: add support for the END Event State buffers... Checking PATCH 7/37: ppc/xive: introduce the XIVE interrupt thread context... Checking PATCH 8/37: ppc/xive: introduce a simplified XIVE presenter... Checking PATCH 9/37: ppc/xive: notify the CPU when the interrupt priority is more privileged... Checking PATCH 10/37: spapr/xive: introduce a XIVE interrupt controller... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #57: new file mode 100644 total: 0 errors, 1 warnings, 425 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 11/37: spapr/xive: use the VCPU id as a NVT identifier... Checking PATCH 12/37: spapr: initialize VSMT before initializing the IRQ backend... Checking PATCH 13/37: spapr: introduce a spapr_irq_init() routine... Checking PATCH 14/37: spapr: modify the irq backend 'init' method... Checking PATCH 15/37: spapr: export and rename the xics_max_server_number() routine... Checking PATCH 16/37: spapr: introdude a new machine IRQ backend for XIVE... Checking PATCH 17/37: spapr: add hcalls support for the XIVE exploitation interrupt mode... Checking PATCH 18/37: spapr: add device tree support for the XIVE exploitation mode... Checking PATCH 19/37: spapr: allocate the interrupt thread context under the CPU core... Checking PATCH 20/37: spapr: extend the sPAPR IRQ backend for XICS migration... Checking PATCH 21/37: spapr: add a 'reset' method to the sPAPR IRQ backend... Checking PATCH 22/37: spapr: add a 'pseries-3.1-xive' machine type... Checking PATCH 23/37: linux-headers: update to 4.20-rc5... Checking PATCH 24/37: spapr/xive: add KVM support... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #104: new file mode 100644 total: 0 errors, 1 warnings, 509 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 25/37: spapr/xive: add state synchronization with KVM... Checking PATCH 26/37: spapr/xive: introduce a VM state change handler... ERROR: spaces required around that '*' (ctx:WxV) #38: FILE: hw/intc/spapr_xive_kvm.c:341: + static void kvmppc_xive_sync_all(sPAPRXive *xive, Error **errp) ^ total: 1 errors, 0 warnings, 135 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 27/37: spapr/xive: add migration support for KVM... Checking PATCH 28/37: spapr/xive: fix migration of the XiveTCTX under TCG... Checking PATCH 29/37: spapr: set the interrupt presenter at reset... Checking PATCH 30/37: spapr/xive: enable XIVE MMIOs at reset... Checking PATCH 31/37: spapr: add a 'pseries-3.1-dual' machine type... Checking PATCH 32/37: ppc/xics: introduce a icp_kvm_connect() routine... Checking PATCH 33/37: spapr/rtas: modify spapr_rtas_register() to remove RTAS handlers... Checking PATCH 34/37: sysbus: add a sysbus_mmio_unmap() helper... Checking PATCH 35/37: spapr: introduce routines to delete the KVM IRQ device... Checking PATCH 36/37: spapr: check for KVM IRQ device activation... Checking PATCH 37/37: spapr: add KVM support to the 'dual' machine... === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20181205232251.10446-1-clg@kaod.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Hello, > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > Checking PATCH 25/37: spapr/xive: add state synchronization with KVM... > Checking PATCH 26/37: spapr/xive: introduce a VM state change handler... > ERROR: spaces required around that '*' (ctx:WxV) > #38: FILE: hw/intc/spapr_xive_kvm.c:341: > + static void kvmppc_xive_sync_all(sPAPRXive *xive, Error **errp) > ^ > > total: 1 errors, 0 warnings, 135 lines checked This looks like a false positive. C.
> On Dec 6, 2018, at 14:14, Cédric Le Goater <clg@kaod.org> wrote: > > Hello, > >> Your patch has style problems, please review. If any of these errors >> are false positives report them to the maintainer, see >> CHECKPATCH in MAINTAINERS. >> Checking PATCH 25/37: spapr/xive: add state synchronization with KVM... >> Checking PATCH 26/37: spapr/xive: introduce a VM state change handler... >> ERROR: spaces required around that '*' (ctx:WxV) >> #38: FILE: hw/intc/spapr_xive_kvm.c:341: >> + static void kvmppc_xive_sync_all(sPAPRXive *xive, Error **errp) >> ^ >> >> total: 1 errors, 0 warnings, 135 lines checked > > This looks like a false positive. Right. Without looking at the checkpatch code, I suspect this is due to sPAPRXive starts with a lower case letter which is not standard. Fam > > C. >