mbox series

[0/3] aio-posix: polling mode bug fixes

Message ID 20180912171040.1732-1-pbonzini@redhat.com
Headers show
Series aio-posix: polling mode bug fixes | expand

Message

Paolo Bonzini Sept. 12, 2018, 5:10 p.m. UTC
Patch 1 fixes a too-strict assertion that could fire when aio_poll
is called in parallel with aio_set_fd_handler.

Patch 2 and 3 reinstate the performance benefits of polling, which were
essentially disabled by commit 70232b5253 ("aio-posix: Don't count
ctx->notifier as progress when polling", 2018-08-15).

Please review carefully! :)

Thanks,

Paolo

Paolo Bonzini (3):
  aio-posix: fix concurrent access to poll_disable_cnt
  aio-posix: compute timeout before polling
  aio-posix: do skip system call if ctx->notifier polling succeeds

 util/aio-posix.c  | 88 +++++++++++++++++++++++++++--------------------
 util/trace-events |  4 +--
 2 files changed, 53 insertions(+), 39 deletions(-)

Comments

Fam Zheng Sept. 18, 2018, 8:13 a.m. UTC | #1
On Wed, 09/12 19:10, Paolo Bonzini wrote:
> Patch 1 fixes a too-strict assertion that could fire when aio_poll
> is called in parallel with aio_set_fd_handler.
> 
> Patch 2 and 3 reinstate the performance benefits of polling, which were
> essentially disabled by commit 70232b5253 ("aio-posix: Don't count
> ctx->notifier as progress when polling", 2018-08-15).
> 
> Please review carefully! :)

Queued, thanks!

Fam