From patchwork Tue Aug 14 12:14:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Sementsov-Ogievskiy X-Patchwork-Id: 957469 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=virtuozzo.com Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41qWlN11q3z9s9l for ; Tue, 14 Aug 2018 22:15:42 +1000 (AEST) Received: from localhost ([::1]:44021 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fpYEd-0002ex-EU for incoming@patchwork.ozlabs.org; Tue, 14 Aug 2018 08:15:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37582) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fpYDs-0002e7-Sg for qemu-devel@nongnu.org; Tue, 14 Aug 2018 08:14:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fpYDn-000522-Rh for qemu-devel@nongnu.org; Tue, 14 Aug 2018 08:14:52 -0400 Received: from relay.sw.ru ([185.231.240.75]:51110) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fpYDn-00051A-HM; Tue, 14 Aug 2018 08:14:47 -0400 Received: from vz-out.virtuozzo.com ([185.231.240.5] helo=kvm.sw.ru) by relay.sw.ru with esmtp (Exim 4.90_1) (envelope-from ) id 1fpYDk-0007K0-4o; Tue, 14 Aug 2018 15:14:44 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org, qemu-block@nongnu.org Date: Tue, 14 Aug 2018 15:14:35 +0300 Message-Id: <20180814121443.33114-1-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.11.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 185.231.240.75 Subject: [Qemu-devel] [PATCH v3 0/8] dirty-bitmap: rewrite bdrv_dirty_iter_next_area X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, famz@redhat.com, jcody@redhat.com, mreitz@redhat.com, den@openvz.org, pbonzini@redhat.com, jsnow@redhat.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Hi all. 1. bdrv_dirty_iter_next_area don't use hbitmap_next_zero and uses inefficient loop instead. Let's improve it. 2. bdrv_dirty_iter_next_area don't handle unaligned offset and max_offset correctly. I'm not sure that it is a real bug. But if it is, we need these series in 3.0. Details are in 05 commit message. v3: 01: - change interface to start/end, and -1 as special end-marker instead of 0 - "not found" for invalid regions instead of assert 02: rebase on 01 changes 03: - fix mistake in hbitmap_iter_init arguments (mistake in hbitmap_next_zero arguments is fixed automatically due to 01 changes) 04: new v2: 01: - improve comment - s/bytes/count/ - fix forgotten function call in test - introduce orig_size field here for HBitmap, make checking in hbitmap_next_zero more effective and safe 02: new 03: - orig_size already introduced in 01 - fix hbitmap_next_dirty_area to not return value less than offset on unaligned requests Vladimir Sementsov-Ogievskiy (8): dirty-bitmap: improve bdrv_dirty_bitmap_next_zero tests: add tests for hbitmap_next_zero with specified end parameter dirty-bitmap: add bdrv_dirty_bitmap_next_dirty_area tests: add tests for hbitmap_next_dirty_area block/mirror: fix and improve do_sync_target_write Revert "block/dirty-bitmap: Add bdrv_dirty_iter_next_area" Revert "test-hbitmap: Add non-advancing iter_next tests" Revert "hbitmap: Add @advance param to hbitmap_iter_next()" include/block/dirty-bitmap.h | 8 +- include/qemu/hbitmap.h | 30 ++++++-- block/backup.c | 4 +- block/dirty-bitmap.c | 69 +++-------------- block/mirror.c | 16 ++-- nbd/server.c | 2 +- tests/test-hbitmap.c | 176 ++++++++++++++++++++++++++++++++++++------- util/hbitmap.c | 73 +++++++++++++++--- 8 files changed, 258 insertions(+), 120 deletions(-)