From patchwork Thu Jun 14 19:14:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 929646 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 416Cz43f4Cz9s19 for ; Fri, 15 Jun 2018 05:16:32 +1000 (AEST) Received: from localhost ([::1]:42230 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTXjS-0002TG-48 for incoming@patchwork.ozlabs.org; Thu, 14 Jun 2018 15:16:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTXhx-0001aA-03 for qemu-devel@nongnu.org; Thu, 14 Jun 2018 15:15:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTXht-0001ZS-Sk for qemu-devel@nongnu.org; Thu, 14 Jun 2018 15:14:56 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:50448 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fTXhl-0001Rj-D3; Thu, 14 Jun 2018 15:14:45 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0F7D381663F2; Thu, 14 Jun 2018 19:14:45 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-117-1.ams2.redhat.com [10.36.117.1]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D98AC111762D; Thu, 14 Jun 2018 19:14:44 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 03A391138645; Thu, 14 Jun 2018 21:14:44 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Thu, 14 Jun 2018 21:14:25 +0200 Message-Id: <20180614191443.14361-1-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 14 Jun 2018 19:14:45 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 14 Jun 2018 19:14:45 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'armbru@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH v2 00/18] block: Configuration fixes and rbd authentication X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, jcody@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" PATCH 01-17 are configuration fixes and cleanup, in particular -blockdev driver=nfs,... and -drive driver=(nbd|sheepdog|ssh),... with non-string scalars. PATCH 18-19 provide support for configuring rbd authentication. I'm happy to split the series if that helps. Jeff Cody tested the RFC on his Ceph rig. All results match expectations. Since code changes since then have been minimal, I believe his test results remain valid. v2: * PATCH 03+05: Fix typos and pastos in commit message [Kevin] * PATCH 09: Fix error handling [Kevin] * PATCH 12: Redo for clarity [Kevin] Markus Armbruster (17): rbd: Drop deprecated -drive parameter "filename" iscsi: Drop deprecated -drive parameter "filename" qobject: Move block-specific qdict code to block-qdict.c block: Fix -blockdev for certain non-string scalars block: Fix -drive for certain non-string scalars block: Clean up a misuse of qobject_to() in .bdrv_co_create_opts() block: Factor out qobject_input_visitor_new_flat_confused() block: Make remaining uses of qobject input visitor more robust block-qdict: Simplify qdict_flatten_qdict() block-qdict: Tweak qdict_flatten_qdict(), qdict_flatten_qlist() block-qdict: Clean up qdict_crumple() a bit block-qdict: Simplify qdict_is_list() some check-block-qdict: Rename qdict_flatten()'s variables for clarity check-block-qdict: Cover flattening of empty lists and dictionaries block: Fix -blockdev / blockdev-add for empty objects and arrays rbd: New parameter auth-client-required rbd: New parameter key-secret Max Reitz (1): block: Add block-specific QDict header MAINTAINERS | 2 + block.c | 1 + block/crypto.c | 12 +- block/gluster.c | 1 + block/iscsi.c | 24 +- block/nbd.c | 16 +- block/nfs.c | 8 +- block/parallels.c | 11 +- block/qcow.c | 11 +- block/qcow2.c | 11 +- block/qed.c | 11 +- block/quorum.c | 1 + block/rbd.c | 85 +++-- block/sheepdog.c | 23 +- block/snapshot.c | 1 + block/ssh.c | 16 +- block/vdi.c | 8 +- block/vhdx.c | 11 +- block/vpc.c | 11 +- block/vvfat.c | 1 + block/vxhs.c | 1 + blockdev.c | 1 + include/block/qdict.h | 34 ++ include/qapi/qmp/qdict.h | 17 - qapi/block-core.json | 19 + qobject/Makefile.objs | 1 + qobject/block-qdict.c | 722 ++++++++++++++++++++++++++++++++++++++ qobject/qdict.c | 628 --------------------------------- tests/Makefile.include | 4 + tests/check-block-qdict.c | 690 ++++++++++++++++++++++++++++++++++++ tests/check-qdict.c | 641 --------------------------------- tests/check-qobject.c | 1 + tests/test-replication.c | 1 + util/qemu-config.c | 1 + 34 files changed, 1587 insertions(+), 1439 deletions(-) create mode 100644 include/block/qdict.h create mode 100644 qobject/block-qdict.c create mode 100644 tests/check-block-qdict.c