mbox series

[v7,0/4] monitor: let Monitor be thread safe

Message ID 20180524043952.11245-1-peterx@redhat.com
Headers show
Series monitor: let Monitor be thread safe | expand

Message

Peter Xu May 24, 2018, 4:39 a.m. UTC 
v7:
- let monitor_fdset_get_fd() return -errno, touch up qemu_open() to
  translate that into errno.  [Markus]
- touch up comment for Monitor.rs
- rebase, and torture the code a bit with qtest.

v6:
- add/drop some r-bs
- address all the comments from Markus
- rebase, and run some simple qtests to make sure nothing breaks

v5:
- collect r-bs and rebase
- move two close()s outside critical section [Dave]
- move comment to end of line [Stefan]

v4:
- fix a s/cur_mon/mon/ typo

v3:
- add comment for fields that are protected by monitor lock [Stefan]
- drop most of patch 2, only keep the protections for mon->fds [Stefan]
- add one trivial patch to add some more comments for either readline
  and cpu_get/cpu_set [Stefan]
- add protection for monitor_fdset_get_fd() [Stefan]

v2:
- cc correct people... sorry.

Stefan reported this problem that in the future we might start to have
more threads operating on the same Monitor object.  This seris try to
add fundamental support for it.

Please review.  Thanks,

Peter Xu (4):
  monitor: rename out_lock to mon_lock
  monitor: protect mon->fds with mon_lock
  monitor: more comments on lock-free fleids/funcs
  monitor: add lock to protect mon_fdsets

 monitor.c    | 155 +++++++++++++++++++++++++++++++++++++--------------
 util/osdep.c |   3 +-
 2 files changed, 115 insertions(+), 43 deletions(-)

Comments

no-reply@patchew.org May 24, 2018, 4:46 a.m. UTC | #1 
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180524043952.11245-1-peterx@redhat.com
Subject: [Qemu-devel] [PATCH v7 0/4] monitor: let Monitor be thread safe

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20180522035629.30428-1-peterx@redhat.com -> patchew/20180522035629.30428-1-peterx@redhat.com
 * [new tag]               patchew/20180524043952.11245-1-peterx@redhat.com -> patchew/20180524043952.11245-1-peterx@redhat.com
Switched to a new branch 'test'
dadcba2375 monitor: add lock to protect mon_fdsets
eda66671b9 monitor: more comments on lock-free fleids/funcs
b7d356e160 monitor: protect mon->fds with mon_lock
35eadfaff2 monitor: rename out_lock to mon_lock

=== OUTPUT BEGIN ===
Checking PATCH 1/4: monitor: rename out_lock to mon_lock...
Checking PATCH 2/4: monitor: protect mon->fds with mon_lock...
Checking PATCH 3/4: monitor: more comments on lock-free fleids/funcs...
ERROR: do not use C99 // comments
#28: FILE: monitor.c:218:
+    // other members that aren't shared

total: 1 errors, 0 warnings, 31 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/4: monitor: add lock to protect mon_fdsets...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com