mbox series

[0/5] linux-user: move socket.h definitions to CPU directories

Message ID 20180510222601.19944-1-laurent@vivier.eu
Headers show
Series linux-user: move socket.h definitions to CPU directories | expand

Message

Laurent Vivier May 10, 2018, 10:25 p.m. UTC 
Splitting out socket.h definitions helps to read the code
and to fix the bugs...

No code change, except for the last one that ports
definitions from linux for sparc as the values are not the
correct ones.

Laurent Vivier (5):
  linux-user: move mips socket.h definitions to mips/sockbits.h
  linux-user: move alpha socket.h definitions to alpha/sockbits.h
  linux-user: move sparc/sparc64 socket.h definitions to
    sparc/sockbits.h
  linux-user: move ppc socket.h definitions to ppc/sockbits.h
  linux-user: copy sparc/sockbits.h definitions from linux

 linux-user/alpha/sockbits.h   | 113 ++++++++++++++++++
 linux-user/mips/sockbits.h    | 110 ++++++++++++++++++
 linux-user/mips64/sockbits.h  |   1 +
 linux-user/ppc/sockbits.h     |  58 ++++++++++
 linux-user/socket.h           | 261 +-----------------------------------------
 linux-user/sparc/sockbits.h   | 111 ++++++++++++++++++
 linux-user/sparc64/sockbits.h |   1 +
 7 files changed, 397 insertions(+), 258 deletions(-)
 create mode 100644 linux-user/alpha/sockbits.h
 create mode 100644 linux-user/mips/sockbits.h
 create mode 100644 linux-user/mips64/sockbits.h
 create mode 100644 linux-user/ppc/sockbits.h
 create mode 100644 linux-user/sparc/sockbits.h
 create mode 100644 linux-user/sparc64/sockbits.h

Comments

no-reply@patchew.org May 10, 2018, 10:34 p.m. UTC | #1 
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180510222601.19944-1-laurent@vivier.eu
Subject: [Qemu-devel] [PATCH 0/5] linux-user: move socket.h definitions to CPU directories

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20180510222601.19944-1-laurent@vivier.eu -> patchew/20180510222601.19944-1-laurent@vivier.eu
Switched to a new branch 'test'
123e79ac3a linux-user: copy sparc/sockbits.h definitions from linux
8283def855 linux-user: move ppc socket.h definitions to ppc/sockbits.h
f3b56ab825 linux-user: move sparc/sparc64 socket.h definitions to sparc/sockbits.h
ce066c2209 linux-user: move alpha socket.h definitions to alpha/sockbits.h
97f6fbbacb linux-user: move mips socket.h definitions to mips/sockbits.h

=== OUTPUT BEGIN ===
Checking PATCH 1/5: linux-user: move mips socket.h definitions to mips/sockbits.h...
ERROR: if this code is redundant consider removing it
#47: FILE: linux-user/mips/sockbits.h:31:
+#if 0

total: 1 errors, 0 warnings, 227 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/5: linux-user: move alpha socket.h definitions to alpha/sockbits.h...
Checking PATCH 3/5: linux-user: move sparc/sparc64 socket.h definitions to sparc/sockbits.h...
Checking PATCH 4/5: linux-user: move ppc socket.h definitions to ppc/sockbits.h...
Checking PATCH 5/5: linux-user: copy sparc/sockbits.h definitions from linux...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Philippe Mathieu-Daudé May 13, 2018, 1:41 a.m. UTC | #2 
On 05/10/2018 07:25 PM, Laurent Vivier wrote:
> Splitting out socket.h definitions helps to read the code
> and to fix the bugs...
> 
> No code change, except for the last one that ports
> definitions from linux for sparc as the values are not the
> correct ones.
> 
> Laurent Vivier (5):
>   linux-user: move mips socket.h definitions to mips/sockbits.h
>   linux-user: move alpha socket.h definitions to alpha/sockbits.h
>   linux-user: move sparc/sparc64 socket.h definitions to
>     sparc/sockbits.h
>   linux-user: move ppc socket.h definitions to ppc/sockbits.h

^ patches 1-4:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

>   linux-user: copy sparc/sockbits.h definitions from linux
> 
>  linux-user/alpha/sockbits.h   | 113 ++++++++++++++++++
>  linux-user/mips/sockbits.h    | 110 ++++++++++++++++++
>  linux-user/mips64/sockbits.h  |   1 +
>  linux-user/ppc/sockbits.h     |  58 ++++++++++
>  linux-user/socket.h           | 261 +-----------------------------------------
>  linux-user/sparc/sockbits.h   | 111 ++++++++++++++++++
>  linux-user/sparc64/sockbits.h |   1 +
>  7 files changed, 397 insertions(+), 258 deletions(-)
>  create mode 100644 linux-user/alpha/sockbits.h
>  create mode 100644 linux-user/mips/sockbits.h
>  create mode 100644 linux-user/mips64/sockbits.h
>  create mode 100644 linux-user/ppc/sockbits.h
>  create mode 100644 linux-user/sparc/sockbits.h
>  create mode 100644 linux-user/sparc64/sockbits.h
>