| Message ID | 20180222195740.12726-1-bsd@redhat.com |
|---|---|
| Headers | show |
| Series | Initial write support for MTP objects | expand |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180222195740.12726-1-bsd@redhat.com
Subject: [Qemu-devel] [PATCH v5 0/5] Initial write support for MTP objects
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
cb9849cc80 usb-mtp: Advertise SendObjectInfo for write support
118c92b6be usb-mtp: Introduce write support for MTP objects
42843c3396 usb-mtp: Support delete of mtp objects
237aa15f74 usb-mtp: print parent path in IN_IGNORED trace fn
0153fb4213 usb-mtp: Add one more argument when building results
=== OUTPUT BEGIN ===
Checking PATCH 1/5: usb-mtp: Add one more argument when building results...
Checking PATCH 2/5: usb-mtp: print parent path in IN_IGNORED trace fn...
Checking PATCH 3/5: usb-mtp: Support delete of mtp objects...
Checking PATCH 4/5: usb-mtp: Introduce write support for MTP objects...
ERROR: trailing whitespace
#73: FILE: hw/usb/dev-mtp.c:1398:
+ } $
total: 1 errors, 0 warnings, 214 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/5: usb-mtp: Advertise SendObjectInfo for write support...
ERROR: suspect code indent for conditional statements (8, 8)
#115: FILE: hw/usb/dev-mtp.c:1430:
+ } else if (c->argv[0] && (c->argv[0] != QEMU_STORAGE_ID)) {
+ /* First parameter points to storage id or is 0 */
total: 1 errors, 0 warnings, 204 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
v5: 4/5,5/5: Add check for the RO bit and set response to STORE_READ_ONLY v4: 4/5: Remove getumask and set default permissions to 0644 5/5: Remove usb_mtp_object_lookup_name out of #ifdef CONFIG_INOTIFY1 Test compilation on freebsd v3: 3/5: Add a property that sets r/w to on/off (default:off) Restructure ifdefs 4/5: Sort the response codes 5/5: Use actual names for fields in the dataset Copy uint16_t to wchar_t and use wcstombs to get char type for filename v2: 3/5: Set mtp store flag to read only 4/5: Fix compiler warnings and change default file permissions 5/5: Fix file permissions These patches implement write support for Qemu's MTP emulation. Simple tests such as delete/move/edit/copy work ok. Current issues/TODO: - File transfers > 4GB has not been tested and will probably not work - Some (or most) MTP clients don't advertise hidden files and folders (names that start with a .) even though iiuc Qemu MTP does advertise these files. This can confuse certain applications such as text editors or git. - Also related, file editors typically run fsync when saving. Depending on the MTP client, it may choose not to implement it (such as simple-mtpfs that runs on top of fuse). - Needs more testing :) Bandan Das (5): usb-mtp: Add one more argument when building results usb-mtp: print parent path in IN_IGNORED trace fn usb-mtp: Support delete of mtp objects usb-mtp: Introduce write support for MTP objects usb-mtp: Advertise SendObjectInfo for write support hw/usb/dev-mtp.c | 471 +++++++++++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 441 insertions(+), 30 deletions(-)