| Message ID | 20180215212552.26997-1-marcandre.lureau@redhat.com |
|---|---|
| Headers | show |
| Series | vhost-user-test and leak fixes | expand |
On 15/02/2018 22:25, Marc-André Lureau wrote: > Hi, > > The following patches fix a regression introduced in commit > 218bb57dd79d that prevent ASAN from being detected & used. There is > also a works around for a GCC ASAN optimization bug. A few test leaks > are fixed, and a few patches reenable vhost-user memfd test fixing the > recent race bug that was identified in the previous version. > > Marc-André Lureau (6): > build-sys: fix -fsanitize=address check > lockable: workaround GCC link issue with ASAN > vhost-user-test: add back memfd check > vhost-user-test: do not hang if chardev creation failed > ahci-test: fix opts leak of skip tests > sdhci-test: fix leaks > > include/qemu/lockable.h | 2 +- > tests/ahci-test.c | 1 + > tests/sdhci-test.c | 2 ++ > tests/vhost-user-test.c | 94 +++++++++++++++++++++++++++++++++++-------------- > configure | 22 ++++++------ > 5 files changed, 83 insertions(+), 38 deletions(-) > Queued 1-2-5-6, not really confident enough in what's going on with vhost-user-test. :) Paolo
Hi On Fri, Feb 23, 2018 at 12:37 PM, Paolo Bonzini <pbonzini@redhat.com> wrote: > On 15/02/2018 22:25, Marc-André Lureau wrote: >> Hi, >> >> The following patches fix a regression introduced in commit >> 218bb57dd79d that prevent ASAN from being detected & used. There is >> also a works around for a GCC ASAN optimization bug. A few test leaks >> are fixed, and a few patches reenable vhost-user memfd test fixing the >> recent race bug that was identified in the previous version. >> >> Marc-André Lureau (6): >> build-sys: fix -fsanitize=address check >> lockable: workaround GCC link issue with ASAN >> vhost-user-test: add back memfd check >> vhost-user-test: do not hang if chardev creation failed >> ahci-test: fix opts leak of skip tests >> sdhci-test: fix leaks >> >> include/qemu/lockable.h | 2 +- >> tests/ahci-test.c | 1 + >> tests/sdhci-test.c | 2 ++ >> tests/vhost-user-test.c | 94 +++++++++++++++++++++++++++++++++++-------------- >> configure | 22 ++++++------ >> 5 files changed, 83 insertions(+), 38 deletions(-) >> > > Queued 1-2-5-6, not really confident enough in what's going on with > vhost-user-test. :) It hangs when chardev creation fails. Which is apparent when running with --debug-log. That's also why I added "vhost-user-test: do not hang if chardev creation failed". The problem comes from reusing socket location without waiting for the idle cleanup. Using different socket path solves it (vhost-user-test: add back memfd check) Maxime, could you help review those patches? thanks