Message ID | 20180205152455.12088-1-berrange@redhat.com |
---|---|
Headers | show |
Series | Enable passing pre-opened chardev socket FD | expand |
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180205152455.12088-1-berrange@redhat.com Subject: [Qemu-devel] [PATCH v4 0/9] Enable passing pre-opened chardev socket FD === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20180205152455.12088-1-berrange@redhat.com -> patchew/20180205152455.12088-1-berrange@redhat.com Switched to a new branch 'test' 29c42b4507 char: allow passing pre-opened socket file descriptor at startup aee1031ee5 char: refactor parsing of socket address information 20ea5df39c sockets: allow SocketAddress 'fd' to reference numeric file descriptors 027b5f7a00 sockets: check that the named file descriptor is a socket 0644767f1e sockets: move fd_is_socket() into common sockets code 567b6a4011 sockets: strengthen test suite IP protocol availability checks a77b1f3224 sockets: pull code for testing IP availability out of specific test 192bab41d1 cutils: add qemu_strtoi & qemu_strtoui parsers for int/unsigned int types faed1dfd01 char: don't silently skip tn3270 protocol init when TLS is enabled === OUTPUT BEGIN === Checking PATCH 1/9: char: don't silently skip tn3270 protocol init when TLS is enabled... Checking PATCH 2/9: cutils: add qemu_strtoi & qemu_strtoui parsers for int/unsigned int types... ERROR: consider using qemu_strtol in preference to strtol #733: FILE: util/cutils.c:338: + lresult = strtol(nptr, &ep, base); ERROR: consider using qemu_strtol in preference to strtol #783: FILE: util/cutils.c:388: + lresult = strtol(nptr, &ep, base); total: 2 errors, 0 warnings, 785 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/9: sockets: pull code for testing IP availability out of specific test... Checking PATCH 4/9: sockets: strengthen test suite IP protocol availability checks... Checking PATCH 5/9: sockets: move fd_is_socket() into common sockets code... Checking PATCH 6/9: sockets: check that the named file descriptor is a socket... Checking PATCH 7/9: sockets: allow SocketAddress 'fd' to reference numeric file descriptors... Checking PATCH 8/9: char: refactor parsing of socket address information... Checking PATCH 9/9: char: allow passing pre-opened socket file descriptor at startup... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org