mbox series

[v6,0/2] Convert apple related code to keycodemapdb

Message ID 20171212142500.3909-1-berrange@redhat.com
Headers show
Series Convert apple related code to keycodemapdb | expand

Message

Daniel P. Berrangé Dec. 12, 2017, 2:24 p.m. UTC 
This is a followup to

  v1: https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg02047.html
  v2: https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg02471.html
  v3: https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg02517.html
  v4: https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg02708.html
  v5: https://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg02950.html

This series contains only the apple related patches, the cocoa frontend
and adb backend device.

I decided to separate them, as I'm fairly sure the keycodemapdb data for
these has some problems in it. There is contradictory information on the
right mappings to use for certain keys. Looking at darwin source code
in fact I think that the low level hardware scancode -> keycode mappings
on OS-X might even change based on user config options at the OS level,
and I'm not sure how to deal with that yet.

So I need todo more investigation before I consider these two patches
ready for merge. They're just posted to allow any feedback to be gathered


Daniel P. Berrange (2):
  hw: convert the adb device to keycodemapdb
  ui: convert cocoa frontend to keycodemapdb

 Makefile                    |   2 +
 hw/input/adb.c              | 124 +-------------------------------------
 include/hw/input/adb-keys.h | 141 --------------------------------------------
 include/ui/input.h          |   5 ++
 ui/cocoa.m                  | 129 +---------------------------------------
 ui/input-keymap.c           |   2 +
 6 files changed, 13 insertions(+), 390 deletions(-)
 delete mode 100644 include/hw/input/adb-keys.h

Comments

Gerd Hoffmann Jan. 15, 2018, 3:12 p.m. UTC | #1 
On Tue, Dec 12, 2017 at 02:24:58PM +0000, Daniel P. Berrange wrote:
> This is a followup to
> 
>   v1: https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg02047.html
>   v2: https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg02471.html
>   v3: https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg02517.html
>   v4: https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg02708.html
>   v5: https://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg02950.html
> 
> This series contains only the apple related patches, the cocoa frontend
> and adb backend device.
> 
> I decided to separate them, as I'm fairly sure the keycodemapdb data for
> these has some problems in it. There is contradictory information on the
> right mappings to use for certain keys. Looking at darwin source code
> in fact I think that the low level hardware scancode -> keycode mappings
> on OS-X might even change based on user config options at the OS level,
> and I'm not sure how to deal with that yet.
> 
> So I need todo more investigation before I consider these two patches
> ready for merge. They're just posted to allow any feedback to be gathered

Doesn't apply any more, can you rebase?

thanks,
  Gerd