mbox series

[0/3] sdl: hotkey updates and cleanups

Message ID 20171103115842.1534-1-kraxel@redhat.com
Headers show
Series sdl: hotkey updates and cleanups | expand

Message

Gerd Hoffmann Nov. 3, 2017, 11:58 a.m. UTC 
Gerd Hoffmann (3):
  sdl: remove -no-frame support
  sdl: remove -alt-grab and -ctrl-grab support
  sdl: use ctrl-alt-g as grab hotkey

 include/ui/console.h |  5 ++---
 ui/sdl.c             | 54 ++++++++++++++--------------------------------------
 ui/sdl2.c            | 50 ++++++++++++------------------------------------
 vl.c                 | 39 +++++++------------------------------
 4 files changed, 35 insertions(+), 113 deletions(-)

Comments

no-reply@patchew.org Nov. 3, 2017, 12:25 p.m. UTC | #1 
Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/3] sdl: hotkey updates and cleanups
Type: series
Message-id: 20171103115842.1534-1-kraxel@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20171103115631.15175-1-owen.smith@citrix.com -> patchew/20171103115631.15175-1-owen.smith@citrix.com
 * [new tag]               patchew/20171103115842.1534-1-kraxel@redhat.com -> patchew/20171103115842.1534-1-kraxel@redhat.com
Switched to a new branch 'test'
6a107a4db8 sdl: use ctrl-alt-g as grab hotkey
8d798600f3 sdl: remove -alt-grab and -ctrl-grab support
2ac2b2f6b8 sdl: remove -no-frame support

=== OUTPUT BEGIN ===
Checking PATCH 1/3: sdl: remove -no-frame support...
Checking PATCH 2/3: sdl: remove -alt-grab and -ctrl-grab support...
ERROR: space prohibited after that '&' (ctx:WxW)
#48: FILE: ui/sdl.c:554:
+    mod_state = (SDL_GetModState() & gui_grab_code) == gui_grab_code;
                                    ^

ERROR: space prohibited after that '&' (ctx:WxW)
#96: FILE: ui/sdl2.c:333:
+    mod_state = (SDL_GetModState() & gui_grab_code) == gui_grab_code;
                                    ^

total: 2 errors, 0 warnings, 135 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/3: sdl: use ctrl-alt-g as grab hotkey...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org