mbox series

[0/5] build fixes for --disable-tcg

Message ID 20171030030553.21259-1-f4bug@amsat.org
Headers show
Series build fixes for --disable-tcg | expand

Message

Philippe Mathieu-Daudé Oct. 30, 2017, 3:05 a.m. UTC 
Hi,

This series add missing stubs (as suggested by Eduardo in [1]) to build
the i386/s390x targets with --disable-tcg (the only targets building without
TCG so far).

For git workflow ease, I split by offending commit (so one can branch from
this particular commit and cherry-pick the corresponding fix[es]).

Regards,

Phil.

[1]: http://lists.nongnu.org/archive/html/qemu-devel/2017-10/msg06094.html

Philippe Mathieu-Daudé (5):
  accel/tcg: add missing target-independent stubs
  target/i386: tcg stubs
  target/s390x: tcg stubs
  accel/tcg: add a stub for tcg_region_init()
  accel/tcg: add a stub for tcg_register_thread()

 accel/stubs/tcg-stub.c     | 27 +++++++++++++++++++++++++++
 target/i386/tcg-stub.c     | 13 +++++++++++++
 target/s390x/tcg-stub.c    | 13 +++++++++++++
 target/i386/Makefile.objs  |  1 +
 target/s390x/Makefile.objs |  1 +
 5 files changed, 55 insertions(+)
 create mode 100644 target/i386/tcg-stub.c
 create mode 100644 target/s390x/tcg-stub.c

Comments

Thomas Huth Oct. 30, 2017, 8:05 a.m. UTC | #1 
On 30.10.2017 04:05, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> This series add missing stubs (as suggested by Eduardo in [1]) to build
> the i386/s390x targets with --disable-tcg (the only targets building without
> TCG so far).

Compiling with --disable-tcg works fine for me with the latest master
branch as of today, on both x86 and s390x. Are you sure that these
patches are still required?

 Thomas
Philippe Mathieu-Daudé Oct. 30, 2017, 12:46 p.m. UTC | #2 
Hi Thomas,

On 10/30/2017 05:05 AM, Thomas Huth wrote:
> Compiling with --disable-tcg works fine for me with the latest master
> branch as of today, on both x86 and s390x. Are you sure that these
> patches are still required?

I guess I didn't pulled /master early enough so I missed Peter's merge.
Indeed a bug fix got applied so these patches are not required.

However they now allow less #ifdef'fery and might have value in git log
history, so I'll wait a bit for Eduardo and Paolo comments before
dropping it.

Regards,

Phil.