mbox series

[v4,0/4] hmp: fix "dump-quest-memory" segfault

Message ID 20170913142036.2469-1-lvivier@redhat.com
Headers show
Series hmp: fix "dump-quest-memory" segfault | expand

Message

Laurent Vivier Sept. 13, 2017, 2:20 p.m. UTC 
Fix aarch64 and ppc when dump-guest-memory is
used with none machine type and no CPU.

The other machine types don't have the problem.

Update test-hmp, to test none machine type
with (2 MB) and without memory, and add a test
to test dump-quest-memory without filter parameters

v4:
  - update comment in test-hmp.c
  - add cohuck's patch

v3:
  - remove blank line after a comment
  - forbid memory dump when there is no CPU

v2:
  - add arm fix
  - update test-hmp

Cornelia Huck (1):
  dump: do not dump non-existent guest memory

Laurent Vivier (3):
  hmp: fix "dump-quest-memory" segfault (ppc)
  hmp: fix "dump-quest-memory" segfault (arm)
  tests/hmp: test "none" machine with memory

 dump.c                 |  6 ++++++
 target/arm/arch_dump.c | 11 +++++++++--
 target/ppc/arch_dump.c | 11 +++++++++--
 tests/test-hmp.c       |  4 ++++
 4 files changed, 28 insertions(+), 4 deletions(-)

Comments

Dr. David Alan Gilbert Sept. 14, 2017, 9:50 a.m. UTC | #1 
* Laurent Vivier (lvivier@redhat.com) wrote:
> Fix aarch64 and ppc when dump-guest-memory is
> used with none machine type and no CPU.
> 
> The other machine types don't have the problem.
> 
> Update test-hmp, to test none machine type
> with (2 MB) and without memory, and add a test
> to test dump-quest-memory without filter parameters

Queued for HMP

Dave

> 
> v4:
>   - update comment in test-hmp.c
>   - add cohuck's patch
> 
> v3:
>   - remove blank line after a comment
>   - forbid memory dump when there is no CPU
> 
> v2:
>   - add arm fix
>   - update test-hmp
> 
> Cornelia Huck (1):
>   dump: do not dump non-existent guest memory
> 
> Laurent Vivier (3):
>   hmp: fix "dump-quest-memory" segfault (ppc)
>   hmp: fix "dump-quest-memory" segfault (arm)
>   tests/hmp: test "none" machine with memory
> 
>  dump.c                 |  6 ++++++
>  target/arm/arch_dump.c | 11 +++++++++--
>  target/ppc/arch_dump.c | 11 +++++++++--
>  tests/test-hmp.c       |  4 ++++
>  4 files changed, 28 insertions(+), 4 deletions(-)
> 
> -- 
> 2.13.5
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK