mbox series

[0/9] buildsys: Move ui/usb library cflags/libs to per object

Message ID 20170907082918.7299-1-famz@redhat.com
Headers show
Series buildsys: Move ui/usb library cflags/libs to per object | expand

Message

Fam Zheng Sept. 7, 2017, 8:29 a.m. UTC
Hi Gerd,

This is part two of the QEMU_CFLAGS and libs_softmmu cleanup series, including
ui/, audio/ and hw/usb/. Please review.

Fam Zheng (9):
  buildsys: Move gtk/vte cflags/libs to per object
  buildsys: Move sdl cflags/libs to per object
  buildsys: Move vnc cflags/libs to per object
  buildsys: Move audio libs to per object
  buildsys: Move curese cflags/libs to per object
  buildsys: Move opengl cflags to per object
  buildsys: Move libcacard cflags/libs to per object
  buildsys: Move libusb cflags/libs to per object
  buildsys: Move usb redir cflags/libs to per object

 audio/Makefile.objs  |  6 ++++++
 configure            | 54 ++++++++++++++++++++++++++++++----------------------
 hw/usb/Makefile.objs | 13 +++++++++++--
 ui/Makefile.objs     | 37 ++++++++++++++++++++++-------------
 4 files changed, 72 insertions(+), 38 deletions(-)

Comments

Gerd Hoffmann Sept. 7, 2017, 9:34 a.m. UTC | #1
On Thu, 2017-09-07 at 16:29 +0800, Fam Zheng wrote:
> Hi Gerd,
> 
> This is part two of the QEMU_CFLAGS and libs_softmmu cleanup series,
> including
> ui/, audio/ and hw/usb/. Please review.

Looks good, survived a test build.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

cheers,
  Gerd
Fam Zheng Sept. 7, 2017, 11:43 a.m. UTC | #2
On Thu, 09/07 11:34, Gerd Hoffmann wrote:
> On Thu, 2017-09-07 at 16:29 +0800, Fam Zheng wrote:
> > Hi Gerd,
> > 
> > This is part two of the QEMU_CFLAGS and libs_softmmu cleanup series,
> > including
> > ui/, audio/ and hw/usb/. Please review.
> 
> Looks good, survived a test build.
> 
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

Thanks for the quick review! Do you want to queue this in your tree? If not I
can include it in my next pull request for "build and test automation" patches.

Fam
Philippe Mathieu-Daudé Sept. 7, 2017, 5:48 p.m. UTC | #3
On 09/07/2017 08:43 AM, Fam Zheng wrote:
> On Thu, 09/07 11:34, Gerd Hoffmann wrote:
>> On Thu, 2017-09-07 at 16:29 +0800, Fam Zheng wrote:
>>> Hi Gerd,
>>>
>>> This is part two of the QEMU_CFLAGS and libs_softmmu cleanup series,
>>> including
>>> ui/, audio/ and hw/usb/. Please review.
>>
>> Looks good, survived a test build.
>>
>> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> Thanks for the quick review! Do you want to queue this in your tree? If not I
> can include it in my next pull request for "build and test automation" patches.

+1 for "build and test automation"

this series:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Also Fam I recommend you to use scripts/git.orderfile it is easier to 
read the ./configure before the Makefiles.

Regards,

Phil.
Gerd Hoffmann Sept. 8, 2017, 6:20 a.m. UTC | #4
On Thu, 2017-09-07 at 19:43 +0800, Fam Zheng wrote:
> On Thu, 09/07 11:34, Gerd Hoffmann wrote:
> > On Thu, 2017-09-07 at 16:29 +0800, Fam Zheng wrote:
> > > Hi Gerd,
> > > 
> > > This is part two of the QEMU_CFLAGS and libs_softmmu cleanup
> > > series,
> > > including
> > > ui/, audio/ and hw/usb/. Please review.
> > 
> > Looks good, survived a test build.
> > 
> > Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> Thanks for the quick review! Do you want to queue this in your tree?
> If not I
> can include it in my next pull request for "build and test
> automation" patches.

Feel free do include it in your pull.  I assumed that is your intention
anyway as you've asked for review not merge ;)

cheers,
  Gerd
Fam Zheng Sept. 8, 2017, 6:28 a.m. UTC | #5
On Fri, 09/08 08:20, Gerd Hoffmann wrote:
> On Thu, 2017-09-07 at 19:43 +0800, Fam Zheng wrote:
> > On Thu, 09/07 11:34, Gerd Hoffmann wrote:
> > > On Thu, 2017-09-07 at 16:29 +0800, Fam Zheng wrote:
> > > > Hi Gerd,
> > > > 
> > > > This is part two of the QEMU_CFLAGS and libs_softmmu cleanup
> > > > series,
> > > > including
> > > > ui/, audio/ and hw/usb/. Please review.
> > > 
> > > Looks good, survived a test build.
> > > 
> > > Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
> > 
> > Thanks for the quick review! Do you want to queue this in your tree?
> > If not I
> > can include it in my next pull request for "build and test
> > automation" patches.
> 
> Feel free do include it in your pull.  I assumed that is your intention
> anyway as you've asked for review not merge ;)

Thanks, I'll send a pull request later. (I thought asking for review first is a
necessary step before talking about merging :)

Fam