mbox series

[v3,0/3] Make hcd-xhci independent of pci hooks

Message ID 1594140271-16462-1-git-send-email-sai.pavan.boddu@xilinx.com
Headers show
Series Make hcd-xhci independent of pci hooks | expand

Message

Sai Pavan Boddu July 7, 2020, 4:44 p.m. UTC 
Hi

This patch series attempts to make 'hcd-xhci' an independent model so
it can be used by both pci and system-bus interface.

Changes for V2:
    Make XHCIState non-qom
    Use container_of functions for retriving pci device instance
    Initialize the AddressSpace pointer in PATCH 1/3 itself
Changes for V3:
    Convert XHCIState to TYPE_DEVICE and register as a child of XHCIPciState.


Sai Pavan Boddu (3):
  usb/hcd-xhci: Make dma read/writes hooks pci free
  usb/hcd-xhci: Move qemu-xhci device to hcd-xhci-pci.c
  usb/hcd-xhci: Split pci wrapper for xhci base model

 hw/usb/Kconfig        |   6 ++
 hw/usb/Makefile.objs  |   1 +
 hw/usb/hcd-xhci-nec.c |  18 ++--
 hw/usb/hcd-xhci-pci.c | 242 ++++++++++++++++++++++++++++++++++++++++++++++
 hw/usb/hcd-xhci-pci.h |  45 +++++++++
 hw/usb/hcd-xhci.c     | 259 ++++++++++----------------------------------------
 hw/usb/hcd-xhci.h     |  20 ++--
 7 files changed, 367 insertions(+), 224 deletions(-)
 create mode 100644 hw/usb/hcd-xhci-pci.c
 create mode 100644 hw/usb/hcd-xhci-pci.h

Comments

Sai Pavan Boddu July 14, 2020, 1:59 p.m. UTC | #1 
Hi Gerd,

Any review on V3. So that I can work on.

Regards,
Sai Pavan

> -----Original Message-----
> From: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
> Sent: Tuesday, July 7, 2020 10:14 PM
> To: Gerd Hoffmann <kraxel@redhat.com>; Peter Maydell
> <peter.maydell@linaro.org>; Markus Armbruster <armbru@redhat.com>
> Cc: Thomas Huth <thuth@redhat.com>; Eduardo Habkost
> <ehabkost@redhat.com>; qemu-devel@nongnu.org; Alistair Francis
> <alistair.francis@wdc.com>; 'Marc-André Lureau'
> <marcandre.lureau@redhat.com>; Ying Fang <fangying1@huawei.com>;
> Paolo Bonzini <pbonzini@redhat.com>; 'Philippe Mathieu-Daudé'
> <philmd@redhat.com>; Vikram Garhwal <fnuv@xilinx.com>; Paul
> Zimmerman <pauldzim@gmail.com>; Sai Pavan Boddu <saipava@xilinx.com>
> Subject: [PATCH v3 0/3] Make hcd-xhci independent of pci hooks
> 
> Hi
> 
> This patch series attempts to make 'hcd-xhci' an independent model so it can
> be used by both pci and system-bus interface.
> 
> Changes for V2:
>     Make XHCIState non-qom
>     Use container_of functions for retriving pci device instance
>     Initialize the AddressSpace pointer in PATCH 1/3 itself Changes for V3:
>     Convert XHCIState to TYPE_DEVICE and register as a child of XHCIPciState.
> 
> 
> Sai Pavan Boddu (3):
>   usb/hcd-xhci: Make dma read/writes hooks pci free
>   usb/hcd-xhci: Move qemu-xhci device to hcd-xhci-pci.c
>   usb/hcd-xhci: Split pci wrapper for xhci base model
> 
>  hw/usb/Kconfig        |   6 ++
>  hw/usb/Makefile.objs  |   1 +
>  hw/usb/hcd-xhci-nec.c |  18 ++--
>  hw/usb/hcd-xhci-pci.c | 242
> ++++++++++++++++++++++++++++++++++++++++++++++
>  hw/usb/hcd-xhci-pci.h |  45 +++++++++
>  hw/usb/hcd-xhci.c     | 259 ++++++++++----------------------------------------
>  hw/usb/hcd-xhci.h     |  20 ++--
>  7 files changed, 367 insertions(+), 224 deletions(-)  create mode 100644
> hw/usb/hcd-xhci-pci.c  create mode 100644 hw/usb/hcd-xhci-pci.h
> 
> --
> 2.7.4
Gerd Hoffmann July 15, 2020, 10:51 a.m. UTC | #2 
On Tue, Jul 14, 2020 at 01:59:12PM +0000, Sai Pavan Boddu wrote:
> Hi Gerd,
> 
> Any review on V3. So that I can work on.

Busy due to freeze, sorry for the delay.
Looks good to me overall.  Not tested yet.

Wasn't the plan to include the sysbus bits too, so it's easier to see
how code code separation works out on both pci and sysbus?

take care,
  Gerd
Sai Pavan Boddu July 16, 2020, 12:57 p.m. UTC | #3 
Hi Gred,

> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Wednesday, July 15, 2020 4:21 PM
> To: Sai Pavan Boddu <saipava@xilinx.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>; Markus Armbruster
> <armbru@redhat.com>; Thomas Huth <thuth@redhat.com>; Eduardo
> Habkost <ehabkost@redhat.com>; qemu-devel@nongnu.org; Alistair Francis
> <alistair.francis@wdc.com>; 'Marc-André Lureau'
> <marcandre.lureau@redhat.com>; Ying Fang <fangying1@huawei.com>;
> Paolo Bonzini <pbonzini@redhat.com>; 'Philippe Mathieu-Daudé'
> <philmd@redhat.com>; Vikram Garhwal <fnuv@xilinx.com>; Paul
> Zimmerman <pauldzim@gmail.com>
> Subject: Re: [PATCH v3 0/3] Make hcd-xhci independent of pci hooks
> 
> On Tue, Jul 14, 2020 at 01:59:12PM +0000, Sai Pavan Boddu wrote:
> > Hi Gerd,
> >
> > Any review on V3. So that I can work on.
> 
> Busy due to freeze, sorry for the delay.
> Looks good to me overall.  Not tested yet.
> 
> Wasn't the plan to include the sysbus bits too, so it's easier to see how code
> code separation works out on both pci and sysbus?
[Sai Pavan Boddu] Ok, I will include that in V4.

Thanks,
Sai Pavan
> 
> take care,
>   Gerd