| Message ID | 1571592258-27994-1-git-send-email-aleksandar.markovic@rt-rk.com |
|---|---|
| Headers | show |
| Series | target/mips: Misc cleanups for September/October 2019 | expand |
Patchew URL: https://patchew.org/QEMU/1571592258-27994-1-git-send-email-aleksandar.markovic@rt-rk.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v5 00/10] target/mips: Misc cleanups for September/October 2019
Type: series
Message-id: 1571592258-27994-1-git-send-email-aleksandar.markovic@rt-rk.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
a3ac1b5 target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D>
f2d8cc8 target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D>
0fbd29f target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D>
d5de108 target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>
241b1e2 target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>
3d8badc target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>
5cdb8dc target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>
c90aa1a MAINTAINERS: Update mail address of Aleksandar Rikalo
87f42dd target/mips: Clean up op_helper.c
8f1a78b target/mips: Clean up helper.c
=== OUTPUT BEGIN ===
1/10 Checking commit 8f1a78be6a6f (target/mips: Clean up helper.c)
2/10 Checking commit 87f42dd3535d (target/mips: Clean up op_helper.c)
ERROR: spaces required around that '*' (ctx:WxV)
#1058: FILE: target/mips/op_helper.c:3871:
+ float_status *status) \
^
total: 1 errors, 0 warnings, 1681 lines checked
Patch 2/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/10 Checking commit c90aa1a64eb4 (MAINTAINERS: Update mail address of Aleksandar Rikalo)
4/10 Checking commit 5cdb8dc16a58 (target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>)
5/10 Checking commit 3d8badc1112f (target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>)
6/10 Checking commit 241b1e2b6824 (target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>)
7/10 Checking commit d5de108dacd5 (target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>)
8/10 Checking commit 0fbd29fa4a0b (target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D>)
9/10 Checking commit f2d8cc85b88d (target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D>)
10/10 Checking commit a3ac1b5110e6 (target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D>)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1571592258-27994-1-git-send-email-aleksandar.markovic@rt-rk.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
> From: Aleksandar Markovic <amarkovic@wavecomp.com> > > Mostly cosmetic changes. > > v4->v5: > > - minor correction in patch on helper.c > - added patches 9 and 10 > > v3->v4: > > - added patches 7 and 8 > > v2->v3: > > - removed all patches that were already integrated > - patches 1 and 2 are improved from v2 > - added patches 3-6 > > v1->v2: > > - minor corrections to satisfy reviews > - added several more patches > > Aleksandar Markovic (10): > target/mips: Clean up helper.c > target/mips: Clean up op_helper.c > MAINTAINERS: Update mail address of Aleksandar Rikalo > target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D> > target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D> > target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D> > target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D> > target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D> > target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D> > target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D> > > .mailmap | 5 +- > MAINTAINERS | 18 +- > target/mips/helper.c | 123 +- > target/mips/helper.h | 133 +- > target/mips/msa_helper.c | 4244 +++++++++++++++++++++++++++++----------------- > target/mips/op_helper.c | 1010 +++++++---- > target/mips/translate.c | 442 ++++- > 7 files changed, 3966 insertions(+), 2009 deletions(-) > For the whole series: Reviewed-by: Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>
From: Aleksandar Markovic <amarkovic@wavecomp.com> Mostly cosmetic changes. v4->v5: - minor correction in patch on helper.c - added patches 9 and 10 v3->v4: - added patches 7 and 8 v2->v3: - removed all patches that were already integrated - patches 1 and 2 are improved from v2 - added patches 3-6 v1->v2: - minor corrections to satisfy reviews - added several more patches Aleksandar Markovic (10): target/mips: Clean up helper.c target/mips: Clean up op_helper.c MAINTAINERS: Update mail address of Aleksandar Rikalo target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D> target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D> target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D> target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D> target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D> target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D> target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D> .mailmap | 5 +- MAINTAINERS | 18 +- target/mips/helper.c | 123 +- target/mips/helper.h | 133 +- target/mips/msa_helper.c | 4244 +++++++++++++++++++++++++++++----------------- target/mips/op_helper.c | 1010 +++++++---- target/mips/translate.c | 442 ++++- 7 files changed, 3966 insertions(+), 2009 deletions(-)