Message ID | 1554129501-27175-1-git-send-email-mateja.marjanovic@rt-rk.com |
---|---|
Headers | show |
Series | target/mips: Integer division by zero in MSA insturctions | expand |
> From: Mateja Marjanovic <mateja.marjanovic@rt-rk.com> > Subject: [PATCH 0/2] target/mips: Integer division by zero in MSA insturctions > The title look incomplete and uninformative: it mentions "the division by zero" - but what is done in this case? Is this an implementation of that case? Or fix? Or something else? The title should clearly and in a condensed form explain what is done in the series. > From: Mateja Marjanovic <Mateja.Marjanovic@rt-rk.com> > > Integer division by zero in MSA insturctions results in unpredictable > behaviour, but according to the hardware, it depends on the sign of > the dividend, or always returns the same value. > This is a very unclear sentence. A sentence that says that the series makes the behavior of QEMU and the reference hardware the same in cases of division and modulus operations with zero divisor is missing. > Mateja Marjanovic (2): > target/mips: DIV_<U|S>.<B|H|W|D> MSA insturctions fixed > target/mips: MOD_<U|S>.<B|H|W|D> MSA insturctions fixed > > target/mips/msa_helper.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) Check spelling. Thanks, Aleksandar
On 1.4.19. 19:43, Aleksandar Markovic wrote: >> From: Mateja Marjanovic <mateja.marjanovic@rt-rk.com> >> Subject: [PATCH 0/2] target/mips: Integer division by zero in MSA insturctions >> > The title look incomplete and uninformative: it mentions "the division by zero" > - but what is done in this case? Is this an implementation of that case? Or fix? > Or something else? > > The title should clearly and in a condensed form explain what is done in the > series. Yes, you are right, it looks unclear, I will change it in v2. > >> From: Mateja Marjanovic <Mateja.Marjanovic@rt-rk.com> >> >> Integer division by zero in MSA insturctions results in unpredictable >> behaviour, but according to the hardware, it depends on the sign of >> the dividend, or always returns the same value. >> > This is a very unclear sentence. > > A sentence that says that the series makes the behavior of QEMU > and the reference hardware the same in cases of division and modulus > operations with zero divisor is missing. I will change it and make it more clear and understandable in v2. > >> Mateja Marjanovic (2): >> target/mips: DIV_<U|S>.<B|H|W|D> MSA insturctions fixed >> target/mips: MOD_<U|S>.<B|H|W|D> MSA insturctions fixed >> >> target/mips/msa_helper.c | 11 +++++++---- >> 1 file changed, 7 insertions(+), 4 deletions(-) > Check spelling. I will try to find some tool for that. > > Thanks, > Aleksandar Thanks, Mateja
From: Mateja Marjanovic <Mateja.Marjanovic@rt-rk.com> Integer division by zero in MSA insturctions results in unpredictable behaviour, but according to the hardware, it depends on the sign of the dividend, or always returns the same value. Mateja Marjanovic (2): target/mips: DIV_<U|S>.<B|H|W|D> MSA insturctions fixed target/mips: MOD_<U|S>.<B|H|W|D> MSA insturctions fixed target/mips/msa_helper.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)