| Message ID | 1548410831-19553-1-git-send-email-pbonzini@redhat.com |
|---|---|
| Headers | show |
| Series | Support Kconfig in QEMU | expand |
On Fri, Jan 25, 2019 at 11:06:19AM +0100, Paolo Bonzini wrote: > (I'm only momentarily at the helm and will give control back to Yang after > this iteration.) > > This is still RFC mostly because of the lack of documentation, and because > only x86 is fully converted, but it's converging. Other targets still > enable embedded devices in default-configs/ instead of using "select" > directives. For many targets, the conversion will be trivial because > they only support one board. The complex ones are ARM, MIPS and PPC > of course. s390 as usual is just different in some respects, but all > of its issues are sorted out already in this series and so it's just > yet another single-board target. > > It supports defconfig (default-configs file chooses boards only) > and allnoconfig (default-configs file chooses devices too) and builds > all targets. I haven't yet checked that the configuration is the same > before and after the conversion, but at least device-introspection-test > and other qtests all pass, which did catch some errors. > > As mentioned in the previous versions, this is only a replacement > for default-configs, in order to simplify configuration and remove > the need to track dependencies between configuration symbols. In > fact, even with the current incomplete conversion the diffstat > for default-configs is already > > 31 files changed, 108 insertions(+), 241 deletions(-) > > Devices can be disabled by adding for example > > CONFIG_HPET=n > > to default-configs/i386-softmmu.mak. If you prefer they can be > listed manually and "make allnoconfig" can be executed before > building. This probably should become a configure option > "--without-default-devices" instead. > > For the previous discussions on the Kconfig design, see > http://lists.nongnu.org/archive/html/qemu-devel/2018-09/msg02827.html > > Patches 1-27 should probably be committed now, so please review! Yang, > once they are reviewed you can extract them and post them to the > mailing list as non-RFC! Thanks Paolo, you helped me address comments in v4 and i will do it. Yang > As to the rest, you're welcome to try them, post conversions for the > simple targets, suggest usability improvements, and whatever. Thanks to > everyone for the work on the previous iterations. It's great to see > the work on this GSoC project come back to life after five years! > > v4->v5: new patches 1, 2, 3, 13, 26, 27, 47, 49, 50, 52 > Removed CONFIG_TYPHOON (patch 20) > Removed CONFIG_DINO (patch 22) > ported minikconf to python 3 > improved some minikconf error messages > added missing symbols in patch 32 > added CONFIG_VHOST_USER and CONFIG_LINUX, made CONFIG_KVM per target (patch 33) > removed $(...) assignments from default-configs/ (patch 33) > moved allnoconfig patch earlier, removed allyesconfig/randconfig > add CONFIG_PCI_EXPRESS to non-x86 targets (patch 36) > added CONFIG_PCI_DEVICES in patch 37 to support s390x > virtio-mmio does not support vhost-user yet (patches 40 and 48) > fix PCSPK for platforms that lack an i8254 (patch 41) > add "select ISA_BUS" to I82378 and SUN4U (patch 41) > changed QXL/VTD/AMD_IOMMU from "select" to "default y if ..." (patch 42) > moved "select PAM" and "select ISA_BUS" from board to device (patch 42) > brought patch 44 up to date > fixed MILKYMIST_TMU2 to only apply to MILKYMIST (patch 45) > new config symbol VIRTIO_INPUT_HOST > fixed select/depends for virtio (patch 48) > moved some ACPI dependencies from board to devices (patch 51) > > Paolo Bonzini (27): > arm: disable CONFIG_SERIAL_ISA > ide: split ioport registration to a separate file > vfio: move conditional up to hw/Makefile.objs > build: actually use CONFIG_PAM > hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards > hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices > hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller > hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI > minikconfig: add parser skeleton > minikconfig: add AST > minikconfig: add semantic analysis > kconfig: introduce kconfig files > build: switch to Kconfig > minikconf: implement allnoconfig and defconfig > ide: express dependencies with Kconfig > build: convert pci.mak to Kconfig > build: convert sound.mak to Kconfig > build: convert usb.mak to Kconfig > scsi: express dependencies with Kconfig > isa: express dependencies with kconfig > i386: express dependencies with Kconfig > i2c: express dependencies with Kconfig > ptimer: express dependencies with Kconfig > vfio: express vfio dependencies with Kconfig > tpm: express dependencies with Kconfig > isa: express SuperIO dependencies with Kconfig > kconfig: introduce CONFIG_TEST_DEVICES > > Yang Zhong (17): > hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS > hw/arm/Makefile.objs: CONFIG_VIRT created for virt board > hw/nios2/Makefile.objs: Conditionally build nios2 > hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards > hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64 > hw/alpha/Makefile.objs: Create CONFIG_* for alpha > hw/cris/Makefile.objs: Create CONFIG_* for cris > hw/hppa/Makefile.objs: Create CONFIG_* for hppa > hw/moxie/Makefile.objs: Conditionally build moxie > hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc > hw/tricore/Makefile.objs: Create CONFIG_* for tricore > hw/display: make edid configurable > hw/pci/Makefile.objs: make pcie configurable > display: express dependencies with kconfig > hyperv: express dependencies with kconfig > virtio: express virtio dependencies with Kconfig > i386-softmmu.mak: remove all CONFIG_* except boards definitions > > Ákos Kovács (8): > hw/m68k/Makefile.objs: Conditionally build boards > hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx > boards > hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards > hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_* > hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards > and device > hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created > hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst > hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga > conditionally > > Kconfig.host | 24 ++ > Makefile | 27 +- > Makefile.target | 7 +- > configure | 3 + > default-configs/alpha-softmmu.mak | 14 +- > default-configs/arm-softmmu.mak | 16 +- > default-configs/cris-softmmu.mak | 2 +- > default-configs/hppa-softmmu.mak | 6 +- > default-configs/hyperv.mak | 2 - > default-configs/i386-softmmu.mak | 77 +--- > default-configs/lm32-softmmu.mak | 2 - > default-configs/m68k-softmmu.mak | 3 +- > default-configs/microblaze-softmmu.mak | 4 +- > default-configs/mips-softmmu-common.mak | 13 +- > default-configs/mips64el-softmmu.mak | 3 +- > default-configs/moxie-softmmu.mak | 1 + > default-configs/nios2-softmmu.mak | 2 +- > default-configs/or1k-softmmu.mak | 1 + > default-configs/pci.mak | 49 --- > default-configs/ppc-softmmu.mak | 28 +- > default-configs/ppc64-softmmu.mak | 5 - > default-configs/riscv32-softmmu.mak | 15 +- > default-configs/riscv64-softmmu.mak | 15 +- > default-configs/s390x-softmmu.mak | 9 +- > default-configs/sh4-softmmu.mak | 17 +- > default-configs/sh4eb-softmmu.mak | 15 +- > default-configs/sound.mak | 4 - > default-configs/sparc-softmmu.mak | 3 +- > default-configs/sparc64-softmmu.mak | 9 +- > default-configs/tricore-softmmu.mak | 1 + > default-configs/unicore32-softmmu.mak | 1 - > default-configs/usb.mak | 11 - > default-configs/virtio.mak | 15 - > default-configs/xtensa-softmmu.mak | 3 + > default-configs/xtensaeb-softmmu.mak | 3 + > docs/devel/build-system.txt | 1 - > hw/9pfs/Kconfig | 6 + > hw/Kconfig | 73 ++++ > hw/Makefile.objs | 4 +- > hw/acpi/Kconfig | 29 ++ > hw/adc/Kconfig | 2 + > hw/alpha/Kconfig | 2 + > hw/alpha/Makefile.objs | 2 +- > hw/arm/Kconfig | 117 ++++++ > hw/arm/Makefile.objs | 3 +- > hw/audio/Kconfig | 52 +++ > hw/block/Kconfig | 38 ++ > hw/bt/Kconfig | 2 + > hw/char/Kconfig | 42 ++ > hw/core/Kconfig | 11 + > hw/cpu/Kconfig | 8 + > hw/cris/Kconfig | 6 + > hw/cris/Makefile.objs | 2 +- > hw/display/Kconfig | 107 +++++ > hw/display/Makefile.objs | 4 +- > hw/dma/Kconfig | 21 + > hw/gpio/Kconfig | 9 + > hw/hppa/Kconfig | 5 + > hw/hppa/Makefile.objs | 2 +- > hw/hyperv/Kconfig | 9 + > hw/i2c/Kconfig | 27 ++ > hw/i2c/Makefile.objs | 7 +- > hw/i386/Kconfig | 88 ++++ > hw/i386/Makefile.objs | 4 +- > hw/ide/Kconfig | 54 +++ > hw/ide/Makefile.objs | 6 +- > hw/ide/core.c | 25 -- > hw/ide/ioport.c | 67 ++++ > hw/input/Kconfig | 33 ++ > hw/intc/Kconfig | 59 +++ > hw/ipack/Kconfig | 4 + > hw/ipmi/Kconfig | 22 + > hw/isa/Kconfig | 53 +++ > hw/lm32/Kconfig | 7 + > hw/lm32/Makefile.objs | 4 +- > hw/m68k/Kconfig | 10 + > hw/m68k/Makefile.objs | 4 +- > hw/mem/Kconfig | 10 + > hw/microblaze/Kconfig | 8 + > hw/microblaze/Makefile.objs | 6 +- > hw/mips/Kconfig | 21 + > hw/mips/Makefile.objs | 5 +- > hw/misc/Kconfig | 112 ++++++ > hw/misc/macio/Kconfig | 11 + > hw/moxie/Kconfig | 2 + > hw/moxie/Makefile.objs | 2 +- > hw/net/Kconfig | 122 ++++++ > hw/net/Makefile.objs | 4 +- > hw/nios2/Kconfig | 5 + > hw/nios2/Makefile.objs | 3 +- > hw/nvram/Kconfig | 8 + > hw/openrisc/Kconfig | 2 + > hw/openrisc/Makefile.objs | 2 +- > hw/pci-bridge/Kconfig | 29 ++ > hw/pci-host/Kconfig | 49 +++ > hw/pci-host/Makefile.objs | 10 +- > hw/pci/Kconfig | 9 + > hw/pci/Makefile.objs | 9 +- > hw/pcmcia/Kconfig | 2 + > hw/ppc/Kconfig | 60 +++ > hw/ppc/Makefile.objs | 11 +- > hw/riscv/Kconfig | 19 + > hw/riscv/Makefile.objs | 22 +- > hw/s390x/Kconfig | 2 + > hw/s390x/Makefile.objs | 2 + > hw/scsi/Kconfig | 54 +++ > hw/scsi/Makefile.objs | 2 +- > hw/sd/Kconfig | 14 + > hw/sh4/Kconfig | 12 + > hw/sh4/Makefile.objs | 4 +- > hw/smbios/Kconfig | 2 + > hw/sparc/Kconfig | 13 + > hw/sparc/Makefile.objs | 4 +- > hw/sparc64/Kconfig | 6 + > hw/sparc64/Makefile.objs | 6 +- > hw/ssi/Kconfig | 14 + > hw/timer/Kconfig | 63 +++ > hw/tpm/Kconfig | 27 ++ > hw/tricore/Kconfig | 2 + > hw/tricore/Makefile.objs | 2 +- > hw/unicore32/Kconfig | 3 + > hw/usb/Kconfig | 91 +++++ > hw/vfio/Kconfig | 36 ++ > hw/vfio/Makefile.objs | 9 +- > hw/virtio/Kconfig | 27 ++ > hw/watchdog/Kconfig | 16 + > hw/xtensa/Kconfig | 5 + > hw/xtensa/Makefile.objs | 4 +- > rules.mak | 2 +- > scripts/make_device_config.sh | 30 -- > scripts/minikconf.py | 687 ++++++++++++++++++++++++++++++++ > 131 files changed, 2749 insertions(+), 374 deletions(-) > create mode 100644 Kconfig.host > delete mode 100644 default-configs/hyperv.mak > delete mode 100644 default-configs/pci.mak > delete mode 100644 default-configs/sound.mak > delete mode 100644 default-configs/usb.mak > delete mode 100644 default-configs/virtio.mak > create mode 100644 hw/9pfs/Kconfig > create mode 100644 hw/Kconfig > create mode 100644 hw/acpi/Kconfig > create mode 100644 hw/adc/Kconfig > create mode 100644 hw/alpha/Kconfig > create mode 100644 hw/arm/Kconfig > create mode 100644 hw/audio/Kconfig > create mode 100644 hw/block/Kconfig > create mode 100644 hw/bt/Kconfig > create mode 100644 hw/char/Kconfig > create mode 100644 hw/core/Kconfig > create mode 100644 hw/cpu/Kconfig > create mode 100644 hw/cris/Kconfig > create mode 100644 hw/display/Kconfig > create mode 100644 hw/dma/Kconfig > create mode 100644 hw/gpio/Kconfig > create mode 100644 hw/hppa/Kconfig > create mode 100644 hw/hyperv/Kconfig > create mode 100644 hw/i2c/Kconfig > create mode 100644 hw/i386/Kconfig > create mode 100644 hw/ide/Kconfig > create mode 100644 hw/ide/ioport.c > create mode 100644 hw/input/Kconfig > create mode 100644 hw/intc/Kconfig > create mode 100644 hw/ipack/Kconfig > create mode 100644 hw/ipmi/Kconfig > create mode 100644 hw/isa/Kconfig > create mode 100644 hw/lm32/Kconfig > create mode 100644 hw/m68k/Kconfig > create mode 100644 hw/mem/Kconfig > create mode 100644 hw/microblaze/Kconfig > create mode 100644 hw/mips/Kconfig > create mode 100644 hw/misc/Kconfig > create mode 100644 hw/misc/macio/Kconfig > create mode 100644 hw/moxie/Kconfig > create mode 100644 hw/net/Kconfig > create mode 100644 hw/nios2/Kconfig > create mode 100644 hw/nvram/Kconfig > create mode 100644 hw/openrisc/Kconfig > create mode 100644 hw/pci-bridge/Kconfig > create mode 100644 hw/pci-host/Kconfig > create mode 100644 hw/pci/Kconfig > create mode 100644 hw/pcmcia/Kconfig > create mode 100644 hw/ppc/Kconfig > create mode 100644 hw/riscv/Kconfig > create mode 100644 hw/s390x/Kconfig > create mode 100644 hw/scsi/Kconfig > create mode 100644 hw/sd/Kconfig > create mode 100644 hw/sh4/Kconfig > create mode 100644 hw/smbios/Kconfig > create mode 100644 hw/sparc/Kconfig > create mode 100644 hw/sparc64/Kconfig > create mode 100644 hw/ssi/Kconfig > create mode 100644 hw/timer/Kconfig > create mode 100644 hw/tpm/Kconfig > create mode 100644 hw/tricore/Kconfig > create mode 100644 hw/unicore32/Kconfig > create mode 100644 hw/usb/Kconfig > create mode 100644 hw/vfio/Kconfig > create mode 100644 hw/virtio/Kconfig > create mode 100644 hw/watchdog/Kconfig > create mode 100644 hw/xtensa/Kconfig > delete mode 100644 scripts/make_device_config.sh > create mode 100644 scripts/minikconf.py > > -- > 1.8.3.1
Patchew URL: https://patchew.org/QEMU/1548410831-19553-1-git-send-email-pbonzini@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU
Type: series
Message-id: 1548410831-19553-1-git-send-email-pbonzini@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
dbc584d8e4 kconfig: introduce CONFIG_TEST_DEVICES
8152c3cdcd i386-softmmu.mak: remove all CONFIG_* except boards definitions
9125dc81b3 isa: express SuperIO dependencies with Kconfig
d5069fb84d tpm: express dependencies with Kconfig
95cedf00b5 virtio: express virtio dependencies with Kconfig
c08aa5bf58 vfio: express vfio dependencies with Kconfig
fd1c33aa2b hyperv: express dependencies with kconfig
113498fae7 display: express dependencies with kconfig
a8e13fa63b ptimer: express dependencies with Kconfig
a1bc5ac825 i2c: express dependencies with Kconfig
77fbb8a4f9 i386: express dependencies with Kconfig
15f86dff14 isa: express dependencies with kconfig
07a5dd70ec scsi: express dependencies with Kconfig
e3be0ba561 build: convert usb.mak to Kconfig
289f8ee6eb build: convert sound.mak to Kconfig
cc9459f304 build: convert pci.mak to Kconfig
e9e0f95878 hw/pci/Makefile.objs: make pcie configurable
cb484d2faa ide: express dependencies with Kconfig
34ef087788 minikconf: implement allnoconfig and defconfig
6d20af9496 build: switch to Kconfig
633d26b675 kconfig: introduce kconfig files
6894a6f9ac hw/display: make edid configurable
545dfba6e3 minikconfig: add semantic analysis
3f7644c209 minikconfig: add AST
019214c143 minikconfig: add parser skeleton
471f15950f hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI
f73711c181 hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller
6d368d08e3 hw/tricore/Makefile.objs: Create CONFIG_* for tricore
0ffeea9e1d hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc
3bb75e756c hw/moxie/Makefile.objs: Conditionally build moxie
9254086f91 hw/hppa/Makefile.objs: Create CONFIG_* for hppa
48afb37c92 hw/cris/Makefile.objs: Create CONFIG_* for cris
5e20c54774 hw/alpha/Makefile.objs: Create CONFIG_* for alpha
166db688d0 hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64
901c168998 hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards
dfad8241eb hw/nios2/Makefile.objs: Conditionally build nios2
18a4fba2fa hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally
7a747835ae hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst
d9c2d7c8c5 hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created
4f9987bbfa hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices
dae7848cc4 hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device
d89b1b3045 hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*
18c42d91d1 hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards
a6753004dc hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards
70e6a3881f hw/m68k/Makefile.objs: Conditionally build boards
89445f8a5c hw/arm/Makefile.objs: CONFIG_VIRT created for virt board
074cee383c hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards
562fe684db build: actually use CONFIG_PAM
af189a2289 hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS
144835aff2 vfio: move conditional up to hw/Makefile.objs
8318087cea ide: split ioport registration to a separate file
f0334c7173 arm: disable CONFIG_SERIAL_ISA
=== OUTPUT BEGIN ===
1/52 Checking commit f0334c717327 (arm: disable CONFIG_SERIAL_ISA)
2/52 Checking commit 8318087ceaae (ide: split ioport registration to a separate file)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#71:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#132: FILE: hw/ide/ioport.c:57:
+ /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA
WARNING: Block comments use * on subsequent lines
#133: FILE: hw/ide/ioport.c:58:
+ /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA
+ bridge has been setup properly to always register with ISA. */
WARNING: Block comments use a trailing */ on a separate line
#133: FILE: hw/ide/ioport.c:58:
+ bridge has been setup properly to always register with ISA. */
total: 0 errors, 4 warnings, 113 lines checked
Patch 2/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/52 Checking commit 144835aff233 (vfio: move conditional up to hw/Makefile.objs)
4/52 Checking commit af189a22894e (hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS)
5/52 Checking commit 562fe684db9d (build: actually use CONFIG_PAM)
6/52 Checking commit 074cee383cdd (hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards)
7/52 Checking commit 89445f8a5c91 (hw/arm/Makefile.objs: CONFIG_VIRT created for virt board)
8/52 Checking commit 70e6a3881fa2 (hw/m68k/Makefile.objs: Conditionally build boards)
9/52 Checking commit a6753004dcac (hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards)
10/52 Checking commit 18c42d91d100 (hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards)
11/52 Checking commit d89b1b3045d9 (hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*)
12/52 Checking commit dae7848cc4c2 (hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device)
13/52 Checking commit 4f9987bbfa0f (hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices)
14/52 Checking commit d9c2d7c8c5b8 (hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created)
15/52 Checking commit 7a747835ae3a (hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst)
16/52 Checking commit 18a4fba2fae2 (hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally)
17/52 Checking commit dfad8241eb23 (hw/nios2/Makefile.objs: Conditionally build nios2)
18/52 Checking commit 901c168998a7 (hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards)
19/52 Checking commit 166db688d08e (hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64)
20/52 Checking commit 5e20c547748d (hw/alpha/Makefile.objs: Create CONFIG_* for alpha)
21/52 Checking commit 48afb37c926a (hw/cris/Makefile.objs: Create CONFIG_* for cris)
22/52 Checking commit 9254086f9151 (hw/hppa/Makefile.objs: Create CONFIG_* for hppa)
23/52 Checking commit 3bb75e756cee (hw/moxie/Makefile.objs: Conditionally build moxie)
24/52 Checking commit 0ffeea9e1dd8 (hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc)
25/52 Checking commit 6d368d08e36a (hw/tricore/Makefile.objs: Create CONFIG_* for tricore)
26/52 Checking commit f73711c18197 (hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller)
27/52 Checking commit 471f15950f23 (hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI)
28/52 Checking commit 019214c143ad (minikconfig: add parser skeleton)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35:
new file mode 100644
WARNING: line over 80 characters
#251: FILE: scripts/minikconf.py:212:
+ 'Expected identifier starting with "CONFIG_"', TOK_NONE)
WARNING: line over 80 characters
#344: FILE: scripts/minikconf.py:305:
+ raise KconfigParserError(self, 'expected "source", "config", identifier, '
WARNING: line over 80 characters
#370: FILE: scripts/minikconf.py:331:
+ raise KconfigParserError(self, 'expected "source", "config" or identifier')
ERROR: line over 90 characters
#395: FILE: scripts/minikconf.py:356:
+ if self.src[self.cursor + length].isalnum() or self.src[self.cursor + length] == '|':
WARNING: line over 80 characters
#448: FILE: scripts/minikconf.py:409:
+ while self.src[self.cursor].isalnum() or self.src[self.cursor] == '_':
total: 1 errors, 5 warnings, 425 lines checked
Patch 28/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/52 Checking commit 3f7644c20919 (minikconfig: add AST)
WARNING: line over 80 characters
#89: FILE: scripts/minikconf.py:86:
+ return "config %s default %s if %s" % (self.dest, value, self.cond)
total: 0 errors, 1 warnings, 170 lines checked
Patch 29/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/52 Checking commit 545dfba6e34b (minikconfig: add semantic analysis)
WARNING: line over 80 characters
#112: FILE: scripts/minikconf.py:102:
+ raise Exception('contradiction between clauses when setting %s' % self)
WARNING: line over 80 characters
#215: FILE: scripts/minikconf.py:214:
+ debug_print(i, "->", [str(x) for x in self.referenced_vars[i].outgoing])
total: 0 errors, 2 warnings, 223 lines checked
Patch 30/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/52 Checking commit 6894a6f9ac98 (hw/display: make edid configurable)
32/52 Checking commit 633d26b67534 (kconfig: introduce kconfig files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44:
new file mode 100644
WARNING: line over 80 characters
#1762: FILE: scripts/minikconf.py:636:
+ print ("%s: at least one argument is required" % argv[0], file=sys.stderr)
total: 0 errors, 2 warnings, 1363 lines checked
Patch 32/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/52 Checking commit 6d20af9496e7 (build: switch to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#481:
deleted file mode 100644
total: 0 errors, 1 warnings, 325 lines checked
Patch 33/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/52 Checking commit 34ef0877882f (minikconf: implement allnoconfig and defconfig)
35/52 Checking commit cb484d2faa02 (ide: express dependencies with Kconfig)
36/52 Checking commit e9e0f95878f9 (hw/pci/Makefile.objs: make pcie configurable)
37/52 Checking commit cc9459f304c7 (build: convert pci.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#120:
deleted file mode 100644
total: 0 errors, 1 warnings, 472 lines checked
Patch 37/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
38/52 Checking commit 289f8ee6ebea (build: convert sound.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#70:
deleted file mode 100644
total: 0 errors, 1 warnings, 51 lines checked
Patch 38/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
39/52 Checking commit e3be0ba56197 (build: convert usb.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#158:
deleted file mode 100644
total: 0 errors, 1 warnings, 157 lines checked
Patch 39/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
40/52 Checking commit 07a5dd70ec98 (scsi: express dependencies with Kconfig)
41/52 Checking commit 15f86dff14a3 (isa: express dependencies with kconfig)
42/52 Checking commit 77fbb8a4f9a3 (i386: express dependencies with Kconfig)
43/52 Checking commit a1bc5ac825b6 (i2c: express dependencies with Kconfig)
44/52 Checking commit a8e13fa63b07 (ptimer: express dependencies with Kconfig)
45/52 Checking commit 113498fae707 (display: express dependencies with kconfig)
46/52 Checking commit fd1c33aa2b65 (hyperv: express dependencies with kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
deleted file mode 100644
total: 0 errors, 1 warnings, 15 lines checked
Patch 46/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
47/52 Checking commit c08aa5bf58f4 (vfio: express vfio dependencies with Kconfig)
48/52 Checking commit 95cedf00b5f9 (virtio: express virtio dependencies with Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37:
deleted file mode 100644
total: 0 errors, 1 warnings, 109 lines checked
Patch 48/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
49/52 Checking commit d5069fb84d2c (tpm: express dependencies with Kconfig)
50/52 Checking commit 9125dc81b384 (isa: express SuperIO dependencies with Kconfig)
51/52 Checking commit 8152c3cdcd36 (i386-softmmu.mak: remove all CONFIG_* except boards definitions)
52/52 Checking commit dbc584d8e473 (kconfig: introduce CONFIG_TEST_DEVICES)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1548410831-19553-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1548410831-19553-1-git-send-email-pbonzini@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU
Type: series
Message-id: 1548410831-19553-1-git-send-email-pbonzini@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/1548410831-19553-1-git-send-email-pbonzini@redhat.com -> patchew/1548410831-19553-1-git-send-email-pbonzini@redhat.com
Switched to a new branch 'test'
12539e4899 kconfig: introduce CONFIG_TEST_DEVICES
2fadac69d9 i386-softmmu.mak: remove all CONFIG_* except boards definitions
8c1fb84ff4 isa: express SuperIO dependencies with Kconfig
8e3174384e tpm: express dependencies with Kconfig
7ffb3fa21b virtio: express virtio dependencies with Kconfig
5a72a0c385 vfio: express vfio dependencies with Kconfig
a597633380 hyperv: express dependencies with kconfig
1ef5cc5fb7 display: express dependencies with kconfig
fdd2c128b7 ptimer: express dependencies with Kconfig
fdf78be1f4 i2c: express dependencies with Kconfig
9b937662f4 i386: express dependencies with Kconfig
583608364d isa: express dependencies with kconfig
7a26eaae95 scsi: express dependencies with Kconfig
74950a85f9 build: convert usb.mak to Kconfig
069934d3cb build: convert sound.mak to Kconfig
5d186272f9 build: convert pci.mak to Kconfig
f08f56a670 hw/pci/Makefile.objs: make pcie configurable
f4642a7c62 ide: express dependencies with Kconfig
5a452a1fc1 minikconf: implement allnoconfig and defconfig
8aa73695da build: switch to Kconfig
26b1ac2c0b kconfig: introduce kconfig files
c4119d6e81 hw/display: make edid configurable
9a6e43617c minikconfig: add semantic analysis
afcf405ac2 minikconfig: add AST
2f64711b7c minikconfig: add parser skeleton
18ac9b6814 hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI
5e30d1f03e hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller
8254b1b5e1 hw/tricore/Makefile.objs: Create CONFIG_* for tricore
150eb60214 hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc
b1fe09618b hw/moxie/Makefile.objs: Conditionally build moxie
baf0d866cb hw/hppa/Makefile.objs: Create CONFIG_* for hppa
13aa0274be hw/cris/Makefile.objs: Create CONFIG_* for cris
1098821e31 hw/alpha/Makefile.objs: Create CONFIG_* for alpha
aa55c758c4 hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64
3d4876ad59 hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards
c2ce7cf461 hw/nios2/Makefile.objs: Conditionally build nios2
60bf62c31c hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally
6a9dfa037f hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst
e341e43ea7 hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created
c02d4cdf59 hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices
d90d4f8bb0 hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device
aa9c376735 hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*
4feddc17c4 hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards
d681b512df hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards
8a86443748 hw/m68k/Makefile.objs: Conditionally build boards
9321f38d4c hw/arm/Makefile.objs: CONFIG_VIRT created for virt board
67293f7ac0 hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards
a2f1b83828 build: actually use CONFIG_PAM
48ca0b0bb0 hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS
f9385aff8c vfio: move conditional up to hw/Makefile.objs
3c1f0c425e ide: split ioport registration to a separate file
de15bc290e arm: disable CONFIG_SERIAL_ISA
=== OUTPUT BEGIN ===
1/52 Checking commit de15bc290e9c (arm: disable CONFIG_SERIAL_ISA)
2/52 Checking commit 3c1f0c425e86 (ide: split ioport registration to a separate file)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#71:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#132: FILE: hw/ide/ioport.c:57:
+ /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA
WARNING: Block comments use * on subsequent lines
#133: FILE: hw/ide/ioport.c:58:
+ /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA
+ bridge has been setup properly to always register with ISA. */
WARNING: Block comments use a trailing */ on a separate line
#133: FILE: hw/ide/ioport.c:58:
+ bridge has been setup properly to always register with ISA. */
total: 0 errors, 4 warnings, 113 lines checked
Patch 2/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/52 Checking commit f9385aff8c74 (vfio: move conditional up to hw/Makefile.objs)
4/52 Checking commit 48ca0b0bb040 (hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS)
5/52 Checking commit a2f1b8382880 (build: actually use CONFIG_PAM)
6/52 Checking commit 67293f7ac014 (hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards)
7/52 Checking commit 9321f38d4c1c (hw/arm/Makefile.objs: CONFIG_VIRT created for virt board)
8/52 Checking commit 8a86443748e8 (hw/m68k/Makefile.objs: Conditionally build boards)
9/52 Checking commit d681b512df03 (hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards)
10/52 Checking commit 4feddc17c458 (hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards)
11/52 Checking commit aa9c37673515 (hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*)
12/52 Checking commit d90d4f8bb07b (hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device)
13/52 Checking commit c02d4cdf59cc (hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices)
14/52 Checking commit e341e43ea749 (hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created)
15/52 Checking commit 6a9dfa037fad (hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst)
16/52 Checking commit 60bf62c31c54 (hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally)
17/52 Checking commit c2ce7cf4611e (hw/nios2/Makefile.objs: Conditionally build nios2)
18/52 Checking commit 3d4876ad59dc (hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards)
19/52 Checking commit aa55c758c409 (hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64)
20/52 Checking commit 1098821e3116 (hw/alpha/Makefile.objs: Create CONFIG_* for alpha)
21/52 Checking commit 13aa0274be57 (hw/cris/Makefile.objs: Create CONFIG_* for cris)
22/52 Checking commit baf0d866cbf9 (hw/hppa/Makefile.objs: Create CONFIG_* for hppa)
23/52 Checking commit b1fe09618bfe (hw/moxie/Makefile.objs: Conditionally build moxie)
24/52 Checking commit 150eb6021400 (hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc)
25/52 Checking commit 8254b1b5e1aa (hw/tricore/Makefile.objs: Create CONFIG_* for tricore)
26/52 Checking commit 5e30d1f03e84 (hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller)
27/52 Checking commit 18ac9b68146f (hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI)
28/52 Checking commit 2f64711b7cbc (minikconfig: add parser skeleton)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35:
new file mode 100644
WARNING: line over 80 characters
#251: FILE: scripts/minikconf.py:212:
+ 'Expected identifier starting with "CONFIG_"', TOK_NONE)
WARNING: line over 80 characters
#344: FILE: scripts/minikconf.py:305:
+ raise KconfigParserError(self, 'expected "source", "config", identifier, '
WARNING: line over 80 characters
#370: FILE: scripts/minikconf.py:331:
+ raise KconfigParserError(self, 'expected "source", "config" or identifier')
ERROR: line over 90 characters
#395: FILE: scripts/minikconf.py:356:
+ if self.src[self.cursor + length].isalnum() or self.src[self.cursor + length] == '|':
WARNING: line over 80 characters
#448: FILE: scripts/minikconf.py:409:
+ while self.src[self.cursor].isalnum() or self.src[self.cursor] == '_':
total: 1 errors, 5 warnings, 425 lines checked
Patch 28/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/52 Checking commit afcf405ac260 (minikconfig: add AST)
WARNING: line over 80 characters
#89: FILE: scripts/minikconf.py:86:
+ return "config %s default %s if %s" % (self.dest, value, self.cond)
total: 0 errors, 1 warnings, 170 lines checked
Patch 29/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/52 Checking commit 9a6e43617ce7 (minikconfig: add semantic analysis)
WARNING: line over 80 characters
#112: FILE: scripts/minikconf.py:102:
+ raise Exception('contradiction between clauses when setting %s' % self)
WARNING: line over 80 characters
#215: FILE: scripts/minikconf.py:214:
+ debug_print(i, "->", [str(x) for x in self.referenced_vars[i].outgoing])
total: 0 errors, 2 warnings, 223 lines checked
Patch 30/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/52 Checking commit c4119d6e81ce (hw/display: make edid configurable)
32/52 Checking commit 26b1ac2c0b73 (kconfig: introduce kconfig files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44:
new file mode 100644
WARNING: line over 80 characters
#1762: FILE: scripts/minikconf.py:636:
+ print ("%s: at least one argument is required" % argv[0], file=sys.stderr)
total: 0 errors, 2 warnings, 1363 lines checked
Patch 32/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/52 Checking commit 8aa73695da7a (build: switch to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#481:
deleted file mode 100644
total: 0 errors, 1 warnings, 325 lines checked
Patch 33/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/52 Checking commit 5a452a1fc119 (minikconf: implement allnoconfig and defconfig)
35/52 Checking commit f4642a7c62b2 (ide: express dependencies with Kconfig)
36/52 Checking commit f08f56a670ae (hw/pci/Makefile.objs: make pcie configurable)
37/52 Checking commit 5d186272f909 (build: convert pci.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#120:
deleted file mode 100644
total: 0 errors, 1 warnings, 472 lines checked
Patch 37/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
38/52 Checking commit 069934d3cb35 (build: convert sound.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#70:
deleted file mode 100644
total: 0 errors, 1 warnings, 51 lines checked
Patch 38/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
39/52 Checking commit 74950a85f9f2 (build: convert usb.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#158:
deleted file mode 100644
total: 0 errors, 1 warnings, 157 lines checked
Patch 39/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
40/52 Checking commit 7a26eaae9594 (scsi: express dependencies with Kconfig)
41/52 Checking commit 583608364d1c (isa: express dependencies with kconfig)
42/52 Checking commit 9b937662f4e1 (i386: express dependencies with Kconfig)
43/52 Checking commit fdf78be1f429 (i2c: express dependencies with Kconfig)
44/52 Checking commit fdd2c128b788 (ptimer: express dependencies with Kconfig)
45/52 Checking commit 1ef5cc5fb73b (display: express dependencies with kconfig)
46/52 Checking commit a59763338008 (hyperv: express dependencies with kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
deleted file mode 100644
total: 0 errors, 1 warnings, 15 lines checked
Patch 46/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
47/52 Checking commit 5a72a0c385fc (vfio: express vfio dependencies with Kconfig)
48/52 Checking commit 7ffb3fa21b40 (virtio: express virtio dependencies with Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37:
deleted file mode 100644
total: 0 errors, 1 warnings, 109 lines checked
Patch 48/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
49/52 Checking commit 8e3174384e2b (tpm: express dependencies with Kconfig)
50/52 Checking commit 8c1fb84ff49b (isa: express SuperIO dependencies with Kconfig)
51/52 Checking commit 2fadac69d98b (i386-softmmu.mak: remove all CONFIG_* except boards definitions)
52/52 Checking commit 12539e489992 (kconfig: introduce CONFIG_TEST_DEVICES)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1548410831-19553-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1548410831-19553-1-git-send-email-pbonzini@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1548410831-19553-1-git-send-email-pbonzini@redhat.com
Subject: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/1548410831-19553-1-git-send-email-pbonzini@redhat.com -> patchew/1548410831-19553-1-git-send-email-pbonzini@redhat.com
Switched to a new branch 'test'
12539e4 kconfig: introduce CONFIG_TEST_DEVICES
2fadac6 i386-softmmu.mak: remove all CONFIG_* except boards definitions
8c1fb84 isa: express SuperIO dependencies with Kconfig
8e31743 tpm: express dependencies with Kconfig
7ffb3fa virtio: express virtio dependencies with Kconfig
5a72a0c vfio: express vfio dependencies with Kconfig
a597633 hyperv: express dependencies with kconfig
1ef5cc5 display: express dependencies with kconfig
fdd2c12 ptimer: express dependencies with Kconfig
fdf78be i2c: express dependencies with Kconfig
9b93766 i386: express dependencies with Kconfig
5836083 isa: express dependencies with kconfig
7a26eaa scsi: express dependencies with Kconfig
74950a8 build: convert usb.mak to Kconfig
069934d build: convert sound.mak to Kconfig
5d18627 build: convert pci.mak to Kconfig
f08f56a hw/pci/Makefile.objs: make pcie configurable
f4642a7 ide: express dependencies with Kconfig
5a452a1 minikconf: implement allnoconfig and defconfig
8aa7369 build: switch to Kconfig
26b1ac2 kconfig: introduce kconfig files
c4119d6 hw/display: make edid configurable
9a6e436 minikconfig: add semantic analysis
afcf405 minikconfig: add AST
2f64711 minikconfig: add parser skeleton
18ac9b6 hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI
5e30d1f hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller
8254b1b hw/tricore/Makefile.objs: Create CONFIG_* for tricore
150eb60 hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc
b1fe096 hw/moxie/Makefile.objs: Conditionally build moxie
baf0d86 hw/hppa/Makefile.objs: Create CONFIG_* for hppa
13aa027 hw/cris/Makefile.objs: Create CONFIG_* for cris
1098821 hw/alpha/Makefile.objs: Create CONFIG_* for alpha
aa55c75 hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64
3d4876a hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards
c2ce7cf hw/nios2/Makefile.objs: Conditionally build nios2
60bf62c hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally
6a9dfa0 hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst
e341e43 hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created
c02d4cd hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices
d90d4f8 hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device
aa9c376 hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*
4feddc1 hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards
d681b51 hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards
8a86443 hw/m68k/Makefile.objs: Conditionally build boards
9321f38 hw/arm/Makefile.objs: CONFIG_VIRT created for virt board
67293f7 hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards
a2f1b83 build: actually use CONFIG_PAM
48ca0b0 hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS
f9385af vfio: move conditional up to hw/Makefile.objs
3c1f0c4 ide: split ioport registration to a separate file
de15bc2 arm: disable CONFIG_SERIAL_ISA
=== OUTPUT BEGIN ===
1/52 Checking commit de15bc290e9c (arm: disable CONFIG_SERIAL_ISA)
2/52 Checking commit 3c1f0c425e86 (ide: split ioport registration to a separate file)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#71:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#132: FILE: hw/ide/ioport.c:57:
+ /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA
WARNING: Block comments use * on subsequent lines
#133: FILE: hw/ide/ioport.c:58:
+ /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA
+ bridge has been setup properly to always register with ISA. */
WARNING: Block comments use a trailing */ on a separate line
#133: FILE: hw/ide/ioport.c:58:
+ bridge has been setup properly to always register with ISA. */
total: 0 errors, 4 warnings, 113 lines checked
Patch 2/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/52 Checking commit f9385aff8c74 (vfio: move conditional up to hw/Makefile.objs)
4/52 Checking commit 48ca0b0bb040 (hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS)
5/52 Checking commit a2f1b8382880 (build: actually use CONFIG_PAM)
6/52 Checking commit 67293f7ac014 (hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards)
7/52 Checking commit 9321f38d4c1c (hw/arm/Makefile.objs: CONFIG_VIRT created for virt board)
8/52 Checking commit 8a86443748e8 (hw/m68k/Makefile.objs: Conditionally build boards)
9/52 Checking commit d681b512df03 (hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards)
10/52 Checking commit 4feddc17c458 (hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards)
11/52 Checking commit aa9c37673515 (hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*)
12/52 Checking commit d90d4f8bb07b (hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device)
13/52 Checking commit c02d4cdf59cc (hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices)
14/52 Checking commit e341e43ea749 (hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created)
15/52 Checking commit 6a9dfa037fad (hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst)
16/52 Checking commit 60bf62c31c54 (hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally)
17/52 Checking commit c2ce7cf4611e (hw/nios2/Makefile.objs: Conditionally build nios2)
18/52 Checking commit 3d4876ad59dc (hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards)
19/52 Checking commit aa55c758c409 (hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64)
20/52 Checking commit 1098821e3116 (hw/alpha/Makefile.objs: Create CONFIG_* for alpha)
21/52 Checking commit 13aa0274be57 (hw/cris/Makefile.objs: Create CONFIG_* for cris)
22/52 Checking commit baf0d866cbf9 (hw/hppa/Makefile.objs: Create CONFIG_* for hppa)
23/52 Checking commit b1fe09618bfe (hw/moxie/Makefile.objs: Conditionally build moxie)
24/52 Checking commit 150eb6021400 (hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc)
25/52 Checking commit 8254b1b5e1aa (hw/tricore/Makefile.objs: Create CONFIG_* for tricore)
26/52 Checking commit 5e30d1f03e84 (hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller)
27/52 Checking commit 18ac9b68146f (hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI)
28/52 Checking commit 2f64711b7cbc (minikconfig: add parser skeleton)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35:
new file mode 100644
WARNING: line over 80 characters
#251: FILE: scripts/minikconf.py:212:
+ 'Expected identifier starting with "CONFIG_"', TOK_NONE)
WARNING: line over 80 characters
#344: FILE: scripts/minikconf.py:305:
+ raise KconfigParserError(self, 'expected "source", "config", identifier, '
WARNING: line over 80 characters
#370: FILE: scripts/minikconf.py:331:
+ raise KconfigParserError(self, 'expected "source", "config" or identifier')
ERROR: line over 90 characters
#395: FILE: scripts/minikconf.py:356:
+ if self.src[self.cursor + length].isalnum() or self.src[self.cursor + length] == '|':
WARNING: line over 80 characters
#448: FILE: scripts/minikconf.py:409:
+ while self.src[self.cursor].isalnum() or self.src[self.cursor] == '_':
total: 1 errors, 5 warnings, 425 lines checked
Patch 28/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/52 Checking commit afcf405ac260 (minikconfig: add AST)
WARNING: line over 80 characters
#89: FILE: scripts/minikconf.py:86:
+ return "config %s default %s if %s" % (self.dest, value, self.cond)
total: 0 errors, 1 warnings, 170 lines checked
Patch 29/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/52 Checking commit 9a6e43617ce7 (minikconfig: add semantic analysis)
WARNING: line over 80 characters
#112: FILE: scripts/minikconf.py:102:
+ raise Exception('contradiction between clauses when setting %s' % self)
WARNING: line over 80 characters
#215: FILE: scripts/minikconf.py:214:
+ debug_print(i, "->", [str(x) for x in self.referenced_vars[i].outgoing])
total: 0 errors, 2 warnings, 223 lines checked
Patch 30/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/52 Checking commit c4119d6e81ce (hw/display: make edid configurable)
32/52 Checking commit 26b1ac2c0b73 (kconfig: introduce kconfig files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44:
new file mode 100644
WARNING: line over 80 characters
#1762: FILE: scripts/minikconf.py:636:
+ print ("%s: at least one argument is required" % argv[0], file=sys.stderr)
total: 0 errors, 2 warnings, 1363 lines checked
Patch 32/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/52 Checking commit 8aa73695da7a (build: switch to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#481:
deleted file mode 100644
total: 0 errors, 1 warnings, 325 lines checked
Patch 33/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/52 Checking commit 5a452a1fc119 (minikconf: implement allnoconfig and defconfig)
35/52 Checking commit f4642a7c62b2 (ide: express dependencies with Kconfig)
36/52 Checking commit f08f56a670ae (hw/pci/Makefile.objs: make pcie configurable)
37/52 Checking commit 5d186272f909 (build: convert pci.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#120:
deleted file mode 100644
total: 0 errors, 1 warnings, 472 lines checked
Patch 37/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
38/52 Checking commit 069934d3cb35 (build: convert sound.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#70:
deleted file mode 100644
total: 0 errors, 1 warnings, 51 lines checked
Patch 38/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
39/52 Checking commit 74950a85f9f2 (build: convert usb.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#158:
deleted file mode 100644
total: 0 errors, 1 warnings, 157 lines checked
Patch 39/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
40/52 Checking commit 7a26eaae9594 (scsi: express dependencies with Kconfig)
41/52 Checking commit 583608364d1c (isa: express dependencies with kconfig)
42/52 Checking commit 9b937662f4e1 (i386: express dependencies with Kconfig)
43/52 Checking commit fdf78be1f429 (i2c: express dependencies with Kconfig)
44/52 Checking commit fdd2c128b788 (ptimer: express dependencies with Kconfig)
45/52 Checking commit 1ef5cc5fb73b (display: express dependencies with kconfig)
46/52 Checking commit a59763338008 (hyperv: express dependencies with kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
deleted file mode 100644
total: 0 errors, 1 warnings, 15 lines checked
Patch 46/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
47/52 Checking commit 5a72a0c385fc (vfio: express vfio dependencies with Kconfig)
48/52 Checking commit 7ffb3fa21b40 (virtio: express virtio dependencies with Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37:
deleted file mode 100644
total: 0 errors, 1 warnings, 109 lines checked
Patch 48/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
49/52 Checking commit 8e3174384e2b (tpm: express dependencies with Kconfig)
50/52 Checking commit 8c1fb84ff49b (isa: express SuperIO dependencies with Kconfig)
51/52 Checking commit 2fadac69d98b (i386-softmmu.mak: remove all CONFIG_* except boards definitions)
52/52 Checking commit 12539e489992 (kconfig: introduce CONFIG_TEST_DEVICES)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1548410831-19553-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1548410831-19553-1-git-send-email-pbonzini@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU
Message-id: 1548410831-19553-1-git-send-email-pbonzini@redhat.com
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/1548410831-19553-1-git-send-email-pbonzini@redhat.com -> patchew/1548410831-19553-1-git-send-email-pbonzini@redhat.com
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out 'd4e7d7ac663fcb55f1b93575445fcbca372f17a7'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out '9b7ab2fa020341dee8bf9df6c9cf40003e0136df'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '441a84d3a642a10b948369c63f32367e8ff6395b'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
12539e4 kconfig: introduce CONFIG_TEST_DEVICES
2fadac6 i386-softmmu.mak: remove all CONFIG_* except boards definitions
8c1fb84 isa: express SuperIO dependencies with Kconfig
8e31743 tpm: express dependencies with Kconfig
7ffb3fa virtio: express virtio dependencies with Kconfig
5a72a0c vfio: express vfio dependencies with Kconfig
a597633 hyperv: express dependencies with kconfig
1ef5cc5 display: express dependencies with kconfig
fdd2c12 ptimer: express dependencies with Kconfig
fdf78be i2c: express dependencies with Kconfig
9b93766 i386: express dependencies with Kconfig
5836083 isa: express dependencies with kconfig
7a26eaa scsi: express dependencies with Kconfig
74950a8 build: convert usb.mak to Kconfig
069934d build: convert sound.mak to Kconfig
5d18627 build: convert pci.mak to Kconfig
f08f56a hw/pci/Makefile.objs: make pcie configurable
f4642a7 ide: express dependencies with Kconfig
5a452a1 minikconf: implement allnoconfig and defconfig
8aa7369 build: switch to Kconfig
26b1ac2 kconfig: introduce kconfig files
c4119d6 hw/display: make edid configurable
9a6e436 minikconfig: add semantic analysis
afcf405 minikconfig: add AST
2f64711 minikconfig: add parser skeleton
18ac9b6 hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI
5e30d1f hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller
8254b1b hw/tricore/Makefile.objs: Create CONFIG_* for tricore
150eb60 hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc
b1fe096 hw/moxie/Makefile.objs: Conditionally build moxie
baf0d86 hw/hppa/Makefile.objs: Create CONFIG_* for hppa
13aa027 hw/cris/Makefile.objs: Create CONFIG_* for cris
1098821 hw/alpha/Makefile.objs: Create CONFIG_* for alpha
aa55c75 hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64
3d4876a hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards
c2ce7cf hw/nios2/Makefile.objs: Conditionally build nios2
60bf62c hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally
6a9dfa0 hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst
e341e43 hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created
c02d4cd hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices
d90d4f8 hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device
aa9c376 hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*
4feddc1 hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards
d681b51 hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards
8a86443 hw/m68k/Makefile.objs: Conditionally build boards
9321f38 hw/arm/Makefile.objs: CONFIG_VIRT created for virt board
67293f7 hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards
a2f1b83 build: actually use CONFIG_PAM
48ca0b0 hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS
f9385af vfio: move conditional up to hw/Makefile.objs
3c1f0c4 ide: split ioport registration to a separate file
de15bc2 arm: disable CONFIG_SERIAL_ISA
=== OUTPUT BEGIN ===
1/52 Checking commit de15bc290e9c (arm: disable CONFIG_SERIAL_ISA)
2/52 Checking commit 3c1f0c425e86 (ide: split ioport registration to a separate file)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#71:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#132: FILE: hw/ide/ioport.c:57:
+ /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA
WARNING: Block comments use * on subsequent lines
#133: FILE: hw/ide/ioport.c:58:
+ /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA
+ bridge has been setup properly to always register with ISA. */
WARNING: Block comments use a trailing */ on a separate line
#133: FILE: hw/ide/ioport.c:58:
+ bridge has been setup properly to always register with ISA. */
total: 0 errors, 4 warnings, 113 lines checked
Patch 2/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/52 Checking commit f9385aff8c74 (vfio: move conditional up to hw/Makefile.objs)
4/52 Checking commit 48ca0b0bb040 (hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS)
5/52 Checking commit a2f1b8382880 (build: actually use CONFIG_PAM)
6/52 Checking commit 67293f7ac014 (hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards)
7/52 Checking commit 9321f38d4c1c (hw/arm/Makefile.objs: CONFIG_VIRT created for virt board)
8/52 Checking commit 8a86443748e8 (hw/m68k/Makefile.objs: Conditionally build boards)
9/52 Checking commit d681b512df03 (hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards)
10/52 Checking commit 4feddc17c458 (hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards)
11/52 Checking commit aa9c37673515 (hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*)
12/52 Checking commit d90d4f8bb07b (hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device)
13/52 Checking commit c02d4cdf59cc (hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices)
14/52 Checking commit e341e43ea749 (hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created)
15/52 Checking commit 6a9dfa037fad (hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst)
16/52 Checking commit 60bf62c31c54 (hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally)
17/52 Checking commit c2ce7cf4611e (hw/nios2/Makefile.objs: Conditionally build nios2)
18/52 Checking commit 3d4876ad59dc (hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards)
19/52 Checking commit aa55c758c409 (hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64)
20/52 Checking commit 1098821e3116 (hw/alpha/Makefile.objs: Create CONFIG_* for alpha)
21/52 Checking commit 13aa0274be57 (hw/cris/Makefile.objs: Create CONFIG_* for cris)
22/52 Checking commit baf0d866cbf9 (hw/hppa/Makefile.objs: Create CONFIG_* for hppa)
23/52 Checking commit b1fe09618bfe (hw/moxie/Makefile.objs: Conditionally build moxie)
24/52 Checking commit 150eb6021400 (hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc)
25/52 Checking commit 8254b1b5e1aa (hw/tricore/Makefile.objs: Create CONFIG_* for tricore)
26/52 Checking commit 5e30d1f03e84 (hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller)
27/52 Checking commit 18ac9b68146f (hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI)
28/52 Checking commit 2f64711b7cbc (minikconfig: add parser skeleton)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35:
new file mode 100644
WARNING: line over 80 characters
#251: FILE: scripts/minikconf.py:212:
+ 'Expected identifier starting with "CONFIG_"', TOK_NONE)
WARNING: line over 80 characters
#344: FILE: scripts/minikconf.py:305:
+ raise KconfigParserError(self, 'expected "source", "config", identifier, '
WARNING: line over 80 characters
#370: FILE: scripts/minikconf.py:331:
+ raise KconfigParserError(self, 'expected "source", "config" or identifier')
ERROR: line over 90 characters
#395: FILE: scripts/minikconf.py:356:
+ if self.src[self.cursor + length].isalnum() or self.src[self.cursor + length] == '|':
WARNING: line over 80 characters
#448: FILE: scripts/minikconf.py:409:
+ while self.src[self.cursor].isalnum() or self.src[self.cursor] == '_':
total: 1 errors, 5 warnings, 425 lines checked
Patch 28/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/52 Checking commit afcf405ac260 (minikconfig: add AST)
WARNING: line over 80 characters
#89: FILE: scripts/minikconf.py:86:
+ return "config %s default %s if %s" % (self.dest, value, self.cond)
total: 0 errors, 1 warnings, 170 lines checked
Patch 29/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/52 Checking commit 9a6e43617ce7 (minikconfig: add semantic analysis)
WARNING: line over 80 characters
#112: FILE: scripts/minikconf.py:102:
+ raise Exception('contradiction between clauses when setting %s' % self)
WARNING: line over 80 characters
#215: FILE: scripts/minikconf.py:214:
+ debug_print(i, "->", [str(x) for x in self.referenced_vars[i].outgoing])
total: 0 errors, 2 warnings, 223 lines checked
Patch 30/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/52 Checking commit c4119d6e81ce (hw/display: make edid configurable)
32/52 Checking commit 26b1ac2c0b73 (kconfig: introduce kconfig files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44:
new file mode 100644
WARNING: line over 80 characters
#1762: FILE: scripts/minikconf.py:636:
+ print ("%s: at least one argument is required" % argv[0], file=sys.stderr)
total: 0 errors, 2 warnings, 1363 lines checked
Patch 32/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/52 Checking commit 8aa73695da7a (build: switch to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#481:
deleted file mode 100644
total: 0 errors, 1 warnings, 325 lines checked
Patch 33/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/52 Checking commit 5a452a1fc119 (minikconf: implement allnoconfig and defconfig)
35/52 Checking commit f4642a7c62b2 (ide: express dependencies with Kconfig)
36/52 Checking commit f08f56a670ae (hw/pci/Makefile.objs: make pcie configurable)
37/52 Checking commit 5d186272f909 (build: convert pci.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#120:
deleted file mode 100644
total: 0 errors, 1 warnings, 472 lines checked
Patch 37/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
38/52 Checking commit 069934d3cb35 (build: convert sound.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#70:
deleted file mode 100644
total: 0 errors, 1 warnings, 51 lines checked
Patch 38/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
39/52 Checking commit 74950a85f9f2 (build: convert usb.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#158:
deleted file mode 100644
total: 0 errors, 1 warnings, 157 lines checked
Patch 39/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
40/52 Checking commit 7a26eaae9594 (scsi: express dependencies with Kconfig)
41/52 Checking commit 583608364d1c (isa: express dependencies with kconfig)
42/52 Checking commit 9b937662f4e1 (i386: express dependencies with Kconfig)
43/52 Checking commit fdf78be1f429 (i2c: express dependencies with Kconfig)
44/52 Checking commit fdd2c128b788 (ptimer: express dependencies with Kconfig)
45/52 Checking commit 1ef5cc5fb73b (display: express dependencies with kconfig)
46/52 Checking commit a59763338008 (hyperv: express dependencies with kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
deleted file mode 100644
total: 0 errors, 1 warnings, 15 lines checked
Patch 46/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
47/52 Checking commit 5a72a0c385fc (vfio: express vfio dependencies with Kconfig)
48/52 Checking commit 7ffb3fa21b40 (virtio: express virtio dependencies with Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37:
deleted file mode 100644
total: 0 errors, 1 warnings, 109 lines checked
Patch 48/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
49/52 Checking commit 8e3174384e2b (tpm: express dependencies with Kconfig)
50/52 Checking commit 8c1fb84ff49b (isa: express SuperIO dependencies with Kconfig)
51/52 Checking commit 2fadac69d98b (i386-softmmu.mak: remove all CONFIG_* except boards definitions)
52/52 Checking commit 12539e489992 (kconfig: introduce CONFIG_TEST_DEVICES)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1548410831-19553-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1548410831-19553-1-git-send-email-pbonzini@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU
Type: series
Message-id: 1548410831-19553-1-git-send-email-pbonzini@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/1548410831-19553-1-git-send-email-pbonzini@redhat.com -> patchew/1548410831-19553-1-git-send-email-pbonzini@redhat.com
Switched to a new branch 'test'
a79752a802 kconfig: introduce CONFIG_TEST_DEVICES
c9d0fe6e67 i386-softmmu.mak: remove all CONFIG_* except boards definitions
6f1e6af4d9 isa: express SuperIO dependencies with Kconfig
dc95811473 tpm: express dependencies with Kconfig
af23f11ab9 virtio: express virtio dependencies with Kconfig
fc253a0747 vfio: express vfio dependencies with Kconfig
04964cac83 hyperv: express dependencies with kconfig
0e23a1e99a display: express dependencies with kconfig
8d0e47d5b0 ptimer: express dependencies with Kconfig
70ffc63c86 i2c: express dependencies with Kconfig
1b10271dfb i386: express dependencies with Kconfig
4d30a49e26 isa: express dependencies with kconfig
f4d520f1f7 scsi: express dependencies with Kconfig
36465626a3 build: convert usb.mak to Kconfig
47589bdbf2 build: convert sound.mak to Kconfig
b96574e955 build: convert pci.mak to Kconfig
8cc438ca12 hw/pci/Makefile.objs: make pcie configurable
fcc8bb50ce ide: express dependencies with Kconfig
860ef3a709 minikconf: implement allnoconfig and defconfig
934e48569c build: switch to Kconfig
d253933815 kconfig: introduce kconfig files
47c5e5d250 hw/display: make edid configurable
3c7f935afa minikconfig: add semantic analysis
36b08f2e7a minikconfig: add AST
1ad0a25337 minikconfig: add parser skeleton
1733dbf5ab hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI
b863897de3 hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller
c91ddd4eaa hw/tricore/Makefile.objs: Create CONFIG_* for tricore
a9bf8be75a hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc
d2cdd2af82 hw/moxie/Makefile.objs: Conditionally build moxie
892410c5e9 hw/hppa/Makefile.objs: Create CONFIG_* for hppa
ae6333d373 hw/cris/Makefile.objs: Create CONFIG_* for cris
b9d2911c9d hw/alpha/Makefile.objs: Create CONFIG_* for alpha
3c3acae8cd hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64
0a96788079 hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards
530165e2ef hw/nios2/Makefile.objs: Conditionally build nios2
fbaef04334 hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally
9043ba2da9 hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst
811303a984 hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created
2f7135f01e hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices
af8b56692c hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device
cecc461ab2 hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*
4bf7173a1c hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards
6aed799dc5 hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards
3997152f27 hw/m68k/Makefile.objs: Conditionally build boards
530a866837 hw/arm/Makefile.objs: CONFIG_VIRT created for virt board
fa54373219 hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards
1b6abb71d5 build: actually use CONFIG_PAM
f6b12fb162 hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS
14d967c0bd vfio: move conditional up to hw/Makefile.objs
bfa4428a4f ide: split ioport registration to a separate file
305912d25e arm: disable CONFIG_SERIAL_ISA
=== OUTPUT BEGIN ===
1/52 Checking commit 305912d25e1c (arm: disable CONFIG_SERIAL_ISA)
2/52 Checking commit bfa4428a4fa5 (ide: split ioport registration to a separate file)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#71:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#132: FILE: hw/ide/ioport.c:57:
+ /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA
WARNING: Block comments use * on subsequent lines
#133: FILE: hw/ide/ioport.c:58:
+ /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA
+ bridge has been setup properly to always register with ISA. */
WARNING: Block comments use a trailing */ on a separate line
#133: FILE: hw/ide/ioport.c:58:
+ bridge has been setup properly to always register with ISA. */
total: 0 errors, 4 warnings, 113 lines checked
Patch 2/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/52 Checking commit 14d967c0bd06 (vfio: move conditional up to hw/Makefile.objs)
4/52 Checking commit f6b12fb162a0 (hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS)
5/52 Checking commit 1b6abb71d515 (build: actually use CONFIG_PAM)
6/52 Checking commit fa5437321983 (hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards)
7/52 Checking commit 530a8668373d (hw/arm/Makefile.objs: CONFIG_VIRT created for virt board)
8/52 Checking commit 3997152f27e5 (hw/m68k/Makefile.objs: Conditionally build boards)
9/52 Checking commit 6aed799dc5f7 (hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards)
10/52 Checking commit 4bf7173a1c3b (hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards)
11/52 Checking commit cecc461ab2ff (hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*)
12/52 Checking commit af8b56692c82 (hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device)
13/52 Checking commit 2f7135f01ea8 (hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices)
14/52 Checking commit 811303a984b6 (hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created)
15/52 Checking commit 9043ba2da95a (hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst)
16/52 Checking commit fbaef04334c1 (hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally)
17/52 Checking commit 530165e2ef75 (hw/nios2/Makefile.objs: Conditionally build nios2)
18/52 Checking commit 0a967880791e (hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards)
19/52 Checking commit 3c3acae8cd40 (hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64)
20/52 Checking commit b9d2911c9dd6 (hw/alpha/Makefile.objs: Create CONFIG_* for alpha)
21/52 Checking commit ae6333d37354 (hw/cris/Makefile.objs: Create CONFIG_* for cris)
22/52 Checking commit 892410c5e9bd (hw/hppa/Makefile.objs: Create CONFIG_* for hppa)
23/52 Checking commit d2cdd2af82d2 (hw/moxie/Makefile.objs: Conditionally build moxie)
24/52 Checking commit a9bf8be75a10 (hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc)
25/52 Checking commit c91ddd4eaaef (hw/tricore/Makefile.objs: Create CONFIG_* for tricore)
26/52 Checking commit b863897de362 (hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller)
27/52 Checking commit 1733dbf5ab13 (hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI)
28/52 Checking commit 1ad0a25337cc (minikconfig: add parser skeleton)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35:
new file mode 100644
WARNING: line over 80 characters
#251: FILE: scripts/minikconf.py:212:
+ 'Expected identifier starting with "CONFIG_"', TOK_NONE)
WARNING: line over 80 characters
#344: FILE: scripts/minikconf.py:305:
+ raise KconfigParserError(self, 'expected "source", "config", identifier, '
WARNING: line over 80 characters
#370: FILE: scripts/minikconf.py:331:
+ raise KconfigParserError(self, 'expected "source", "config" or identifier')
ERROR: line over 90 characters
#395: FILE: scripts/minikconf.py:356:
+ if self.src[self.cursor + length].isalnum() or self.src[self.cursor + length] == '|':
WARNING: line over 80 characters
#448: FILE: scripts/minikconf.py:409:
+ while self.src[self.cursor].isalnum() or self.src[self.cursor] == '_':
total: 1 errors, 5 warnings, 425 lines checked
Patch 28/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/52 Checking commit 36b08f2e7a79 (minikconfig: add AST)
WARNING: line over 80 characters
#89: FILE: scripts/minikconf.py:86:
+ return "config %s default %s if %s" % (self.dest, value, self.cond)
total: 0 errors, 1 warnings, 170 lines checked
Patch 29/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/52 Checking commit 3c7f935afa91 (minikconfig: add semantic analysis)
WARNING: line over 80 characters
#112: FILE: scripts/minikconf.py:102:
+ raise Exception('contradiction between clauses when setting %s' % self)
WARNING: line over 80 characters
#215: FILE: scripts/minikconf.py:214:
+ debug_print(i, "->", [str(x) for x in self.referenced_vars[i].outgoing])
total: 0 errors, 2 warnings, 223 lines checked
Patch 30/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/52 Checking commit 47c5e5d25040 (hw/display: make edid configurable)
32/52 Checking commit d2539338157c (kconfig: introduce kconfig files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44:
new file mode 100644
WARNING: line over 80 characters
#1762: FILE: scripts/minikconf.py:636:
+ print ("%s: at least one argument is required" % argv[0], file=sys.stderr)
total: 0 errors, 2 warnings, 1363 lines checked
Patch 32/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/52 Checking commit 934e48569c11 (build: switch to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#481:
deleted file mode 100644
total: 0 errors, 1 warnings, 325 lines checked
Patch 33/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/52 Checking commit 860ef3a709c8 (minikconf: implement allnoconfig and defconfig)
35/52 Checking commit fcc8bb50ce40 (ide: express dependencies with Kconfig)
36/52 Checking commit 8cc438ca1208 (hw/pci/Makefile.objs: make pcie configurable)
37/52 Checking commit b96574e95500 (build: convert pci.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#120:
deleted file mode 100644
total: 0 errors, 1 warnings, 472 lines checked
Patch 37/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
38/52 Checking commit 47589bdbf26b (build: convert sound.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#70:
deleted file mode 100644
total: 0 errors, 1 warnings, 51 lines checked
Patch 38/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
39/52 Checking commit 36465626a31a (build: convert usb.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#158:
deleted file mode 100644
total: 0 errors, 1 warnings, 157 lines checked
Patch 39/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
40/52 Checking commit f4d520f1f7fc (scsi: express dependencies with Kconfig)
41/52 Checking commit 4d30a49e2660 (isa: express dependencies with kconfig)
42/52 Checking commit 1b10271dfb10 (i386: express dependencies with Kconfig)
43/52 Checking commit 70ffc63c8623 (i2c: express dependencies with Kconfig)
44/52 Checking commit 8d0e47d5b043 (ptimer: express dependencies with Kconfig)
45/52 Checking commit 0e23a1e99a67 (display: express dependencies with kconfig)
46/52 Checking commit 04964cac8397 (hyperv: express dependencies with kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
deleted file mode 100644
total: 0 errors, 1 warnings, 15 lines checked
Patch 46/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
47/52 Checking commit fc253a074755 (vfio: express vfio dependencies with Kconfig)
48/52 Checking commit af23f11ab99b (virtio: express virtio dependencies with Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37:
deleted file mode 100644
total: 0 errors, 1 warnings, 109 lines checked
Patch 48/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
49/52 Checking commit dc95811473a1 (tpm: express dependencies with Kconfig)
50/52 Checking commit 6f1e6af4d997 (isa: express SuperIO dependencies with Kconfig)
51/52 Checking commit c9d0fe6e67ab (i386-softmmu.mak: remove all CONFIG_* except boards definitions)
52/52 Checking commit a79752a80249 (kconfig: introduce CONFIG_TEST_DEVICES)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1548410831-19553-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1548410831-19553-1-git-send-email-pbonzini@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1548410831-19553-1-git-send-email-pbonzini@redhat.com
Subject: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/1548410831-19553-1-git-send-email-pbonzini@redhat.com -> patchew/1548410831-19553-1-git-send-email-pbonzini@redhat.com
Switched to a new branch 'test'
a79752a kconfig: introduce CONFIG_TEST_DEVICES
c9d0fe6 i386-softmmu.mak: remove all CONFIG_* except boards definitions
6f1e6af isa: express SuperIO dependencies with Kconfig
dc95811 tpm: express dependencies with Kconfig
af23f11 virtio: express virtio dependencies with Kconfig
fc253a0 vfio: express vfio dependencies with Kconfig
04964ca hyperv: express dependencies with kconfig
0e23a1e display: express dependencies with kconfig
8d0e47d ptimer: express dependencies with Kconfig
70ffc63 i2c: express dependencies with Kconfig
1b10271 i386: express dependencies with Kconfig
4d30a49 isa: express dependencies with kconfig
f4d520f scsi: express dependencies with Kconfig
3646562 build: convert usb.mak to Kconfig
47589bd build: convert sound.mak to Kconfig
b96574e build: convert pci.mak to Kconfig
8cc438c hw/pci/Makefile.objs: make pcie configurable
fcc8bb5 ide: express dependencies with Kconfig
860ef3a minikconf: implement allnoconfig and defconfig
934e485 build: switch to Kconfig
d253933 kconfig: introduce kconfig files
47c5e5d hw/display: make edid configurable
3c7f935 minikconfig: add semantic analysis
36b08f2 minikconfig: add AST
1ad0a25 minikconfig: add parser skeleton
1733dbf hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI
b863897 hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller
c91ddd4 hw/tricore/Makefile.objs: Create CONFIG_* for tricore
a9bf8be hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc
d2cdd2a hw/moxie/Makefile.objs: Conditionally build moxie
892410c hw/hppa/Makefile.objs: Create CONFIG_* for hppa
ae6333d hw/cris/Makefile.objs: Create CONFIG_* for cris
b9d2911 hw/alpha/Makefile.objs: Create CONFIG_* for alpha
3c3acae hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64
0a96788 hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards
530165e hw/nios2/Makefile.objs: Conditionally build nios2
fbaef04 hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally
9043ba2 hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst
811303a hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created
2f7135f hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices
af8b566 hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device
cecc461 hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*
4bf7173 hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards
6aed799 hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards
3997152 hw/m68k/Makefile.objs: Conditionally build boards
530a866 hw/arm/Makefile.objs: CONFIG_VIRT created for virt board
fa54373 hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards
1b6abb7 build: actually use CONFIG_PAM
f6b12fb hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS
14d967c vfio: move conditional up to hw/Makefile.objs
bfa4428 ide: split ioport registration to a separate file
305912d arm: disable CONFIG_SERIAL_ISA
=== OUTPUT BEGIN ===
1/52 Checking commit 305912d25e1c (arm: disable CONFIG_SERIAL_ISA)
2/52 Checking commit bfa4428a4fa5 (ide: split ioport registration to a separate file)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#71:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#132: FILE: hw/ide/ioport.c:57:
+ /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA
WARNING: Block comments use * on subsequent lines
#133: FILE: hw/ide/ioport.c:58:
+ /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA
+ bridge has been setup properly to always register with ISA. */
WARNING: Block comments use a trailing */ on a separate line
#133: FILE: hw/ide/ioport.c:58:
+ bridge has been setup properly to always register with ISA. */
total: 0 errors, 4 warnings, 113 lines checked
Patch 2/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/52 Checking commit 14d967c0bd06 (vfio: move conditional up to hw/Makefile.objs)
4/52 Checking commit f6b12fb162a0 (hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS)
5/52 Checking commit 1b6abb71d515 (build: actually use CONFIG_PAM)
6/52 Checking commit fa5437321983 (hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards)
7/52 Checking commit 530a8668373d (hw/arm/Makefile.objs: CONFIG_VIRT created for virt board)
8/52 Checking commit 3997152f27e5 (hw/m68k/Makefile.objs: Conditionally build boards)
9/52 Checking commit 6aed799dc5f7 (hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards)
10/52 Checking commit 4bf7173a1c3b (hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards)
11/52 Checking commit cecc461ab2ff (hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*)
12/52 Checking commit af8b56692c82 (hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device)
13/52 Checking commit 2f7135f01ea8 (hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices)
14/52 Checking commit 811303a984b6 (hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created)
15/52 Checking commit 9043ba2da95a (hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst)
16/52 Checking commit fbaef04334c1 (hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally)
17/52 Checking commit 530165e2ef75 (hw/nios2/Makefile.objs: Conditionally build nios2)
18/52 Checking commit 0a967880791e (hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards)
19/52 Checking commit 3c3acae8cd40 (hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64)
20/52 Checking commit b9d2911c9dd6 (hw/alpha/Makefile.objs: Create CONFIG_* for alpha)
21/52 Checking commit ae6333d37354 (hw/cris/Makefile.objs: Create CONFIG_* for cris)
22/52 Checking commit 892410c5e9bd (hw/hppa/Makefile.objs: Create CONFIG_* for hppa)
23/52 Checking commit d2cdd2af82d2 (hw/moxie/Makefile.objs: Conditionally build moxie)
24/52 Checking commit a9bf8be75a10 (hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc)
25/52 Checking commit c91ddd4eaaef (hw/tricore/Makefile.objs: Create CONFIG_* for tricore)
26/52 Checking commit b863897de362 (hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller)
27/52 Checking commit 1733dbf5ab13 (hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI)
28/52 Checking commit 1ad0a25337cc (minikconfig: add parser skeleton)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35:
new file mode 100644
WARNING: line over 80 characters
#251: FILE: scripts/minikconf.py:212:
+ 'Expected identifier starting with "CONFIG_"', TOK_NONE)
WARNING: line over 80 characters
#344: FILE: scripts/minikconf.py:305:
+ raise KconfigParserError(self, 'expected "source", "config", identifier, '
WARNING: line over 80 characters
#370: FILE: scripts/minikconf.py:331:
+ raise KconfigParserError(self, 'expected "source", "config" or identifier')
ERROR: line over 90 characters
#395: FILE: scripts/minikconf.py:356:
+ if self.src[self.cursor + length].isalnum() or self.src[self.cursor + length] == '|':
WARNING: line over 80 characters
#448: FILE: scripts/minikconf.py:409:
+ while self.src[self.cursor].isalnum() or self.src[self.cursor] == '_':
total: 1 errors, 5 warnings, 425 lines checked
Patch 28/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/52 Checking commit 36b08f2e7a79 (minikconfig: add AST)
WARNING: line over 80 characters
#89: FILE: scripts/minikconf.py:86:
+ return "config %s default %s if %s" % (self.dest, value, self.cond)
total: 0 errors, 1 warnings, 170 lines checked
Patch 29/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/52 Checking commit 3c7f935afa91 (minikconfig: add semantic analysis)
WARNING: line over 80 characters
#112: FILE: scripts/minikconf.py:102:
+ raise Exception('contradiction between clauses when setting %s' % self)
WARNING: line over 80 characters
#215: FILE: scripts/minikconf.py:214:
+ debug_print(i, "->", [str(x) for x in self.referenced_vars[i].outgoing])
total: 0 errors, 2 warnings, 223 lines checked
Patch 30/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/52 Checking commit 47c5e5d25040 (hw/display: make edid configurable)
32/52 Checking commit d2539338157c (kconfig: introduce kconfig files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44:
new file mode 100644
WARNING: line over 80 characters
#1762: FILE: scripts/minikconf.py:636:
+ print ("%s: at least one argument is required" % argv[0], file=sys.stderr)
total: 0 errors, 2 warnings, 1363 lines checked
Patch 32/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/52 Checking commit 934e48569c11 (build: switch to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#481:
deleted file mode 100644
total: 0 errors, 1 warnings, 325 lines checked
Patch 33/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/52 Checking commit 860ef3a709c8 (minikconf: implement allnoconfig and defconfig)
35/52 Checking commit fcc8bb50ce40 (ide: express dependencies with Kconfig)
36/52 Checking commit 8cc438ca1208 (hw/pci/Makefile.objs: make pcie configurable)
37/52 Checking commit b96574e95500 (build: convert pci.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#120:
deleted file mode 100644
total: 0 errors, 1 warnings, 472 lines checked
Patch 37/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
38/52 Checking commit 47589bdbf26b (build: convert sound.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#70:
deleted file mode 100644
total: 0 errors, 1 warnings, 51 lines checked
Patch 38/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
39/52 Checking commit 36465626a31a (build: convert usb.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#158:
deleted file mode 100644
total: 0 errors, 1 warnings, 157 lines checked
Patch 39/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
40/52 Checking commit f4d520f1f7fc (scsi: express dependencies with Kconfig)
41/52 Checking commit 4d30a49e2660 (isa: express dependencies with kconfig)
42/52 Checking commit 1b10271dfb10 (i386: express dependencies with Kconfig)
43/52 Checking commit 70ffc63c8623 (i2c: express dependencies with Kconfig)
44/52 Checking commit 8d0e47d5b043 (ptimer: express dependencies with Kconfig)
45/52 Checking commit 0e23a1e99a67 (display: express dependencies with kconfig)
46/52 Checking commit 04964cac8397 (hyperv: express dependencies with kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
deleted file mode 100644
total: 0 errors, 1 warnings, 15 lines checked
Patch 46/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
47/52 Checking commit fc253a074755 (vfio: express vfio dependencies with Kconfig)
48/52 Checking commit af23f11ab99b (virtio: express virtio dependencies with Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37:
deleted file mode 100644
total: 0 errors, 1 warnings, 109 lines checked
Patch 48/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
49/52 Checking commit dc95811473a1 (tpm: express dependencies with Kconfig)
50/52 Checking commit 6f1e6af4d997 (isa: express SuperIO dependencies with Kconfig)
51/52 Checking commit c9d0fe6e67ab (i386-softmmu.mak: remove all CONFIG_* except boards definitions)
52/52 Checking commit a79752a80249 (kconfig: introduce CONFIG_TEST_DEVICES)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1548410831-19553-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1548410831-19553-1-git-send-email-pbonzini@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU
Message-id: 1548410831-19553-1-git-send-email-pbonzini@redhat.com
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/1548410831-19553-1-git-send-email-pbonzini@redhat.com -> patchew/1548410831-19553-1-git-send-email-pbonzini@redhat.com
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out 'd4e7d7ac663fcb55f1b93575445fcbca372f17a7'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out '9b7ab2fa020341dee8bf9df6c9cf40003e0136df'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '441a84d3a642a10b948369c63f32367e8ff6395b'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
a79752a kconfig: introduce CONFIG_TEST_DEVICES
c9d0fe6 i386-softmmu.mak: remove all CONFIG_* except boards definitions
6f1e6af isa: express SuperIO dependencies with Kconfig
dc95811 tpm: express dependencies with Kconfig
af23f11 virtio: express virtio dependencies with Kconfig
fc253a0 vfio: express vfio dependencies with Kconfig
04964ca hyperv: express dependencies with kconfig
0e23a1e display: express dependencies with kconfig
8d0e47d ptimer: express dependencies with Kconfig
70ffc63 i2c: express dependencies with Kconfig
1b10271 i386: express dependencies with Kconfig
4d30a49 isa: express dependencies with kconfig
f4d520f scsi: express dependencies with Kconfig
3646562 build: convert usb.mak to Kconfig
47589bd build: convert sound.mak to Kconfig
b96574e build: convert pci.mak to Kconfig
8cc438c hw/pci/Makefile.objs: make pcie configurable
fcc8bb5 ide: express dependencies with Kconfig
860ef3a minikconf: implement allnoconfig and defconfig
934e485 build: switch to Kconfig
d253933 kconfig: introduce kconfig files
47c5e5d hw/display: make edid configurable
3c7f935 minikconfig: add semantic analysis
36b08f2 minikconfig: add AST
1ad0a25 minikconfig: add parser skeleton
1733dbf hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI
b863897 hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller
c91ddd4 hw/tricore/Makefile.objs: Create CONFIG_* for tricore
a9bf8be hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc
d2cdd2a hw/moxie/Makefile.objs: Conditionally build moxie
892410c hw/hppa/Makefile.objs: Create CONFIG_* for hppa
ae6333d hw/cris/Makefile.objs: Create CONFIG_* for cris
b9d2911 hw/alpha/Makefile.objs: Create CONFIG_* for alpha
3c3acae hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64
0a96788 hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards
530165e hw/nios2/Makefile.objs: Conditionally build nios2
fbaef04 hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally
9043ba2 hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst
811303a hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created
2f7135f hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices
af8b566 hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device
cecc461 hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*
4bf7173 hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards
6aed799 hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards
3997152 hw/m68k/Makefile.objs: Conditionally build boards
530a866 hw/arm/Makefile.objs: CONFIG_VIRT created for virt board
fa54373 hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards
1b6abb7 build: actually use CONFIG_PAM
f6b12fb hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS
14d967c vfio: move conditional up to hw/Makefile.objs
bfa4428 ide: split ioport registration to a separate file
305912d arm: disable CONFIG_SERIAL_ISA
=== OUTPUT BEGIN ===
1/52 Checking commit 305912d25e1c (arm: disable CONFIG_SERIAL_ISA)
2/52 Checking commit bfa4428a4fa5 (ide: split ioport registration to a separate file)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#71:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#132: FILE: hw/ide/ioport.c:57:
+ /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA
WARNING: Block comments use * on subsequent lines
#133: FILE: hw/ide/ioport.c:58:
+ /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA
+ bridge has been setup properly to always register with ISA. */
WARNING: Block comments use a trailing */ on a separate line
#133: FILE: hw/ide/ioport.c:58:
+ bridge has been setup properly to always register with ISA. */
total: 0 errors, 4 warnings, 113 lines checked
Patch 2/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/52 Checking commit 14d967c0bd06 (vfio: move conditional up to hw/Makefile.objs)
4/52 Checking commit f6b12fb162a0 (hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS)
5/52 Checking commit 1b6abb71d515 (build: actually use CONFIG_PAM)
6/52 Checking commit fa5437321983 (hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards)
7/52 Checking commit 530a8668373d (hw/arm/Makefile.objs: CONFIG_VIRT created for virt board)
8/52 Checking commit 3997152f27e5 (hw/m68k/Makefile.objs: Conditionally build boards)
9/52 Checking commit 6aed799dc5f7 (hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards)
10/52 Checking commit 4bf7173a1c3b (hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards)
11/52 Checking commit cecc461ab2ff (hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*)
12/52 Checking commit af8b56692c82 (hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device)
13/52 Checking commit 2f7135f01ea8 (hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices)
14/52 Checking commit 811303a984b6 (hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created)
15/52 Checking commit 9043ba2da95a (hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst)
16/52 Checking commit fbaef04334c1 (hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally)
17/52 Checking commit 530165e2ef75 (hw/nios2/Makefile.objs: Conditionally build nios2)
18/52 Checking commit 0a967880791e (hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards)
19/52 Checking commit 3c3acae8cd40 (hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64)
20/52 Checking commit b9d2911c9dd6 (hw/alpha/Makefile.objs: Create CONFIG_* for alpha)
21/52 Checking commit ae6333d37354 (hw/cris/Makefile.objs: Create CONFIG_* for cris)
22/52 Checking commit 892410c5e9bd (hw/hppa/Makefile.objs: Create CONFIG_* for hppa)
23/52 Checking commit d2cdd2af82d2 (hw/moxie/Makefile.objs: Conditionally build moxie)
24/52 Checking commit a9bf8be75a10 (hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc)
25/52 Checking commit c91ddd4eaaef (hw/tricore/Makefile.objs: Create CONFIG_* for tricore)
26/52 Checking commit b863897de362 (hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller)
27/52 Checking commit 1733dbf5ab13 (hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI)
28/52 Checking commit 1ad0a25337cc (minikconfig: add parser skeleton)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35:
new file mode 100644
WARNING: line over 80 characters
#251: FILE: scripts/minikconf.py:212:
+ 'Expected identifier starting with "CONFIG_"', TOK_NONE)
WARNING: line over 80 characters
#344: FILE: scripts/minikconf.py:305:
+ raise KconfigParserError(self, 'expected "source", "config", identifier, '
WARNING: line over 80 characters
#370: FILE: scripts/minikconf.py:331:
+ raise KconfigParserError(self, 'expected "source", "config" or identifier')
ERROR: line over 90 characters
#395: FILE: scripts/minikconf.py:356:
+ if self.src[self.cursor + length].isalnum() or self.src[self.cursor + length] == '|':
WARNING: line over 80 characters
#448: FILE: scripts/minikconf.py:409:
+ while self.src[self.cursor].isalnum() or self.src[self.cursor] == '_':
total: 1 errors, 5 warnings, 425 lines checked
Patch 28/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/52 Checking commit 36b08f2e7a79 (minikconfig: add AST)
WARNING: line over 80 characters
#89: FILE: scripts/minikconf.py:86:
+ return "config %s default %s if %s" % (self.dest, value, self.cond)
total: 0 errors, 1 warnings, 170 lines checked
Patch 29/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/52 Checking commit 3c7f935afa91 (minikconfig: add semantic analysis)
WARNING: line over 80 characters
#112: FILE: scripts/minikconf.py:102:
+ raise Exception('contradiction between clauses when setting %s' % self)
WARNING: line over 80 characters
#215: FILE: scripts/minikconf.py:214:
+ debug_print(i, "->", [str(x) for x in self.referenced_vars[i].outgoing])
total: 0 errors, 2 warnings, 223 lines checked
Patch 30/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/52 Checking commit 47c5e5d25040 (hw/display: make edid configurable)
32/52 Checking commit d2539338157c (kconfig: introduce kconfig files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44:
new file mode 100644
WARNING: line over 80 characters
#1762: FILE: scripts/minikconf.py:636:
+ print ("%s: at least one argument is required" % argv[0], file=sys.stderr)
total: 0 errors, 2 warnings, 1363 lines checked
Patch 32/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/52 Checking commit 934e48569c11 (build: switch to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#481:
deleted file mode 100644
total: 0 errors, 1 warnings, 325 lines checked
Patch 33/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/52 Checking commit 860ef3a709c8 (minikconf: implement allnoconfig and defconfig)
35/52 Checking commit fcc8bb50ce40 (ide: express dependencies with Kconfig)
36/52 Checking commit 8cc438ca1208 (hw/pci/Makefile.objs: make pcie configurable)
37/52 Checking commit b96574e95500 (build: convert pci.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#120:
deleted file mode 100644
total: 0 errors, 1 warnings, 472 lines checked
Patch 37/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
38/52 Checking commit 47589bdbf26b (build: convert sound.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#70:
deleted file mode 100644
total: 0 errors, 1 warnings, 51 lines checked
Patch 38/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
39/52 Checking commit 36465626a31a (build: convert usb.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#158:
deleted file mode 100644
total: 0 errors, 1 warnings, 157 lines checked
Patch 39/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
40/52 Checking commit f4d520f1f7fc (scsi: express dependencies with Kconfig)
41/52 Checking commit 4d30a49e2660 (isa: express dependencies with kconfig)
42/52 Checking commit 1b10271dfb10 (i386: express dependencies with Kconfig)
43/52 Checking commit 70ffc63c8623 (i2c: express dependencies with Kconfig)
44/52 Checking commit 8d0e47d5b043 (ptimer: express dependencies with Kconfig)
45/52 Checking commit 0e23a1e99a67 (display: express dependencies with kconfig)
46/52 Checking commit 04964cac8397 (hyperv: express dependencies with kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
deleted file mode 100644
total: 0 errors, 1 warnings, 15 lines checked
Patch 46/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
47/52 Checking commit fc253a074755 (vfio: express vfio dependencies with Kconfig)
48/52 Checking commit af23f11ab99b (virtio: express virtio dependencies with Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37:
deleted file mode 100644
total: 0 errors, 1 warnings, 109 lines checked
Patch 48/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
49/52 Checking commit dc95811473a1 (tpm: express dependencies with Kconfig)
50/52 Checking commit 6f1e6af4d997 (isa: express SuperIO dependencies with Kconfig)
51/52 Checking commit c9d0fe6e67ab (i386-softmmu.mak: remove all CONFIG_* except boards definitions)
52/52 Checking commit a79752a80249 (kconfig: introduce CONFIG_TEST_DEVICES)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1548410831-19553-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Hi, On 1/25/19 11:06 AM, Paolo Bonzini wrote: > (I'm only momentarily at the helm and will give control back to Yang after > this iteration.) > > This is still RFC mostly because of the lack of documentation, and because > only x86 is fully converted, but it's converging. Other targets still > enable embedded devices in default-configs/ instead of using "select" > directives. For many targets, the conversion will be trivial because > they only support one board. The complex ones are ARM, MIPS and PPC > of course. s390 as usual is just different in some respects, but all > of its issues are sorted out already in this series and so it's just > yet another single-board target. > > It supports defconfig (default-configs file chooses boards only) > and allnoconfig (default-configs file chooses devices too) and builds > all targets. I haven't yet checked that the configuration is the same > before and after the conversion, but at least device-introspection-test > and other qtests all pass, which did catch some errors. > > As mentioned in the previous versions, this is only a replacement > for default-configs, in order to simplify configuration and remove > the need to track dependencies between configuration symbols. In > fact, even with the current incomplete conversion the diffstat > for default-configs is already > > 31 files changed, 108 insertions(+), 241 deletions(-) > > Devices can be disabled by adding for example > > CONFIG_HPET=n > > to default-configs/i386-softmmu.mak. If you prefer they can be > listed manually and "make allnoconfig" can be executed before > building. This probably should become a configure option > "--without-default-devices" instead. > > For the previous discussions on the Kconfig design, see > http://lists.nongnu.org/archive/html/qemu-devel/2018-09/msg02827.html > > Patches 1-27 should probably be committed now, so please review! Yang, > once they are reviewed you can extract them and post them to the > mailing list as non-RFC! > > As to the rest, you're welcome to try them, post conversions for the > simple targets, suggest usability improvements, and whatever. Thanks to > everyone for the work on the previous iterations. It's great to see > the work on this GSoC project come back to life after five years! How to express "depends of (TARGET_LONG_BITS > 32)"?
Patchew URL: https://patchew.org/QEMU/1548410831-19553-1-git-send-email-pbonzini@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash time make docker-test-mingw@fedora SHOW_ENV=1 J=14 === TEST SCRIPT END === The full log is available at http://patchew.org/logs/1548410831-19553-1-git-send-email-pbonzini@redhat.com/testing.docker-mingw@fedora/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
(I'm only momentarily at the helm and will give control back to Yang after this iteration.) This is still RFC mostly because of the lack of documentation, and because only x86 is fully converted, but it's converging. Other targets still enable embedded devices in default-configs/ instead of using "select" directives. For many targets, the conversion will be trivial because they only support one board. The complex ones are ARM, MIPS and PPC of course. s390 as usual is just different in some respects, but all of its issues are sorted out already in this series and so it's just yet another single-board target. It supports defconfig (default-configs file chooses boards only) and allnoconfig (default-configs file chooses devices too) and builds all targets. I haven't yet checked that the configuration is the same before and after the conversion, but at least device-introspection-test and other qtests all pass, which did catch some errors. As mentioned in the previous versions, this is only a replacement for default-configs, in order to simplify configuration and remove the need to track dependencies between configuration symbols. In fact, even with the current incomplete conversion the diffstat for default-configs is already 31 files changed, 108 insertions(+), 241 deletions(-) Devices can be disabled by adding for example CONFIG_HPET=n to default-configs/i386-softmmu.mak. If you prefer they can be listed manually and "make allnoconfig" can be executed before building. This probably should become a configure option "--without-default-devices" instead. For the previous discussions on the Kconfig design, see http://lists.nongnu.org/archive/html/qemu-devel/2018-09/msg02827.html Patches 1-27 should probably be committed now, so please review! Yang, once they are reviewed you can extract them and post them to the mailing list as non-RFC! As to the rest, you're welcome to try them, post conversions for the simple targets, suggest usability improvements, and whatever. Thanks to everyone for the work on the previous iterations. It's great to see the work on this GSoC project come back to life after five years! v4->v5: new patches 1, 2, 3, 13, 26, 27, 47, 49, 50, 52 Removed CONFIG_TYPHOON (patch 20) Removed CONFIG_DINO (patch 22) ported minikconf to python 3 improved some minikconf error messages added missing symbols in patch 32 added CONFIG_VHOST_USER and CONFIG_LINUX, made CONFIG_KVM per target (patch 33) removed $(...) assignments from default-configs/ (patch 33) moved allnoconfig patch earlier, removed allyesconfig/randconfig add CONFIG_PCI_EXPRESS to non-x86 targets (patch 36) added CONFIG_PCI_DEVICES in patch 37 to support s390x virtio-mmio does not support vhost-user yet (patches 40 and 48) fix PCSPK for platforms that lack an i8254 (patch 41) add "select ISA_BUS" to I82378 and SUN4U (patch 41) changed QXL/VTD/AMD_IOMMU from "select" to "default y if ..." (patch 42) moved "select PAM" and "select ISA_BUS" from board to device (patch 42) brought patch 44 up to date fixed MILKYMIST_TMU2 to only apply to MILKYMIST (patch 45) new config symbol VIRTIO_INPUT_HOST fixed select/depends for virtio (patch 48) moved some ACPI dependencies from board to devices (patch 51) Paolo Bonzini (27): arm: disable CONFIG_SERIAL_ISA ide: split ioport registration to a separate file vfio: move conditional up to hw/Makefile.objs build: actually use CONFIG_PAM hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI minikconfig: add parser skeleton minikconfig: add AST minikconfig: add semantic analysis kconfig: introduce kconfig files build: switch to Kconfig minikconf: implement allnoconfig and defconfig ide: express dependencies with Kconfig build: convert pci.mak to Kconfig build: convert sound.mak to Kconfig build: convert usb.mak to Kconfig scsi: express dependencies with Kconfig isa: express dependencies with kconfig i386: express dependencies with Kconfig i2c: express dependencies with Kconfig ptimer: express dependencies with Kconfig vfio: express vfio dependencies with Kconfig tpm: express dependencies with Kconfig isa: express SuperIO dependencies with Kconfig kconfig: introduce CONFIG_TEST_DEVICES Yang Zhong (17): hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS hw/arm/Makefile.objs: CONFIG_VIRT created for virt board hw/nios2/Makefile.objs: Conditionally build nios2 hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64 hw/alpha/Makefile.objs: Create CONFIG_* for alpha hw/cris/Makefile.objs: Create CONFIG_* for cris hw/hppa/Makefile.objs: Create CONFIG_* for hppa hw/moxie/Makefile.objs: Conditionally build moxie hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc hw/tricore/Makefile.objs: Create CONFIG_* for tricore hw/display: make edid configurable hw/pci/Makefile.objs: make pcie configurable display: express dependencies with kconfig hyperv: express dependencies with kconfig virtio: express virtio dependencies with Kconfig i386-softmmu.mak: remove all CONFIG_* except boards definitions Ákos Kovács (8): hw/m68k/Makefile.objs: Conditionally build boards hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_* hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally Kconfig.host | 24 ++ Makefile | 27 +- Makefile.target | 7 +- configure | 3 + default-configs/alpha-softmmu.mak | 14 +- default-configs/arm-softmmu.mak | 16 +- default-configs/cris-softmmu.mak | 2 +- default-configs/hppa-softmmu.mak | 6 +- default-configs/hyperv.mak | 2 - default-configs/i386-softmmu.mak | 77 +--- default-configs/lm32-softmmu.mak | 2 - default-configs/m68k-softmmu.mak | 3 +- default-configs/microblaze-softmmu.mak | 4 +- default-configs/mips-softmmu-common.mak | 13 +- default-configs/mips64el-softmmu.mak | 3 +- default-configs/moxie-softmmu.mak | 1 + default-configs/nios2-softmmu.mak | 2 +- default-configs/or1k-softmmu.mak | 1 + default-configs/pci.mak | 49 --- default-configs/ppc-softmmu.mak | 28 +- default-configs/ppc64-softmmu.mak | 5 - default-configs/riscv32-softmmu.mak | 15 +- default-configs/riscv64-softmmu.mak | 15 +- default-configs/s390x-softmmu.mak | 9 +- default-configs/sh4-softmmu.mak | 17 +- default-configs/sh4eb-softmmu.mak | 15 +- default-configs/sound.mak | 4 - default-configs/sparc-softmmu.mak | 3 +- default-configs/sparc64-softmmu.mak | 9 +- default-configs/tricore-softmmu.mak | 1 + default-configs/unicore32-softmmu.mak | 1 - default-configs/usb.mak | 11 - default-configs/virtio.mak | 15 - default-configs/xtensa-softmmu.mak | 3 + default-configs/xtensaeb-softmmu.mak | 3 + docs/devel/build-system.txt | 1 - hw/9pfs/Kconfig | 6 + hw/Kconfig | 73 ++++ hw/Makefile.objs | 4 +- hw/acpi/Kconfig | 29 ++ hw/adc/Kconfig | 2 + hw/alpha/Kconfig | 2 + hw/alpha/Makefile.objs | 2 +- hw/arm/Kconfig | 117 ++++++ hw/arm/Makefile.objs | 3 +- hw/audio/Kconfig | 52 +++ hw/block/Kconfig | 38 ++ hw/bt/Kconfig | 2 + hw/char/Kconfig | 42 ++ hw/core/Kconfig | 11 + hw/cpu/Kconfig | 8 + hw/cris/Kconfig | 6 + hw/cris/Makefile.objs | 2 +- hw/display/Kconfig | 107 +++++ hw/display/Makefile.objs | 4 +- hw/dma/Kconfig | 21 + hw/gpio/Kconfig | 9 + hw/hppa/Kconfig | 5 + hw/hppa/Makefile.objs | 2 +- hw/hyperv/Kconfig | 9 + hw/i2c/Kconfig | 27 ++ hw/i2c/Makefile.objs | 7 +- hw/i386/Kconfig | 88 ++++ hw/i386/Makefile.objs | 4 +- hw/ide/Kconfig | 54 +++ hw/ide/Makefile.objs | 6 +- hw/ide/core.c | 25 -- hw/ide/ioport.c | 67 ++++ hw/input/Kconfig | 33 ++ hw/intc/Kconfig | 59 +++ hw/ipack/Kconfig | 4 + hw/ipmi/Kconfig | 22 + hw/isa/Kconfig | 53 +++ hw/lm32/Kconfig | 7 + hw/lm32/Makefile.objs | 4 +- hw/m68k/Kconfig | 10 + hw/m68k/Makefile.objs | 4 +- hw/mem/Kconfig | 10 + hw/microblaze/Kconfig | 8 + hw/microblaze/Makefile.objs | 6 +- hw/mips/Kconfig | 21 + hw/mips/Makefile.objs | 5 +- hw/misc/Kconfig | 112 ++++++ hw/misc/macio/Kconfig | 11 + hw/moxie/Kconfig | 2 + hw/moxie/Makefile.objs | 2 +- hw/net/Kconfig | 122 ++++++ hw/net/Makefile.objs | 4 +- hw/nios2/Kconfig | 5 + hw/nios2/Makefile.objs | 3 +- hw/nvram/Kconfig | 8 + hw/openrisc/Kconfig | 2 + hw/openrisc/Makefile.objs | 2 +- hw/pci-bridge/Kconfig | 29 ++ hw/pci-host/Kconfig | 49 +++ hw/pci-host/Makefile.objs | 10 +- hw/pci/Kconfig | 9 + hw/pci/Makefile.objs | 9 +- hw/pcmcia/Kconfig | 2 + hw/ppc/Kconfig | 60 +++ hw/ppc/Makefile.objs | 11 +- hw/riscv/Kconfig | 19 + hw/riscv/Makefile.objs | 22 +- hw/s390x/Kconfig | 2 + hw/s390x/Makefile.objs | 2 + hw/scsi/Kconfig | 54 +++ hw/scsi/Makefile.objs | 2 +- hw/sd/Kconfig | 14 + hw/sh4/Kconfig | 12 + hw/sh4/Makefile.objs | 4 +- hw/smbios/Kconfig | 2 + hw/sparc/Kconfig | 13 + hw/sparc/Makefile.objs | 4 +- hw/sparc64/Kconfig | 6 + hw/sparc64/Makefile.objs | 6 +- hw/ssi/Kconfig | 14 + hw/timer/Kconfig | 63 +++ hw/tpm/Kconfig | 27 ++ hw/tricore/Kconfig | 2 + hw/tricore/Makefile.objs | 2 +- hw/unicore32/Kconfig | 3 + hw/usb/Kconfig | 91 +++++ hw/vfio/Kconfig | 36 ++ hw/vfio/Makefile.objs | 9 +- hw/virtio/Kconfig | 27 ++ hw/watchdog/Kconfig | 16 + hw/xtensa/Kconfig | 5 + hw/xtensa/Makefile.objs | 4 +- rules.mak | 2 +- scripts/make_device_config.sh | 30 -- scripts/minikconf.py | 687 ++++++++++++++++++++++++++++++++ 131 files changed, 2749 insertions(+), 374 deletions(-) create mode 100644 Kconfig.host delete mode 100644 default-configs/hyperv.mak delete mode 100644 default-configs/pci.mak delete mode 100644 default-configs/sound.mak delete mode 100644 default-configs/usb.mak delete mode 100644 default-configs/virtio.mak create mode 100644 hw/9pfs/Kconfig create mode 100644 hw/Kconfig create mode 100644 hw/acpi/Kconfig create mode 100644 hw/adc/Kconfig create mode 100644 hw/alpha/Kconfig create mode 100644 hw/arm/Kconfig create mode 100644 hw/audio/Kconfig create mode 100644 hw/block/Kconfig create mode 100644 hw/bt/Kconfig create mode 100644 hw/char/Kconfig create mode 100644 hw/core/Kconfig create mode 100644 hw/cpu/Kconfig create mode 100644 hw/cris/Kconfig create mode 100644 hw/display/Kconfig create mode 100644 hw/dma/Kconfig create mode 100644 hw/gpio/Kconfig create mode 100644 hw/hppa/Kconfig create mode 100644 hw/hyperv/Kconfig create mode 100644 hw/i2c/Kconfig create mode 100644 hw/i386/Kconfig create mode 100644 hw/ide/Kconfig create mode 100644 hw/ide/ioport.c create mode 100644 hw/input/Kconfig create mode 100644 hw/intc/Kconfig create mode 100644 hw/ipack/Kconfig create mode 100644 hw/ipmi/Kconfig create mode 100644 hw/isa/Kconfig create mode 100644 hw/lm32/Kconfig create mode 100644 hw/m68k/Kconfig create mode 100644 hw/mem/Kconfig create mode 100644 hw/microblaze/Kconfig create mode 100644 hw/mips/Kconfig create mode 100644 hw/misc/Kconfig create mode 100644 hw/misc/macio/Kconfig create mode 100644 hw/moxie/Kconfig create mode 100644 hw/net/Kconfig create mode 100644 hw/nios2/Kconfig create mode 100644 hw/nvram/Kconfig create mode 100644 hw/openrisc/Kconfig create mode 100644 hw/pci-bridge/Kconfig create mode 100644 hw/pci-host/Kconfig create mode 100644 hw/pci/Kconfig create mode 100644 hw/pcmcia/Kconfig create mode 100644 hw/ppc/Kconfig create mode 100644 hw/riscv/Kconfig create mode 100644 hw/s390x/Kconfig create mode 100644 hw/scsi/Kconfig create mode 100644 hw/sd/Kconfig create mode 100644 hw/sh4/Kconfig create mode 100644 hw/smbios/Kconfig create mode 100644 hw/sparc/Kconfig create mode 100644 hw/sparc64/Kconfig create mode 100644 hw/ssi/Kconfig create mode 100644 hw/timer/Kconfig create mode 100644 hw/tpm/Kconfig create mode 100644 hw/tricore/Kconfig create mode 100644 hw/unicore32/Kconfig create mode 100644 hw/usb/Kconfig create mode 100644 hw/vfio/Kconfig create mode 100644 hw/virtio/Kconfig create mode 100644 hw/watchdog/Kconfig create mode 100644 hw/xtensa/Kconfig delete mode 100644 scripts/make_device_config.sh create mode 100644 scripts/minikconf.py