Message ID | 1543851204-41186-1-git-send-email-pbonzini@redhat.com |
---|---|
Headers | show |
Series | qtest: qgraph driver framework | expand |
Patchew URL: https://patchew.org/QEMU/1543851204-41186-1-git-send-email-pbonzini@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH for-4.0 00/71] qtest: qgraph driver framework Message-id: 1543851204-41186-1-git-send-email-pbonzini@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 2481c4f qos-test: megasas test node eb1b2e2 qos-test: e1000 test node adbe018 qos-test: eepro100 test node 4bc9a83 qos-test: es1370 test node 23f2225 qos-test: vmxnet3 test node eaa4e82 qos-test: usb-hcd-ohci test node 5ba009f qos-test: spapr-phb test node 4ea3316 qos-test: pcnet test node d3ac439 qos-test: nvme test node a9f70fb qos-test: ne2k_pci test node 0ebd9c0 qos-test: ipoctal232 test node c78a4e6 qos-test: tpci200 test node d4ad0f6 qos-test: ac97 test node 6713c9b tests: move virtio entirely to qos-test dc6c5f2 tests/libqos: remove pre-qgraph QVirtioPCIDevice API 388e7d2 qos-test: virtio-scsi test node 34e436c tests/libqos: virtio-scsi driver and interface nodes 24704ac qos-test: vhost-user test node efc802d vhost-user-test: always use 256 MiB of guest memory 2ad03c4 tests/libqos: support multiqueue for virtio-net e7bc9002 qos-test: virtio-net test node 451616b tests/libqos: virtio-net driver and interface nodes 1febccc qos-test: virtio-blk test node 577ec81 tests/libqos: virtio-blk driver and interface nodes 89ad44e qos-test: virtio-rng test node c8bb1e8 tests/libqos: virtio-rng driver and interface nodes 3d32661 tests/qgraph: remove virtio-balloon-test 8eee4cb tests/libqos: virtio-balloon driver and interface nodes 9beaf3b qos-test: virtio-9p test node 9c82a2e tests/libqos: virtio-9p driver and interface nodes 5a8bbbc qos-test: virtio-console and virtio-serial test node 15ead1a tests/libqos: virtio-serial driver and interface nodes e31028a tests/qgraph: add generic virtio testcases 0bad3d3 tests/libqos: arm/virt machine node b27a3ae tests/libqos: virtio-mmio driver and interface nodes f487f19 tests/libqos: remove global_qtest from virtio endianness checks 7089f84 tests/libqos: virtio-pci driver and interface nodes 1c8385d qos-test: e1000e test node 348aa8e tests/libqos: e1000e driver and interface nodes 390c855 tests/libqos: has_buggy_msi flag 75f1afb tests/qgraph: ppc64/pseries machine node 7a73b3a tests/libqos: pci-spapr driver and interface nodes 4141cf0 tests/qgraph: add generic PCI testcases de3aefd qos-test: sdhci test node 41d4c33 tests/libqos: aarch64/xlnx-zcu102 machine node bc28cc5 tests/libqos: arm/xilinx-zynq-a9 machine node d4d45c2 tests/libqos: arm/sabrelite machine node 5d2f307 tests/libqos: arm/smdkc210 machine node c3dfe87 tests/libqos: arm/raspi2 machine node fe25242 tests/libqos: sdhci driver and interface nodes c8b2b96 tests/libqos: x86_64/pc machine node 51d165a tests/libqos: pci-pc driver and interface nodes dc0ef68 tests: qgraph API for the qtest driver framework a9189d09 tests/libqos: embed allocators instead of malloc-ing them 68fcc14 tests: remove rule for nonexisting qdev-monitor-test 5800452 tests/libqos: rename qpci_init_pc and qpci_init_spapr functions bc0a2b5 tests/libqos: introduce virtio_start_device 5a6e8da vhost-user-test: create a temporary directory per TestServer c331c35 vhost-user-test: small changes to init_hugepagefs dfcc9d9 vhost-user-test: create a main loop per TestServer b9852f5 vhost-user-test: reduce usage of global_qtest cfaadd5 vhost-user-test: skip if there is no memory at address 0 9326e61 vhost-user-test: support VHOST_USER_PROTOCOL_F_CROSS_ENDIAN eff2596 vhost-user: support cross-endian vnet headers 6134cca vhost-user-test: signal data_cond when s->rings changes 1b7aa1e vhost-user-test: use g_cond_broadcast a6d4bd9 vhost-net: revamp configure logic 96e94ca vhost-net: compile it on all targets that have virtio-net. 19a2ec5 vhost: restrict Linux dependency to kernel vhost 7577324 vhost-net-user: add stubs for when no virtio-net device is present 0b4471d vhost-net: move stubs to a separate file === OUTPUT BEGIN === Checking PATCH 1/71: vhost-net: move stubs to a separate file... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 115 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/71: vhost-net-user: add stubs for when no virtio-net device is present... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #99: new file mode 100644 total: 0 errors, 1 warnings, 75 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/71: vhost: restrict Linux dependency to kernel vhost... Checking PATCH 4/71: vhost-net: compile it on all targets that have virtio-net.... Checking PATCH 5/71: vhost-net: revamp configure logic... Checking PATCH 6/71: vhost-user-test: use g_cond_broadcast... Checking PATCH 7/71: vhost-user-test: signal data_cond when s->rings changes... Checking PATCH 8/71: vhost-user: support cross-endian vnet headers... Checking PATCH 9/71: vhost-user-test: support VHOST_USER_PROTOCOL_F_CROSS_ENDIAN... Checking PATCH 10/71: vhost-user-test: skip if there is no memory at address 0... Checking PATCH 11/71: vhost-user-test: reduce usage of global_qtest... WARNING: line over 80 characters #26: FILE: tests/vhost-user-test.c:190: +static void init_virtio_dev(QTestState *qts, TestServer *s, uint32_t features_mask) WARNING: line over 80 characters #59: FILE: tests/vhost-user-test.c:296: + uint32_t a = qtest_readb(qts, s->memory.regions[i].guest_phys_addr + j); total: 0 errors, 2 warnings, 132 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 12/71: vhost-user-test: create a main loop per TestServer... ERROR: space prohibited between function name and open parenthesis '(' #55: FILE: tests/vhost-user-test.c:551: + g_main_context_iteration (NULL, TRUE); total: 1 errors, 0 warnings, 82 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 13/71: vhost-user-test: small changes to init_hugepagefs... Checking PATCH 14/71: vhost-user-test: create a temporary directory per TestServer... ERROR: Error messages should not contain newlines #71: FILE: tests/vhost-user-test.c:510: + g_test_message("mkdtemp on path (%s): %s\n", template, strerror(errno)); ERROR: Error messages should not contain newlines #92: FILE: tests/vhost-user-test.c:580: + g_test_message("unable to rmdir: path (%s): %s\n", total: 2 errors, 0 warnings, 179 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 15/71: tests/libqos: introduce virtio_start_device... Checking PATCH 16/71: tests/libqos: rename qpci_init_pc and qpci_init_spapr functions... Checking PATCH 17/71: tests: remove rule for nonexisting qdev-monitor-test... Checking PATCH 18/71: tests/libqos: embed allocators instead of malloc-ing them... ERROR: code indent should never use tabs #339: FILE: tests/libqos/malloc-generic.c:19: +^I^I^Iuint64_t size, uint32_t page_size)$ total: 1 errors, 0 warnings, 846 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 19/71: tests: qgraph API for the qtest driver framework... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #93: new file mode 100644 WARNING: line over 80 characters #197: FILE: tests/libqos/qgraph.c:100: + opts->before_cmd_line ? g_strconcat(" ", opts->before_cmd_line, NULL) : NULL; WARNING: line over 80 characters #199: FILE: tests/libqos/qgraph.c:102: + opts->extra_device_opts ? g_strconcat(",", opts->extra_device_opts, NULL) : NULL; WARNING: line over 80 characters #201: FILE: tests/libqos/qgraph.c:104: + opts->after_cmd_line ? g_strconcat(" ", opts->after_cmd_line, NULL) : NULL; ERROR: code indent should never use tabs #1209: FILE: tests/libqos/qgraph.h:346: +^I^I^I^I * and modify the argument to the test function.$ WARNING: line over 80 characters #1930: FILE: tests/qos-test.c:202: +static void *allocate_objects(QTestState *qts, char **path, QGuestAllocator **p_alloc) WARNING: line over 80 characters #2087: FILE: tests/qos-test.c:359: + /* etype set to QEDGE_CONSUMED_BY so that machine can add to the command line */ total: 1 errors, 6 warnings, 2559 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 20/71: tests/libqos: pci-pc driver and interface nodes... Checking PATCH 21/71: tests/libqos: x86_64/pc machine node... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 ERROR: code indent should never use tabs #86: FILE: tests/libqos/x86_64_pc-machine.c:53: +^I^I^I^I QTestState *qts,$ total: 1 errors, 1 warnings, 119 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 22/71: tests/libqos: sdhci driver and interface nodes... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 ERROR: code indent should never use tabs #98: FILE: tests/libqos/sdhci.c:66: +^I^I uint32_t addr, QSDHCIProperties *common)$ ERROR: code indent should never use tabs #269: FILE: tests/libqos/sdhci.h:68: +^I^I uint32_t addr, QSDHCIProperties *common);$ total: 2 errors, 1 warnings, 240 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 23/71: tests/libqos: arm/raspi2 machine node... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644 total: 0 errors, 1 warnings, 98 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 24/71: tests/libqos: arm/smdkc210 machine node... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644 total: 0 errors, 1 warnings, 98 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 25/71: tests/libqos: arm/sabrelite machine node... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644 total: 0 errors, 1 warnings, 98 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 26/71: tests/libqos: arm/xilinx-zynq-a9 machine node... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644 total: 0 errors, 1 warnings, 101 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 27/71: tests/libqos: aarch64/xlnx-zcu102 machine node... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644 ERROR: line over 90 characters #120: FILE: tests/libqos/aarch64-xlnx-zcu102-machine.c:89: + qos_node_create_machine("aarch64/xlnx-zcu102", qos_create_machine_aarch64_xlnx_zcu102); total: 1 errors, 1 warnings, 100 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 28/71: qos-test: sdhci test node... Checking PATCH 29/71: tests/qgraph: add generic PCI testcases... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #23: new file mode 100644 total: 0 errors, 1 warnings, 32 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 30/71: tests/libqos: pci-spapr driver and interface nodes... Checking PATCH 31/71: tests/qgraph: ppc64/pseries machine node... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 ERROR: code indent should never use tabs #85: FILE: tests/libqos/ppc64_pseries-machine.c:53: +^I^I^I^I QGuestAllocator *alloc)$ total: 1 errors, 1 warnings, 118 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 32/71: tests/libqos: has_buggy_msi flag... Checking PATCH 33/71: tests/libqos: e1000e driver and interface nodes... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 320 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 34/71: qos-test: e1000e test node... WARNING: line over 80 characters #259: FILE: tests/e1000e-test.c:37: +static void e1000e_send_verify(QE1000E *d, int *test_sockets, QGuestAllocator *alloc) WARNING: line over 80 characters #281: FILE: tests/e1000e-test.c:101: +static void e1000e_receive_verify(QE1000E *d, int *test_sockets, QGuestAllocator *alloc) ERROR: code indent should never use tabs #458: FILE: tests/e1000e-test.c:255: +^I^I^I test_sockets[1]);$ total: 1 errors, 2 warnings, 445 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 35/71: tests/libqos: virtio-pci driver and interface nodes... WARNING: line over 80 characters #66: FILE: tests/libqos/virtio-pci.c:51: +static void qvirtio_pci_init_from_pcidev(QVirtioPCIDevice *dev, QPCIDevice *pci_dev) total: 0 errors, 1 warnings, 322 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 36/71: tests/libqos: remove global_qtest from virtio endianness checks... Checking PATCH 37/71: tests/libqos: virtio-mmio driver and interface nodes... WARNING: line over 80 characters #36: FILE: tests/libqos/virtio-mmio.c:21: + return qtest_readb(dev->qts, dev->addr + QVIRTIO_MMIO_DEVICE_SPECIFIC + off); WARNING: line over 80 characters #44: FILE: tests/libqos/virtio-mmio.c:27: + return qtest_readw(dev->qts, dev->addr + QVIRTIO_MMIO_DEVICE_SPECIFIC + off); WARNING: line over 80 characters #52: FILE: tests/libqos/virtio-mmio.c:33: + return qtest_readl(dev->qts, dev->addr + QVIRTIO_MMIO_DEVICE_SPECIFIC + off); WARNING: line over 80 characters #60: FILE: tests/libqos/virtio-mmio.c:39: + return qtest_readq(dev->qts, dev->addr + QVIRTIO_MMIO_DEVICE_SPECIFIC + off); WARNING: line over 80 characters #96: FILE: tests/libqos/virtio-mmio.c:66: + return (uint8_t)qtest_readl(dev->qts, dev->addr + QVIRTIO_MMIO_DEVICE_STATUS); WARNING: line over 80 characters #104: FILE: tests/libqos/virtio-mmio.c:72: + qtest_writel(dev->qts, dev->addr + QVIRTIO_MMIO_DEVICE_STATUS, (uint32_t)status); WARNING: line over 80 characters #147: FILE: tests/libqos/virtio-mmio.c:108: + g_assert_cmphex(qtest_readl(dev->qts, dev->addr + QVIRTIO_MMIO_QUEUE_PFN), ==, 0); WARNING: line over 80 characters #155: FILE: tests/libqos/virtio-mmio.c:114: + return (uint16_t)qtest_readl(dev->qts, dev->addr + QVIRTIO_MMIO_QUEUE_NUM_MAX); WARNING: line over 80 characters #177: FILE: tests/libqos/virtio-mmio.c:132: + qtest_writel(dev->qts, dev->addr + QVIRTIO_MMIO_QUEUE_ALIGN, dev->page_size); ERROR: code indent should never use tabs #227: FILE: tests/libqos/virtio-mmio.c:207: +^I^I^I uint64_t addr, uint32_t page_size)$ ERROR: code indent should never use tabs #283: FILE: tests/libqos/virtio-mmio.h:48: +^I^I^I uint64_t addr, uint32_t page_size);$ WARNING: line over 80 characters #296: FILE: tests/virtio-blk-test.c:725: + qvirtio_mmio_init_device(dev, global_qtest, MMIO_DEV_BASE_ADDR, MMIO_PAGE_SIZE); total: 2 errors, 10 warnings, 259 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 38/71: tests/libqos: arm/virt machine node... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644 ERROR: code indent should never use tabs #103: FILE: tests/libqos/arm-virt-machine.c:72: +^I ARM_VIRT_RAM_ADDR,$ ERROR: code indent should never use tabs #104: FILE: tests/libqos/arm-virt-machine.c:73: +^I ARM_VIRT_RAM_ADDR + ARM_VIRT_RAM_SIZE,$ ERROR: code indent should never use tabs #105: FILE: tests/libqos/arm-virt-machine.c:74: +^I ARM_PAGE_SIZE);$ total: 3 errors, 1 warnings, 97 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 39/71: tests/qgraph: add generic virtio testcases... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #23: new file mode 100644 total: 0 errors, 1 warnings, 32 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 40/71: tests/libqos: virtio-serial driver and interface nodes... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 total: 0 errors, 1 warnings, 156 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 41/71: qos-test: virtio-console and virtio-serial test node... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: deleted file mode 100644 total: 0 errors, 1 warnings, 90 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 42/71: tests/libqos: virtio-9p driver and interface nodes... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 total: 0 errors, 1 warnings, 222 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 43/71: qos-test: virtio-9p test node... Checking PATCH 44/71: tests/libqos: virtio-balloon driver and interface nodes... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 total: 0 errors, 1 warnings, 159 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 45/71: tests/qgraph: remove virtio-balloon-test... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: deleted file mode 100644 total: 0 errors, 1 warnings, 21 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 46/71: tests/libqos: virtio-rng driver and interface nodes... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 total: 0 errors, 1 warnings, 156 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 47/71: qos-test: virtio-rng test node... Checking PATCH 48/71: tests/libqos: virtio-blk driver and interface nodes... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 total: 0 errors, 1 warnings, 171 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 49/71: qos-test: virtio-blk test node... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #69: deleted file mode 100644 WARNING: line over 80 characters #763: FILE: tests/virtio-blk-test.c:576: + &(QPCIAddress) { .devfn = QPCI_DEVFN(PCI_SLOT_HP, 0) }); ERROR: code indent should never use tabs #868: FILE: tests/virtio-blk-test.c:643: +^I^I^I tmp_path);$ total: 1 errors, 2 warnings, 797 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 50/71: tests/libqos: virtio-net driver and interface nodes... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 total: 0 errors, 1 warnings, 244 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 51/71: qos-test: virtio-net test node... Checking PATCH 52/71: tests/libqos: support multiqueue for virtio-net... Checking PATCH 53/71: vhost-user-test: always use 256 MiB of guest memory... Checking PATCH 54/71: qos-test: vhost-user test node... ERROR: line over 90 characters #106: FILE: tests/vhost-user-test.c:173: +static void append_mem_opts(TestServer *server, GString *cmd_line, int size, enum test_memfd memfd) WARNING: line over 80 characters #494: FILE: tests/vhost-user-test.c:872: +static void test_vhost_user_started(void *obj, void *arg, QGuestAllocator *alloc) total: 1 errors, 1 warnings, 594 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 55/71: tests/libqos: virtio-scsi driver and interface nodes... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 total: 0 errors, 1 warnings, 163 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 56/71: qos-test: virtio-scsi test node... Checking PATCH 57/71: tests/libqos: remove pre-qgraph QVirtioPCIDevice API... WARNING: line over 80 characters #145: FILE: tests/libqos/virtio-pci.c:364: +static void qvirtio_pci_init_from_pcidev(QVirtioPCIDevice *dev, QPCIDevice *pci_dev) total: 0 errors, 1 warnings, 152 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 58/71: tests: move virtio entirely to qos-test... Checking PATCH 59/71: qos-test: ac97 test node... Checking PATCH 60/71: qos-test: tpci200 test node... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 86 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 61/71: qos-test: ipoctal232 test node... Checking PATCH 62/71: qos-test: ne2k_pci test node... Checking PATCH 63/71: qos-test: nvme test node... WARNING: line over 80 characters #150: FILE: tests/nvme-test.c:81: + qos_add_test("oob-cmb-access", "nvme", nvmetest_oob_cmb_test, &(QOSGraphTestOptions) { total: 0 errors, 1 warnings, 129 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 64/71: qos-test: pcnet test node... Checking PATCH 65/71: qos-test: spapr-phb test node... Checking PATCH 66/71: qos-test: usb-hcd-ohci test node... Checking PATCH 67/71: qos-test: vmxnet3 test node... Checking PATCH 68/71: qos-test: es1370 test node... Checking PATCH 69/71: qos-test: eepro100 test node... Checking PATCH 70/71: qos-test: e1000 test node... Checking PATCH 71/71: qos-test: megasas test node... WARNING: line over 80 characters #107: FILE: tests/megasas-test.c:47: +static void megasas_pd_get_info_fuzz(void *obj, void *data, QGuestAllocator *alloc) WARNING: line over 80 characters #157: FILE: tests/megasas-test.c:87: + qos_add_test("dcmd/pd-get-info/fuzz", "megasas", megasas_pd_get_info_fuzz, NULL); total: 0 errors, 2 warnings, 134 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1543851204-41186-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Hi Paolo, On 12/3/18 4:32 PM, Paolo Bonzini wrote: > Patches 1-14 are actually a refactoring of vhost and vhost-user-test so > that it can be "qtested" on all targets that support virtio-net. > > Patches 15-18 are other small refactorings to the libqos library and fixes > to the Makefile. > > Patch 19 is the framework, including unit tests, while the rest is conversions > of existing tests. We tried to pick tests that used a mix of features of > qtest, and that cover as many use cases as possible within qgraph. > In particular: > > - sdhci-test was the motivating example for the duplication between > PCI and MMIO versions of the same devices, so it come first > > - all virtio tests were converted, since they also have both MMIO and > PCI variants and they taught us a lot about modeling devices within > qgraph > > - all PCI devices that had "nop" tests only were converted, so that they > can avoid defining their copy of the test, and can instead use a > common test > > - finally, three more PCI devices were converted as an example - e1000e, > nvme and megasas > > This submission includes quite a few changes and cleanups that we did > not manage to complete before Emanuele restarted classes, but this > is almost entirely his baby; don't be fooled by the number of patches > authored by him vs. myself. I have noted my changes to the framework > in the commit message to patch 19, to help people that followed the > previous submissions; apart from that my changes consist of porting > vhost-user-test and turning the nop tests into generic PCI and virtio > tests (even though Emanuele had done the conversion to qgraph, he had > left the tests in the nodes due to lack of time). I'v tested the series and am quite happy with it. I did not notice anything particular that could block it. I'll send some comments in few patches that often apply to various patches. Series: Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> Regards, Phil.
On 12/3/18 4:32 PM, Paolo Bonzini wrote: > tests: qgraph API for the qtest driver framework > tests/libqos: pci-pc driver and interface nodes > tests/libqos: x86_64/pc machine node > tests/libqos: sdhci driver and interface nodes > tests/libqos: arm/raspi2 machine node > tests/libqos: arm/smdkc210 machine node > tests/libqos: arm/sabrelite machine node > tests/libqos: arm/xilinx-zynq-a9 machine node > tests/libqos: aarch64/xlnx-zcu102 machine node > qos-test: sdhci test node For the previous patches: Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>