From patchwork Mon Jul 30 01:48:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Mendoza-Jonas X-Patchwork-Id: 950701 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41f2YL3Lz1z9s0w for ; Mon, 30 Jul 2018 11:49:10 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=mendozajonas.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="Y8RwfR2Y"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="kgtgDovu"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 41f2YL1sKJzF162 for ; Mon, 30 Jul 2018 11:49:10 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=mendozajonas.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="Y8RwfR2Y"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="kgtgDovu"; dkim-atps=neutral X-Original-To: petitboot@lists.ozlabs.org Delivered-To: petitboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=mendozajonas.com (client-ip=64.147.123.19; helo=wout3-smtp.messagingengine.com; envelope-from=sam@mendozajonas.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=mendozajonas.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="Y8RwfR2Y"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="kgtgDovu"; dkim-atps=neutral Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41f2Y75KC3zF12j for ; Mon, 30 Jul 2018 11:48:58 +1000 (AEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 44ABC47D; Sun, 29 Jul 2018 21:48:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 29 Jul 2018 21:48:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= mendozajonas.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=capw3Zshvp3tDZJ7kY3nVwTZ+3e1ZQjaMg1Ime+q55Q=; b=Y8RwfR2Y 9lsKAP/W2HqTKAPewHP6dhWTZLPPQTqKczGdN410Q/PUqDSDO09JgXUsv3LMCkC5 /ZN1OQHQaCC318w+rRumIZhcR9d2CfU3d0t2Clz9DZuX28IVG1YlFD1lhGYbiwcL Zu3/0V5uZmolbB8e9+SsDX46OZ4d7G0FxD11cKWVgAY7djGNPcEw7Ffpv4Vp+ZkC lgFonol/hv5/WGX5snItVwZG3hM6XkoQxw5fJ1A29AuaNn8Ho/rJStSKk3XgJO57 Ds5Zi9h5zBqqJexw5VORMrev3x3D8FEDyUjzh6vt0jygEUcoCpUij4biopCqDO2T HtMLhI9D1VX7Pw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=capw3Zshvp3tDZJ7kY3nVwTZ+3e1ZQjaMg1Ime+q55Q=; b=kgtgDovu fWe/fSLqPdX/g75u9MtLgNli+hA9mkKY+ASON+99dC+NoOuFFynyhtbCV/gfu2qP JZi6Y00nMte19SxM22Pk2+4h3TUy176karrscXHaPkrr9eJ+sTs/20hSz/sqVJic bnY6enoQUyzpEeYeKG8wZc3mDPNHFoVu9B0pNQQ50Kze4P1qAxCuP8P2x3Lbbxir kImMmL7NSExxojLZB+nKwzZ9b5+ZFdwdyjYU7UDRL/d7n3UwkoiGelFllpNIDTCO 12vwX6pyqoYg/MTh/w/l7a0Pd0m20Pofq2gGeElNKCgaUcVWbYzdxr/ul4ltlKga /pTjZEIDbgEFZQ== X-ME-Proxy: X-ME-Sender: Received: from v4.ozlabs.ibm.com (unknown [122.99.82.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 8B11CE44F3; Sun, 29 Jul 2018 21:48:52 -0400 (EDT) From: Samuel Mendoza-Jonas To: petitboot@lists.ozlabs.org Subject: [PATCH 2/3] discover: Be more verbose about boot failures Date: Mon, 30 Jul 2018 11:48:25 +1000 Message-Id: <20180730014826.19097-2-sam@mendozajonas.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180730014826.19097-1-sam@mendozajonas.com> References: <20180730014826.19097-1-sam@mendozajonas.com> X-BeenThere: petitboot@lists.ozlabs.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Petitboot bootloader development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Mendoza-Jonas MIME-Version: 1.0 Errors-To: petitboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Petitboot" Signed-off-by: Samuel Mendoza-Jonas --- discover/boot.c | 6 ++++++ discover/paths.c | 2 ++ 2 files changed, 8 insertions(+) diff --git a/discover/boot.c b/discover/boot.c index 2a0d333..04c32a1 100644 --- a/discover/boot.c +++ b/discover/boot.c @@ -341,6 +341,8 @@ static int check_load(struct boot_task *task, const char *name, return 0; } + pb_log("Failed to load %s from %s\n", name, + pb_url_to_string(result->url)); update_status(task->status_fn, task->status_arg, STATUS_ERROR, _("Couldn't load %s from %s"), name, @@ -451,6 +453,8 @@ no_load: STATUS_ERROR, _("kexec reboot failed")); } + } else { + pb_log("Failed to load all boot resources\n"); } } @@ -462,6 +466,8 @@ static int start_url_load(struct boot_task *task, struct boot_resource *res) res->result = load_url_async(task, res->url, boot_process, task, NULL, task->status_arg); if (!res->result) { + pb_log("Error starting load for %s at %s\n", + res->name, pb_url_to_string(res->url)); update_status(task->status_fn, task->status_arg, STATUS_ERROR, _("Error loading %s"), res->name); diff --git a/discover/paths.c b/discover/paths.c index dd54ba2..dcd7b49 100644 --- a/discover/paths.c +++ b/discover/paths.c @@ -118,6 +118,8 @@ static void load_url_process_exit(struct process *process) } else { result->status = LOAD_ERROR; load_url_result_cleanup_local(result); + pb_debug("Download client stdout buffer:\n%s\n", + process->stdout_buf); } if (result->status == LOAD_OK && process->stdout_data)