mbox series

[v2,0/7] Overhaul target selection

Message ID 20180601063050.19286-1-amitay@ozlabs.org
Headers show
Series Overhaul target selection | expand

Message

Amitay Isaacs June 1, 2018, 6:30 a.m. UTC 
Re-implement parse_list() to return flags rather than indices.
This avoids potential overflows and the need to do any sorting and
unique ids identification.

For testing add core and thread targets in the fake backend and also in
the fake device tree.  This should help to test by hand till I figure
out how to add tests.

Fix dtc warnings missed by not cleaning p9-fsi.dtsi.  Thanks Joel.
Add missing dependency for p9-fsi.dtsi.

Fix bug in option parsing found by Rashmica.

Amitay Isaacs (7):
  main: Overhaul target selection
  main: Print specific errors for invalid arguments
  main: Print specific errors for invalid commands
  fake.dts: Add more targets for testing
  fake: Add fake targets for testing
  dts: Fix more warnings from dtc
  Makefile: Add dependencies for p9-fsi.dtsi

 Makefile.am    |   1 +
 fake.dts.m4    | 121 ++++++++++++++++++++++++++++-----
 libpdbg/fake.c |  18 +++++
 p8-fsi.dts.m4  |   4 +-
 p8-i2c.dts.m4  |   2 +
 p9-fsi.dtsi.m4 |   6 ++
 src/main.c     | 179 ++++++++++++++++++++++++++++++++++++-------------
 7 files changed, 267 insertions(+), 64 deletions(-)

Comments

Alistair Popple June 4, 2018, 5:27 a.m. UTC | #1 
Thanks Amitay,

I have taken patches 4-7 as the others seemed to depend on the first patch.

In future it would be clearer for me (and perhaps easier for you) if patch
series were split into individual features rather than reposted as a larger
series of unrelated patches. That way I can merge either a complete series or
not without holding up other features/bugfixes waiting for unrelated patches in
the series to be fixed up. Thanks!

- Alistair

On Friday, 1 June 2018 4:30:43 PM AEST Amitay Isaacs wrote:
> Re-implement parse_list() to return flags rather than indices.
> This avoids potential overflows and the need to do any sorting and
> unique ids identification.
> 
> For testing add core and thread targets in the fake backend and also in
> the fake device tree.  This should help to test by hand till I figure
> out how to add tests.
> 
> Fix dtc warnings missed by not cleaning p9-fsi.dtsi.  Thanks Joel.
> Add missing dependency for p9-fsi.dtsi.
> 
> Fix bug in option parsing found by Rashmica.
> 
> Amitay Isaacs (7):
>   main: Overhaul target selection
>   main: Print specific errors for invalid arguments
>   main: Print specific errors for invalid commands
>   fake.dts: Add more targets for testing
>   fake: Add fake targets for testing
>   dts: Fix more warnings from dtc
>   Makefile: Add dependencies for p9-fsi.dtsi
> 
>  Makefile.am    |   1 +
>  fake.dts.m4    | 121 ++++++++++++++++++++++++++++-----
>  libpdbg/fake.c |  18 +++++
>  p8-fsi.dts.m4  |   4 +-
>  p8-i2c.dts.m4  |   2 +
>  p9-fsi.dtsi.m4 |   6 ++
>  src/main.c     | 179 ++++++++++++++++++++++++++++++++++++-------------
>  7 files changed, 267 insertions(+), 64 deletions(-)
> 
>