From patchwork Mon Sep 19 22:38:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Finucane X-Patchwork-Id: 672013 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3sdLSN5KLqz9s5w for ; Tue, 20 Sep 2016 08:40:20 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3sdLSN4Kx8zDsgj for ; Tue, 20 Sep 2016 08:40:20 +1000 (AEST) X-Original-To: patchwork@lists.ozlabs.org Delivered-To: patchwork@lists.ozlabs.org Received: from BLU004-OMC3S22.hotmail.com (blu004-omc3s22.hotmail.com [65.55.116.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3sdLRx510NzDsfg for ; Tue, 20 Sep 2016 08:39:57 +1000 (AEST) Received: from BLU437-SMTP26 ([65.55.116.74]) by BLU004-OMC3S22.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Mon, 19 Sep 2016 15:39:54 -0700 X-TMN: [ouhUotuxbfjKkTnJpm4MIFtL1fn4EFnE] X-Originating-Email: [stephenfinucane@hotmail.com] Message-ID: From: Stephen Finucane To: patchwork@lists.ozlabs.org Subject: [PATCH 06/13] trivial: noqa any 'assert' functions Date: Mon, 19 Sep 2016 23:38:54 +0100 X-Mailer: git-send-email 2.7.4 In-Reply-To: <1474324741-3055-1-git-send-email-stephenfinucane@hotmail.com> References: <1474324741-3055-1-git-send-email-stephenfinucane@hotmail.com> X-OriginalArrivalTime: 19 Sep 2016 22:39:51.0598 (UTC) FILETIME=[BC1C94E0:01D212C6] MIME-Version: 1.0 X-BeenThere: patchwork@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Patchwork development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Patchwork" There are advantages to sticking with unittest's use of camel case in function names, but some code tools don't like this. noqa these lines to hide the warnings. Signed-off-by: Stephen Finucane --- patchwork/tests/test_checks.py | 6 +++--- patchwork/tests/test_parser.py | 4 ++-- patchwork/tests/test_tags.py | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/patchwork/tests/test_checks.py b/patchwork/tests/test_checks.py index cb3dfcc..c0487f3 100644 --- a/patchwork/tests/test_checks.py +++ b/patchwork/tests/test_checks.py @@ -43,12 +43,12 @@ class PatchChecksTest(TransactionTestCase): return create_check(**values) - def assertCheckEqual(self, patch, check_state): + def assertCheckEqual(self, patch, check_state): # noqa state_names = dict(Check.STATE_CHOICES) self.assertEqual(self.patch.combined_check_state, state_names[check_state]) - def assertChecksEqual(self, patch, checks=None): + def assertChecksEqual(self, patch, checks=None): # noqa if not checks: checks = [] @@ -57,7 +57,7 @@ class PatchChecksTest(TransactionTestCase): sorted(self.patch.checks, key=lambda check: check.id), sorted(checks, key=lambda check: check.id)) - def assertCheckCountEqual(self, patch, total, state_counts=None): + def assertCheckCountEqual(self, patch, total, state_counts=None): # noqa if not state_counts: state_counts = {} diff --git a/patchwork/tests/test_parser.py b/patchwork/tests/test_parser.py index 7b5c71b..9a739e4 100644 --- a/patchwork/tests/test_parser.py +++ b/patchwork/tests/test_parser.py @@ -554,7 +554,7 @@ class DelegateRequestTest(TestCase): email['Message-Id'] = self.msgid return email - def assertDelegate(self, delegate): + def assertDelegate(self, delegate): # noqa query = Patch.objects.filter(project=self.project) self.assertEqual(query.count(), 1) self.assertEqual(query[0].delegate, delegate) @@ -596,7 +596,7 @@ class InitialPatchStateTest(TestCase): self.patch, msgid=self.msgid, listid='<%s>' % self.project.listid) return email - def assertState(self, state): + def assertState(self, state): # noqa query = Patch.objects.filter(project=self.project) self.assertEqual(query.count(), 1) self.assertEqual(query[0].state, state) diff --git a/patchwork/tests/test_tags.py b/patchwork/tests/test_tags.py index 7d200e3..4fd1bf2 100644 --- a/patchwork/tests/test_tags.py +++ b/patchwork/tests/test_tags.py @@ -33,7 +33,7 @@ class ExtractTagsTest(TestCase): email = 'test@example.com' name_email = 'test name <' + email + '>' - def assertTagsEqual(self, str, acks, reviews, tests): + def assertTagsEqual(self, str, acks, reviews, tests): # noqa counts = Patch.extract_tags(str, Tag.objects.all()) self.assertEqual((acks, reviews, tests), (counts[Tag.objects.get(name='Acked-by')], @@ -92,7 +92,7 @@ class PatchTagsTest(TransactionTestCase): self.patch.project.use_tags = True self.patch.project.save() - def assertTagsEqual(self, patch, acks, reviews, tests): + def assertTagsEqual(self, patch, acks, reviews, tests): # noqa patch = Patch.objects.get(pk=patch.pk) def count(name): @@ -183,7 +183,7 @@ class PatchTagsTest(TransactionTestCase): class PatchTagManagerTest(PatchTagsTest): - def assertTagsEqual(self, patch, acks, reviews, tests): + def assertTagsEqual(self, patch, acks, reviews, tests): # noqa tagattrs = {} for tag in Tag.objects.all(): tagattrs[tag.name] = tag.attr_name