diff mbox

[U-Boot] A way to change the status of the whole series on Patchwork ?

Message ID 53D0C3BC.8010509@gmail.com
State Not Applicable
Headers show

Commit Message

Andreas Bießmann July 24, 2014, 8:28 a.m. UTC 
Dear Ian Campell,

On 07/24/2014 10:24 AM, Ian Campbell wrote:
> On Thu, 2014-07-24 at 09:23 +0200, Andreas Bießmann wrote:
>> Dear Ian Campell,
>>
>> On 07/23/2014 10:10 AM, Ian Campbell wrote:
>>> On Tue, 2014-07-22 at 12:45 -0700, Brian Norris wrote:
>>>
>>>> Then some sort of grepping/regex/etc. can get you the patchwork ID from
>>>> the Message-ID. e.g.:
>>>>
>>>>   pwclient list -m "$MESSAGEID" | awk '{print $1;}' | grep '[0-9][0-9]*'
>>>
>>> Which version of pwclient do you use? The one from
>>> http://patchwork.ozlabs.org/help/pwclient/ doesn't support -m. It's also
>>> incompatible with the example .pwclientrc from
>>> http://patchwork.ozlabs.org/project/uboot/pwclientrc/
>>>
>>> I did find an updated one (not sure where from now) which understands
>>> the newer pwclientrc syntax and seems to know the -m but neither of them
>>> seem to work fully. e.ge list -d doesn't work so
>>>         pwclient list -d 'Ian Campbell'
>>> returns an empty list for each of the 3 email addresses of mine it seems
>>> to know about, despite me currently having 3 patches delegated
>>> (including 371710 for example).
>>>
>>> Things like "pwclient list -p uboot -s New" do work though, and includes
>>> the patches which are delegated to me in the list.
>>
>> this is a known bug. No one cared about it for a year or so:
>> http://thread.gmane.org/gmane.comp.version-control.patchwork/706
> 
> Got it, thanks, I just won't use that feature then!

well, I use it rarely. Until Jeremy provides a fix in the RPC API I use
this hack on my side:

---8<---
             sys.stderr.write("Note: Nobody found matching *%s*\n" % \
--->8---

The delegate_id is extracted from the web UI, The delegate drop-down box
contains it.

Best regards

Andreas Bießmann

Comments

Ian Campbell July 24, 2014, 8:39 a.m. UTC | #1 
On Thu, 2014-07-24 at 10:28 +0200, Andreas Bießmann wrote:
> Dear Ian Campell,
> 
> On 07/24/2014 10:24 AM, Ian Campbell wrote:
> > On Thu, 2014-07-24 at 09:23 +0200, Andreas Bießmann wrote:
> >> Dear Ian Campell,
> >>
> >> On 07/23/2014 10:10 AM, Ian Campbell wrote:
> >>> On Tue, 2014-07-22 at 12:45 -0700, Brian Norris wrote:
> >>>
> >>>> Then some sort of grepping/regex/etc. can get you the patchwork ID from
> >>>> the Message-ID. e.g.:
> >>>>
> >>>>   pwclient list -m "$MESSAGEID" | awk '{print $1;}' | grep '[0-9][0-9]*'
> >>>
> >>> Which version of pwclient do you use? The one from
> >>> http://patchwork.ozlabs.org/help/pwclient/ doesn't support -m. It's also
> >>> incompatible with the example .pwclientrc from
> >>> http://patchwork.ozlabs.org/project/uboot/pwclientrc/
> >>>
> >>> I did find an updated one (not sure where from now) which understands
> >>> the newer pwclientrc syntax and seems to know the -m but neither of them
> >>> seem to work fully. e.ge list -d doesn't work so
> >>>         pwclient list -d 'Ian Campbell'
> >>> returns an empty list for each of the 3 email addresses of mine it seems
> >>> to know about, despite me currently having 3 patches delegated
> >>> (including 371710 for example).
> >>>
> >>> Things like "pwclient list -p uboot -s New" do work though, and includes
> >>> the patches which are delegated to me in the list.
> >>
> >> this is a known bug. No one cared about it for a year or so:
> >> http://thread.gmane.org/gmane.comp.version-control.patchwork/706
> > 
> > Got it, thanks, I just won't use that feature then!
> 
> well, I use it rarely. Until Jeremy provides a fix in the RPC API I use
> this hack on my side:

Great minds think alike -- I just posted the exact same thing!
diff mbox

Patch

diff --git a/apps/patchwork/bin/pwclient b/apps/patchwork/bin/pwclient
index dfbea30..5db29ff 100755
--- a/apps/patchwork/bin/pwclient
+++ b/apps/patchwork/bin/pwclient
@@ -192,6 +192,13 @@  def action_list(rpc, filter, submitter_str,
delegate_str):
         return

     if delegate_str != "":
+        if delegate_str == "me":
+            print "Patches delegated to me:"
+            f = filter
+            f.add("delegate_id", 6342)
+            patches = rpc.patch_list(f.d)
+            list_patches(patches)
+            return
         ids = person_ids_by_name(rpc, delegate_str)
         if len(ids) == 0: