diff mbox series

[1/5] tests: Add duplicate mail test

Message ID 20200416012928.23893-2-jk@ozlabs.org
State Accepted
Headers show
Series Prevent database error logs on duplicate mail | expand

Commit Message

Jeremy Kerr April 16, 2020, 1:29 a.m. UTC
Test that we get the correct DuplicateMailError from parsing the same
mail twice.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
---
 patchwork/tests/test_parser.py | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
diff mbox series

Patch

diff --git a/patchwork/tests/test_parser.py b/patchwork/tests/test_parser.py
index f5631be..3a41000 100644
--- a/patchwork/tests/test_parser.py
+++ b/patchwork/tests/test_parser.py
@@ -14,6 +14,7 @@  import unittest
 
 from django.test import TestCase
 from django.test import TransactionTestCase
+from django.db.transaction import atomic
 
 from patchwork.models import Comment
 from patchwork.models import Patch
@@ -31,6 +32,7 @@  from patchwork.parser import parse_series_marker
 from patchwork.parser import parse_version
 from patchwork.parser import split_prefixes
 from patchwork.parser import subject_check
+from patchwork.parser import DuplicateMailError
 from patchwork.tests import TEST_MAIL_DIR
 from patchwork.tests import TEST_FUZZ_DIR
 from patchwork.tests.utils import create_project
@@ -1080,3 +1082,28 @@  class WeirdMailTest(TransactionTestCase):
 
     def test_x_face(self):
         self._test_patch('x-face.mbox')
+
+
+class DuplicateMailTest(TestCase):
+    def setUp(self):
+        self.listid = 'patchwork.ozlabs.org'
+        create_project(listid=self.listid)
+        create_state()
+
+    def _test_duplicate_mail(self, mail):
+        _parse_mail(mail)
+        with self.assertRaises(DuplicateMailError):
+            # If we see any database errors from the duplicate insert
+            # (typically an IntegrityError), the insert will abort the current
+            # transaction. This atomic() ensures that we can recover, and
+            # perform subsequent queries.
+            with atomic():
+                _parse_mail(mail)
+
+    def test_duplicate_patch(self):
+        diff = read_patch('0001-add-line.patch')
+        m = create_email(diff, listid=self.listid, msgid='1@example.com')
+
+        self._test_duplicate_mail(m)
+
+        self.assertEqual(Patch.objects.count(), 1)