diff mbox series

Fixed dependency in the Dokerfile

Message ID 20200211170026.4713-1-pranavannam@gmail.com
State Accepted
Headers show
Series Fixed dependency in the Dokerfile | expand

Commit Message

pranavannam@gmail.com Feb. 11, 2020, 5 p.m. UTC 
From: Pranav Annam <pranavannam@gmail.com>

The dependency libssl1.0-dev  in the dockerfile makes the docker build fail.
There seems to be a conflict with different versions of libssl and libmysqlclient that did not exist in the past.
So instead going for the newer version of libssl and holding for the earlier and stable version(libssl-dev)
fixed the docker build.

Signed-off-by: Pranav Annam <pranavannam@gmail.com>
---
 tools/docker/Dockerfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lukas Bulwahn Feb. 12, 2020, 2:32 a.m. UTC | #1 
On Tue, 11 Feb 2020, pranavannam@gmail.com wrote:

> From: Pranav Annam <pranavannam@gmail.com>
> 
> The dependency libssl1.0-dev  in the dockerfile makes the docker build fail.
> There seems to be a conflict with different versions of libssl and libmysqlclient that did not exist in the past.
> So instead going for the newer version of libssl and holding for the earlier and stable version(libssl-dev)
> fixed the docker build.
> 
> Signed-off-by: Pranav Annam <pranavannam@gmail.com>

@Daniel, @Stephen, @others, Pranav is an GSoC applicant trying to 
contribute to patchwork. I already did a few internal rounds of 
mentoring and review with him and we decided to send out the current 
result for helpful feedback from everyone.

I will send a v2 with what I would have specifically liked the patch to 
look like.

Lukas

> ---
>  tools/docker/Dockerfile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile
> index 5ef1120..62ac461 100644
> --- a/tools/docker/Dockerfile
> +++ b/tools/docker/Dockerfile
> @@ -35,7 +35,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
>      libpq-dev \
>      libreadline-dev \
>      libsqlite3-dev \
> -    libssl1.0-dev \
> +    libssl-dev \
>      mysql-client \
>      postgresql-client \
>      tzdata \
> -- 
> 2.17.1
> 
> _______________________________________________
> Patchwork mailing list
> Patchwork@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork
>
diff mbox series

Patch

diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile
index 5ef1120..62ac461 100644
--- a/tools/docker/Dockerfile
+++ b/tools/docker/Dockerfile
@@ -35,7 +35,7 @@  RUN apt-get update && apt-get install -y --no-install-recommends \
     libpq-dev \
     libreadline-dev \
     libsqlite3-dev \
-    libssl1.0-dev \
+    libssl-dev \
     mysql-client \
     postgresql-client \
     tzdata \