From patchwork Thu Oct 31 06:27:20 2019
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Andrew Donnellan <ajd@linux.ibm.com>
X-Patchwork-Id: 1187198
Return-Path: 
 <patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>
X-Original-To: incoming@patchwork.ozlabs.org
Delivered-To: patchwork-incoming@bilbo.ozlabs.org
Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	key-exchange X25519 server-signature RSA-PSS (4096 bits))
	(No client certificate requested)
	by ozlabs.org (Postfix) with ESMTPS id 473b3v2F5Nz9sP4
	for <incoming@patchwork.ozlabs.org>;
	Thu, 31 Oct 2019 17:28:11 +1100 (AEDT)
Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none)
	header.from=linux.ibm.com
Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])
	by lists.ozlabs.org (Postfix) with ESMTP id 473b3v17DRzF5ZY
	for <incoming@patchwork.ozlabs.org>;
	Thu, 31 Oct 2019 17:28:11 +1100 (AEDT)
X-Original-To: patchwork@lists.ozlabs.org
Delivered-To: patchwork@lists.ozlabs.org
Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized)
	smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1;
	helo=mx0a-001b2d01.pphosted.com; envelope-from=ajd@linux.ibm.com;
	receiver=<UNKNOWN>)
Authentication-Results: lists.ozlabs.org;
	dmarc=none (p=none dis=none) header.from=linux.ibm.com
Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com
	[148.163.156.1])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
	bits)) (No client certificate requested)
	by lists.ozlabs.org (Postfix) with ESMTPS id 473b3k4WpwzF5ZL
	for <patchwork@lists.ozlabs.org>;
	Thu, 31 Oct 2019 17:28:02 +1100 (AEDT)
Received: from pps.filterd (m0098404.ppops.net [127.0.0.1])
	by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id
	x9V6RnpS049439
	for <patchwork@lists.ozlabs.org>; Thu, 31 Oct 2019 02:27:57 -0400
Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97])
	by mx0a-001b2d01.pphosted.com with ESMTP id 2vyss68wat-1
	(version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT)
	for <patchwork@lists.ozlabs.org>; Thu, 31 Oct 2019 02:27:55 -0400
Received: from localhost
	by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <patchwork@lists.ozlabs.org> from <ajd@linux.ibm.com>;
	Thu, 31 Oct 2019 06:27:38 -0000
Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192)
	by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP
	Gateway: Authorized Use Only! Violators will be prosecuted;
	(version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256)
	Thu, 31 Oct 2019 06:27:36 -0000
Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com
	[9.149.105.232])
	by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0)
	with ESMTP id x9V6R1td24314142
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK); Thu, 31 Oct 2019 06:27:01 GMT
Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1])
	by IMSVA (Postfix) with ESMTP id D08AD5204F;
	Thu, 31 Oct 2019 06:27:35 +0000 (GMT)
Received: from ozlabs.au.ibm.com (unknown [9.192.253.14])
	by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 7E7955204E;
	Thu, 31 Oct 2019 06:27:35 +0000 (GMT)
Received: from intelligence.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114])
	(using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by ozlabs.au.ibm.com (Postfix) with ESMTPSA id A7F81A01FB;
	Thu, 31 Oct 2019 17:27:31 +1100 (AEDT)
From: Andrew Donnellan <ajd@linux.ibm.com>
To: dja@axtens.net, patchwork@lists.ozlabs.org
Subject: [PATCH v2] templates: Move download buttons outside h1 tag
Date: Thu, 31 Oct 2019 17:27:20 +1100
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
X-TM-AS-GCONF: 00
x-cbid: 19103106-4275-0000-0000-000003796FA7
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 19103106-4276-0000-0000-0000388CAC43
Message-Id: <20191031062720.22679-1-ajd@linux.ibm.com>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, ,
	definitions=2019-10-31_02:, , signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
	priorityscore=1501
	malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0
	clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0
	mlxlogscore=867 adultscore=0 classifier=spam adjust=0 reason=mlx
	scancount=1 engine=8.0.1-1908290000 definitions=main-1910310063
X-BeenThere: patchwork@lists.ozlabs.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Patchwork development <patchwork.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/patchwork>,
	<mailto:patchwork-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/patchwork/>
List-Post: <mailto:patchwork@lists.ozlabs.org>
List-Help: <mailto:patchwork-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/patchwork>,
	<mailto:patchwork-request@lists.ozlabs.org?subject=subscribe>
Errors-To: patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org
Sender: "Patchwork"
	<patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>

It's not valid to put a <div> inside an <h1>. Move the download buttons in
the submission template outside the <h1> tag.

Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
---
v1->v2
- make it look the same as before (Daniel)
---
 patchwork/templates/patchwork/submission.html | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/patchwork/templates/patchwork/submission.html b/patchwork/templates/patchwork/submission.html
index b5b55dbd9241..b3849789b1fd 100644
--- a/patchwork/templates/patchwork/submission.html
+++ b/patchwork/templates/patchwork/submission.html
@@ -27,9 +27,10 @@ function toggle_div(link_id, headers_id)
 }
 </script>
 
-<h1>{{ submission.name }}
-{% include "patchwork/partials/download-buttons.html" %}
-</h1>
+<div>
+  {% include "patchwork/partials/download-buttons.html" %}
+  <h1>{{ submission.name }}</h1>
+</div>
 
 <table class="patchmeta">
  <tr>
@@ -273,11 +274,10 @@ function toggle_div(link_id, headers_id)
 {% endfor %}
 
 {% if submission.diff %}
-<h2>
- Patch
- {% include "patchwork/partials/download-buttons.html" %}
-</h2>
-
+<div>
+  {% include "patchwork/partials/download-buttons.html" %}
+  <h2>Patch</h2>
+</div>
 <div id="patch" class="patch">
 <pre class="content">
 {{ submission|patchsyntax }}