| Message ID | 20191031062720.22679-1-ajd@linux.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] templates: Move download buttons outside h1 tag | expand |
Applied, thanks. Andrew Donnellan <ajd@linux.ibm.com> writes: > It's not valid to put a <div> inside an <h1>. Move the download buttons in > the submission template outside the <h1> tag. > > Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com> > > --- > v1->v2 > - make it look the same as before (Daniel) > --- > patchwork/templates/patchwork/submission.html | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/patchwork/templates/patchwork/submission.html b/patchwork/templates/patchwork/submission.html > index b5b55dbd9241..b3849789b1fd 100644 > --- a/patchwork/templates/patchwork/submission.html > +++ b/patchwork/templates/patchwork/submission.html > @@ -27,9 +27,10 @@ function toggle_div(link_id, headers_id) > } > </script> > > -<h1>{{ submission.name }} > -{% include "patchwork/partials/download-buttons.html" %} > -</h1> > +<div> > + {% include "patchwork/partials/download-buttons.html" %} > + <h1>{{ submission.name }}</h1> > +</div> > > <table class="patchmeta"> > <tr> > @@ -273,11 +274,10 @@ function toggle_div(link_id, headers_id) > {% endfor %} > > {% if submission.diff %} > -<h2> > - Patch > - {% include "patchwork/partials/download-buttons.html" %} > -</h2> > - > +<div> > + {% include "patchwork/partials/download-buttons.html" %} > + <h2>Patch</h2> > +</div> > <div id="patch" class="patch"> > <pre class="content"> > {{ submission|patchsyntax }} > -- > 2.20.1
diff --git a/patchwork/templates/patchwork/submission.html b/patchwork/templates/patchwork/submission.html index b5b55dbd9241..b3849789b1fd 100644 --- a/patchwork/templates/patchwork/submission.html +++ b/patchwork/templates/patchwork/submission.html @@ -27,9 +27,10 @@ function toggle_div(link_id, headers_id) } </script> -<h1>{{ submission.name }} -{% include "patchwork/partials/download-buttons.html" %} -</h1> +<div> + {% include "patchwork/partials/download-buttons.html" %} + <h1>{{ submission.name }}</h1> +</div> <table class="patchmeta"> <tr> @@ -273,11 +274,10 @@ function toggle_div(link_id, headers_id) {% endfor %} {% if submission.diff %} -<h2> - Patch - {% include "patchwork/partials/download-buttons.html" %} -</h2> - +<div> + {% include "patchwork/partials/download-buttons.html" %} + <h2>Patch</h2> +</div> <div id="patch" class="patch"> <pre class="content"> {{ submission|patchsyntax }}
It's not valid to put a <div> inside an <h1>. Move the download buttons in the submission template outside the <h1> tag. Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com> --- v1->v2 - make it look the same as before (Daniel) --- patchwork/templates/patchwork/submission.html | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)