diff mbox series

Python 3.8 support

Message ID 20191024031010.13357-1-ajd@linux.ibm.com
State Superseded
Headers show
Series Python 3.8 support | expand

Commit Message

Andrew Donnellan Oct. 24, 2019, 3:10 a.m. UTC
Enable Python 3.8 in our tests and list it as a supported version.

Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
---
 README.rst              | 2 +-
 tools/docker/Dockerfile | 3 ++-
 tox.ini                 | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

Comments

Stephen Finucane Nov. 5, 2019, 3:18 a.m. UTC | #1
On Thu, 2019-10-24 at 14:10 +1100, Andrew Donnellan wrote:
> Enable Python 3.8 in our tests and list it as a supported version.
> 
> Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>

LGTM, but let's hold off on this until 2.2 is out.

Stephen
Andrew Donnellan Nov. 5, 2019, 4:04 a.m. UTC | #2
On 5/11/19 2:18 pm, Stephen Finucane wrote:
> On Thu, 2019-10-24 at 14:10 +1100, Andrew Donnellan wrote:
>> Enable Python 3.8 in our tests and list it as a supported version.
>>
>> Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
> 
> LGTM, but let's hold off on this until 2.2 is out.

Given there are no code changes necessary (AFAICT) for Python 3.8 I'd 
rather merge this now, so we avoid adding regressions in stable 
backports during the period where distros start transitioning to 3.8.
Daniel Axtens Nov. 5, 2019, 4:41 a.m. UTC | #3
Andrew Donnellan <ajd@linux.ibm.com> writes:

> On 5/11/19 2:18 pm, Stephen Finucane wrote:
>> On Thu, 2019-10-24 at 14:10 +1100, Andrew Donnellan wrote:
>>> Enable Python 3.8 in our tests and list it as a supported version.
>>>
>>> Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
>> 
>> LGTM, but let's hold off on this until 2.2 is out.
>
> Given there are no code changes necessary (AFAICT) for Python 3.8 I'd 
> rather merge this now, so we avoid adding regressions in stable 
> backports during the period where distros start transitioning to 3.8.

Hmm, clearly I forgot to reply. I merged this already, given that it was
such a trivial patch.

Regards,
Daniel

>
> -- 
> Andrew Donnellan              OzLabs, ADL Canberra
> ajd@linux.ibm.com             IBM Australia Limited
>
> _______________________________________________
> Patchwork mailing list
> Patchwork@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork
diff mbox series

Patch

diff --git a/README.rst b/README.rst
index 01da41969168..074ded9a7db2 100644
--- a/README.rst
+++ b/README.rst
@@ -41,7 +41,7 @@  of community projects.
 Requirements
 ------------
 
-- Python (2.7, 3.5 - 3.7)
+- Python (2.7, 3.5 - 3.8)
 
 - Django (1.11 - 2.2)
 
diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile
index 61678134d418..5ef11203e850 100644
--- a/tools/docker/Dockerfile
+++ b/tools/docker/Dockerfile
@@ -49,7 +49,8 @@  RUN curl -L https://github.com/pyenv/pyenv-installer/raw/master/bin/pyenv-instal
 RUN pyenv latest install 2.7 && \
     pyenv latest install 3.5 && \
     pyenv latest install 3.6 && \
-    pyenv latest install 3.7
+    pyenv latest install 3.7 && \
+    pyenv latest install 3.8
 RUN pyenv global $(pyenv versions --bare | tac)
 
 RUN pip install tox tox-pyenv
diff --git a/tox.ini b/tox.ini
index 617e73cdbee6..4267f47241b6 100644
--- a/tox.ini
+++ b/tox.ini
@@ -1,6 +1,6 @@ 
 [tox]
 minversion = 2.0
-envlist = pep8,docs,py27-django111,py{35,36,37}-django{111,20,21,22}
+envlist = pep8,docs,py27-django111,py{35,36,37,38}-django{111,20,21,22}
 skipsdist = True
 
 [testenv]