diff mbox series

[3/6] templates: Add mailing list archive link to patch detail page

Message ID 20190808024015.8102-3-ajd@linux.ibm.com
State Superseded
Headers show
Series [1/6] models, templates: Add project list archive URL field | expand

Commit Message

Andrew Donnellan Aug. 8, 2019, 2:40 a.m. UTC
Add a link to the mailing list archive link to the patch detail page.

Suggested-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
---
 patchwork/templates/patchwork/submission.html | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Daniel Axtens Aug. 21, 2019, 10:24 a.m. UTC | #1
Hi Andrew,

> Add a link to the mailing list archive link to the patch detail page.
>

I don't know if the patchwork archive is on such an archive service,,
but if so please could you add it to the fixture?

Regards,
Daniel
> Suggested-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
> ---
>  patchwork/templates/patchwork/submission.html | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/patchwork/templates/patchwork/submission.html b/patchwork/templates/patchwork/submission.html
> index b1ae5429191d..9cebbbeb89aa 100644
> --- a/patchwork/templates/patchwork/submission.html
> +++ b/patchwork/templates/patchwork/submission.html
> @@ -34,7 +34,11 @@ function toggle_div(link_id, headers_id)
>  <table class="patchmeta">
>   <tr>
>    <th>Message ID</th>
> +  {% if submission.list_archive_url %}
> +  <td>{{ submission.msgid|msgid }} (<a href="{{ submission.list_archive_url }}">mailing list archive</a>)</td>
> +  {% else %}
>    <td>{{ submission.msgid|msgid }}</td>
> +  {% endif %}
>   </tr>
>  {% if submission.state %}
>   <tr>
> -- 
> 2.20.1
>
> _______________________________________________
> Patchwork mailing list
> Patchwork@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork
Andrew Donnellan Aug. 22, 2019, 3:55 a.m. UTC | #2
On 21/8/19 8:24 pm, Daniel Axtens wrote:
> Hi Andrew,
> 
>> Add a link to the mailing list archive link to the patch detail page.
>>
> 
> I don't know if the patchwork archive is on such an archive service,,
> but if so please could you add it to the fixture?

We don't have a message-id redirector on lists.ozlabs.org, but I can use 
the mail-archive.com service which does index the patchwork list.


Andrew


> 
> Regards,
> Daniel
>> Suggested-by: Takashi Iwai <tiwai@suse.de>
>> Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
>> ---
>>   patchwork/templates/patchwork/submission.html | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/patchwork/templates/patchwork/submission.html b/patchwork/templates/patchwork/submission.html
>> index b1ae5429191d..9cebbbeb89aa 100644
>> --- a/patchwork/templates/patchwork/submission.html
>> +++ b/patchwork/templates/patchwork/submission.html
>> @@ -34,7 +34,11 @@ function toggle_div(link_id, headers_id)
>>   <table class="patchmeta">
>>    <tr>
>>     <th>Message ID</th>
>> +  {% if submission.list_archive_url %}
>> +  <td>{{ submission.msgid|msgid }} (<a href="{{ submission.list_archive_url }}">mailing list archive</a>)</td>
>> +  {% else %}
>>     <td>{{ submission.msgid|msgid }}</td>
>> +  {% endif %}
>>    </tr>
>>   {% if submission.state %}
>>    <tr>
>> -- 
>> 2.20.1
>>
>> _______________________________________________
>> Patchwork mailing list
>> Patchwork@lists.ozlabs.org
>> https://lists.ozlabs.org/listinfo/patchwork
diff mbox series

Patch

diff --git a/patchwork/templates/patchwork/submission.html b/patchwork/templates/patchwork/submission.html
index b1ae5429191d..9cebbbeb89aa 100644
--- a/patchwork/templates/patchwork/submission.html
+++ b/patchwork/templates/patchwork/submission.html
@@ -34,7 +34,11 @@  function toggle_div(link_id, headers_id)
 <table class="patchmeta">
  <tr>
   <th>Message ID</th>
+  {% if submission.list_archive_url %}
+  <td>{{ submission.msgid|msgid }} (<a href="{{ submission.list_archive_url }}">mailing list archive</a>)</td>
+  {% else %}
   <td>{{ submission.msgid|msgid }}</td>
+  {% endif %}
  </tr>
 {% if submission.state %}
  <tr>