From patchwork Tue Apr 4 21:38:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Finucane X-Patchwork-Id: 746967 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vyMmN5lFPz9s7c for ; Wed, 5 Apr 2017 07:38:44 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="key not found in DNS" (0-bit key; unprotected) header.d=that.guru header.i=@that.guru header.b="Xpsl5VUN"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3vyMmN4fcXzDqHq for ; Wed, 5 Apr 2017 07:38:44 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="key not found in DNS" (0-bit key; unprotected) header.d=that.guru header.i=@that.guru header.b="Xpsl5VUN"; dkim-atps=neutral X-Original-To: patchwork@lists.ozlabs.org Delivered-To: patchwork@lists.ozlabs.org Received: from cat.maple.relay.mailchannels.net (cat.maple.relay.mailchannels.net [23.83.214.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3vyMmF6kFtzDqH7 for ; Wed, 5 Apr 2017 07:38:37 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="key not found in DNS" (0-bit key; unprotected) header.d=that.guru header.i=@that.guru header.b="Xpsl5VUN"; dkim-atps=neutral X-Sender-Id: mxroute|x-authuser|stephen@that.guru Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id B8C297C3A79; Tue, 4 Apr 2017 21:38:34 +0000 (UTC) Received: from one.mxroute.com (unknown [100.96.133.151]) by relay.mailchannels.net (Postfix) with ESMTPA id 420027C42B1; Tue, 4 Apr 2017 21:38:34 +0000 (UTC) X-Sender-Id: mxroute|x-authuser|stephen@that.guru Received: from one.mxroute.com (one-outgoing.mxroute.com [172.20.104.49]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.7.37); Tue, 04 Apr 2017 21:38:34 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: mxroute|x-authuser|stephen@that.guru X-MailChannels-Auth-Id: mxroute X-Cellar-Grain: 3dcd6c1675c04579_1491341914573_1896643537 X-MC-Loop-Signature: 1491341914573:495946614 X-MC-Ingress-Time: 1491341914573 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=that.guru; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Whk/M3kqF8vYRDLisoZgnwy25Dx49YhE/8HLLu6u9jg=; b=Xpsl5VUNz1NWNpVr04lu17MFpj thRbvGZ1TL9yzgCobe0UIQRLugYLt6HgKvYXxVMmN0S6pVoWDzmUoZUm48C2O1Kj6VH1uQh6cvn0s X5dTittamDsjd64Ehsns67ju027TIMQ4/ixFasrDyp10kNG1vFuEuytgcCwUmXDObzivHV1hFsYHf HWpK0d+9hC1+eDNJ7XXAlKQtIZulFciYgD2NvNHl7orsSQM6zUPfM3PIZbPpMWz4jM6aFOKg18TLI hoP8/fGZ8MHq2jDnSGgc/7Zinh0yZzTgn5h3hanjEYhT/amBfbqIYWu4DvkM2G2fCwxEghNpIP6wj syTe3BTA==; From: Stephen Finucane To: patchwork@lists.ozlabs.org Subject: [PATCH 3/4] requirements: Test older versions of DRF (v2) Date: Tue, 4 Apr 2017 22:38:19 +0100 Message-Id: <20170404213820.13350-3-stephen@that.guru> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170404213820.13350-1-stephen@that.guru> References: <20170404213820.13350-1-stephen@that.guru> X-OutGoing-Spam-Status: No, score=-10.0 X-AuthUser: stephen@that.guru X-BeenThere: patchwork@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Patchwork development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Patchwork" In commit febad055fb6609369f1a465a5eec323549c5c065, we attempted to start testing older versions of Django REST Framework for use with older versions of Django. This work was later reverted in commit 6f2ddab6e60aac91dac782aeccd2ecd35416c271 due to perceived issues with django-filter versions. There are additional reasons for validating older versions of DRF, such as supporting the versions provide as part of distributions. It turns out that those issues aren't such a big deal and can be handled with a shim. All in all, this means we can and should support these older versions of Django REST Framework, and that is what we'll do. Note that the minimum version supported in requirements.txt is not bumped as it's good practive to use the latest available version. However, that doesn't make it any less supported. Signed-off-by: Stephen Finucane Cc: Daniel Axtens --- README.md | 9 +++++++++ patchwork/settings/dev.py | 3 +-- tox.ini | 4 ++++ 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 488dad4..a3c66bf 100644 --- a/README.md +++ b/README.md @@ -23,6 +23,15 @@ subsystems of the Linux kernel. Although Patchwork has been developed with the kernel workflow in mind, the aim is to be flexible enough to suit the majority of community projects. +# Requirements + +- Python (2.7, 3.3 - 3.5) +- Django (1.6 - 1.10) +- Django REST Framework (3.2 - 3.6) (\*) +- Django Filters (0.11 - 1.0) (\*\*) + +Note that various dependencies have their own requirements + # Development Installation [Docker][ref-docker] is the recommended installation methods for a Patchwork diff --git a/patchwork/settings/dev.py b/patchwork/settings/dev.py index ee5b203..86b0f1b 100644 --- a/patchwork/settings/dev.py +++ b/patchwork/settings/dev.py @@ -92,5 +92,4 @@ if django.VERSION >= (1, 8): ENABLE_XMLRPC = True -if django.VERSION >= (1, 8): - ENABLE_REST_API = True +ENABLE_REST_API = True diff --git a/tox.ini b/tox.ini index bf38f8f..8cf23f6 100644 --- a/tox.ini +++ b/tox.ini @@ -7,7 +7,11 @@ skipsdist = True deps = -r{toxinidir}/requirements-test.txt django16: django>=1.6,<1.7 + django16: djangorestframework>=3.2,<3.3 + django16: django-filter>=0.11,<0.12 django17: django>=1.7,<1.8 + django17: djangorestframework>=3.3,<3.4 + django17: django-filter>=0.11,<0.12 django18: django>=1.8,<1.9 django19: django>=1.9,<1.10 django110: django>=1.10,<1.11