| Message ID | 1470718525-32603-6-git-send-email-dja@axtens.net |
|---|---|
| State | Changes Requested |
| Headers | show |
On 09 Aug 14:55, Daniel Axtens wrote: > Python 3.4 is now out of date, so bump up to 3.5. This is what is > shipped with Ubuntu 16.04, and it's the new stable release. > (Indeed, Ubuntu 16.04 doesn't provide Python 3.4!) > > Django 1.7 doesn't work with 3.5. If you're an old Django, you're > probably better off on 2.7 than a random old 3.x, so let's just > test against 2.7 for those. > > Signed-off-by: Daniel Axtens <dja@axtens.net> I wasn't able to find the deprecation timeline for Python 3.4 (I didn't try very hard :)), but I did find the one for Ubuntu 14.04 which only provides Python 3.4 afaik. Ubuntu 14.04 is supported until 2020 [1] and is rather widely used. What about keeping Python 3.4 tests and simply adding 3.5? Stephen [1] https://wiki.ubuntu.com/Releases
Hi Stephen, > > I wasn't able to find the deprecation timeline for Python 3.4 (I didn't > try very hard :)), but I did find the one for Ubuntu 14.04 which only > provides Python 3.4 afaik. Ubuntu 14.04 is supported until 2020 [1] and > is rather widely used. What about keeping Python 3.4 tests and simply > adding 3.5? Hmm, fair enough. The problem is that Ubuntu 16.04 drops Py3.4, and I have Ubuntu 16.04 :P I'll figure out how to install py34 in 16.04 and respin the patch. Regards, Daniel > > Stephen > > [1] https://wiki.ubuntu.com/Releases
On 24 Aug 10:58, Daniel Axtens wrote: > Hi Stephen, > > > > > I wasn't able to find the deprecation timeline for Python 3.4 (I didn't > > try very hard :)), but I did find the one for Ubuntu 14.04 which only > > provides Python 3.4 afaik. Ubuntu 14.04 is supported until 2020 [1] and > > is rather widely used. What about keeping Python 3.4 tests and simply > > adding 3.5? > > Hmm, fair enough. > > The problem is that Ubuntu 16.04 drops Py3.4, and I have Ubuntu 16.04 :P > > I'll figure out how to install py34 in 16.04 and respin the patch. > > Regards, > Daniel I've seen the Python 3.4-in-Docker patch you provided, so it seems you're already pursuing a solution here. However, I'd be fine to include both Python 3.4 and 3.5, even if not everyone could run them. The differences between the two are essentially meaningless for what we're doing. Stephen
On 30 Aug 00:49, Stephen Finucane wrote: > On 24 Aug 10:58, Daniel Axtens wrote: > > Hi Stephen, > > > > > > > > I wasn't able to find the deprecation timeline for Python 3.4 (I didn't > > > try very hard :)), but I did find the one for Ubuntu 14.04 which only > > > provides Python 3.4 afaik. Ubuntu 14.04 is supported until 2020 [1] and > > > is rather widely used. What about keeping Python 3.4 tests and simply > > > adding 3.5? > > > > Hmm, fair enough. > > > > The problem is that Ubuntu 16.04 drops Py3.4, and I have Ubuntu 16.04 :P > > > > I'll figure out how to install py34 in 16.04 and respin the patch. > > > > Regards, > > Daniel > > I've seen the Python 3.4-in-Docker patch you provided, so it seems > you're already pursuing a solution here. However, I'd be fine to > include both Python 3.4 and 3.5, even if not everyone could run them. > The differences between the two are essentially meaningless for what > we're doing. > > Stephen I modified this to keep Python 3.4 while adding Python 3.5 support, then merged. Cheers! Stephen
diff --git a/tox.ini b/tox.ini index 37e6939157f4..9a113ccd60f9 100644 --- a/tox.ini +++ b/tox.ini @@ -1,6 +1,6 @@ [tox] minversion = 2.0 -envlist = py{27,34}-django{16,17,18,19} +envlist = py27-django{16,17,18,19},py35-django{18,19} skipsdist = True [testenv]
Python 3.4 is now out of date, so bump up to 3.5. This is what is shipped with Ubuntu 16.04, and it's the new stable release. (Indeed, Ubuntu 16.04 doesn't provide Python 3.4!) Django 1.7 doesn't work with 3.5. If you're an old Django, you're probably better off on 2.7 than a random old 3.x, so let's just test against 2.7 for those. Signed-off-by: Daniel Axtens <dja@axtens.net> --- tox.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)