diff mbox

[3/3] Add Docker IP to whitelist for django-debug-toolbar

Message ID 1470717525-22872-4-git-send-email-dja@axtens.net
State Accepted
Headers show

Commit Message

Daniel Axtens Aug. 9, 2016, 4:38 a.m. UTC 
Yay for debugging with Docker.

Signed-off-by: Daniel Axtens <dja@axtens.net>
---
 patchwork/settings/dev.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Andrew Donnellan Aug. 9, 2016, 4:45 a.m. UTC | #1 
On 09/08/16 14:38, Daniel Axtens wrote:
> Yay for debugging with Docker.
>
> Signed-off-by: Daniel Axtens <dja@axtens.net>

Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Stephen Finucane Aug. 21, 2016, 2:17 p.m. UTC | #2 
On 09 Aug 14:38, Daniel Axtens wrote:
> Yay for debugging with Docker.
> 
> Signed-off-by: Daniel Axtens <dja@axtens.net>

Depends on the Docker work, but this can go in straight after.

Reviewed-by: Stephen Finucane <stephenfinucane@hotmail.com>
Stephen Finucane Aug. 21, 2016, 3:30 p.m. UTC | #3 
On 21 Aug 15:17, Stephen Finucane wrote:
> On 09 Aug 14:38, Daniel Axtens wrote:
> > Yay for debugging with Docker.
> > 
> > Signed-off-by: Daniel Axtens <dja@axtens.net>
> 
> Depends on the Docker work, but this can go in straight after.
> 
> Reviewed-by: Stephen Finucane <stephenfinucane@hotmail.com>

Merged this. Haven't merged the other patches yet in case we pursue
with bumping the Django Debug Toolbar version instead.

Stephen
diff mbox

Patch

diff --git a/patchwork/settings/dev.py b/patchwork/settings/dev.py
index 127e15d9ebcd..99cb72e335cf 100644
--- a/patchwork/settings/dev.py
+++ b/patchwork/settings/dev.py
@@ -78,7 +78,10 @@  if django.VERSION >= (1, 7):
         'debug_toolbar.middleware.DebugToolbarMiddleware',
     ] + MIDDLEWARE_CLASSES
 
-    INTERNAL_IPS = ['127.0.0.1', '::1']
+    INTERNAL_IPS = [
+        '127.0.0.1', '::1',
+        '172.17.0.1'
+    ]
 
 
 #